Another unhandled error during authentication #1900
Description
Describe the bug
osc crashes on authentication failure
Versions
- Operating system:
openSUSE Leap 16.0 - Packages:
osc-1.19.0-lp160.456.1.noarch
To Reproduce
Steps to reproduce the behavior:
- Run command when no authentication cookie is saved
Expected behavior
A clear error mesasage
Screenshots, console outputs
Traceback (most recent call last):
File "/usr/bin/osc", line 33, in
sys.exit(load_entry_point('osc==1.19.0', 'console_scripts', 'osc')())
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/usr/lib/python3.13/site-packages/osc/babysitter.py", line 256, in main
sys.exit(run(commandline.OscMainCommand()))
~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.13/site-packages/osc/babysitter.py", line 54, in run
prg.main(argv)
~~~~~~~~^^^^^^
File "/usr/lib/python3.13/site-packages/osc/commandline.py", line 300, in main
exit_code = cmd.run(args)
File "/usr/lib/python3.13/site-packages/osc/commandline_common.py", line 221, in run
return cmd.run(args)
~~~~~~~^^^^^^
File "/usr/lib/python3.13/site-packages/osc/commandline.py", line 241, in run
return self.func(args.command, args, *args.positional_args)
~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.13/site-packages/osc/commandline.py", line 9285, in do_search
res = search(apiurl, **what)
File "/usr/lib/python3.13/site-packages/osc/core.py", line 5203, in search
f = http_GET(u)
File "/usr/lib/python3.13/site-packages/osc/connection.py", line 404, in http_GET
return http_request("GET", *args, **kwargs)
File "/usr/lib/python3.13/site-packages/osc/connection.py", line 149, in new_func
return func(method, url, headers, data, file)
File "/usr/lib/python3.13/site-packages/osc/connection.py", line 385, in http_request
success = handler.set_request_headers_after_401(url, headers, response)
File "/usr/lib/python3.13/site-packages/osc/connection.py", line 759, in set_request_headers_after_401
return self.add_signature_auth_header(request_headers, auth_schemes["signature"])
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.13/site-packages/osc/connection.py", line 722, in add_signature_auth_header
auth = self.get_authorization(chal)
File "/usr/lib/python3.13/site-packages/osc/connection.py", line 714, in get_authorization
signature = self.ssh_sign(sigdata, realm, self.sshkey)
File "/usr/lib/python3.13/site-packages/osc/connection.py", line 692, in ssh_sign
proc = subprocess.run(cmd, check=True, cwd=tmp_dir)
File "/usr/lib64/python3.13/subprocess.py", line 577, in run
raise CalledProcessError(retcode, process.args,
output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['/usr/bin/ssh-keygen', '-Y', 'sign'