fix: drop build_filter and use build_regex for server-side filtering

Motivation:
Drop the redundant build_filter configuration parameter as it caused
confusion when it overlapped with build_regex.

Design Choices:
Removed build_filter from Settings, IncrementConfig, and CLI arguments.
Updated load_build_info to use build_regex directly for server-side OBS
filtering.

Benefits:
Simplified configuration and code logic, avoiding ambiguity between two
filtering parameters that were often used for the same purpose.

Related issue:
#496 (comment)

Author: okurz

openqabot/args.py

@@ -592,14 +592,6 @@ def increment_approve(  # noqa: PLR0913
         str,
         typer.Option("--product-regex", help="The regex used to determine what products are relevant"),
     ] = "^SLE.*",
-    build_filter: Annotated[
-        str | None,
-        typer.Option(
-            "--build-filter",
-            envvar="QEM_BOT_BUILD_FILTER",
-            help="The server-side pattern matching filter for the build listing",
-        ),
-    ] = config_module.settings.build_filter,
     increment_config: Annotated[
         Path | None,
         typer.Option(
@@ -626,7 +618,6 @@ def increment_approve(  # noqa: PLR0913
     args.build_listing_sub_path = build_listing_sub_path
     args.build_regex = build_regex
     args.product_regex = product_regex
-    args.build_filter = build_filter
     args.increment_config = increment_config
     args.comment = comment
 

openqabot/config.py

@@ -45,7 +45,6 @@ class Settings(BaseSettings):
     singlearch: Path = Field(default=Path("/etc/openqabot/singlearch.yml"), alias="QEM_BOT_SINGLEARCH")
     retry: int = Field(default=2, alias="QEM_BOT_RETRY")
     approve_comment: bool = Field(default=False, alias="QEM_BOT_APPROVE_COMMENT")
-    build_filter: str | None = Field(default=None, alias="QEM_BOT_BUILD_FILTER")
 
     # App-specific settings
     qem_dashboard_url: str = Field(default="http://dashboard.qam.suse.de/", alias="QEM_DASHBOARD_URL")

openqabot/loader/buildinfo.py

@@ -32,7 +32,7 @@ def load_build_info(
     build_project_url = config.build_project_url()
     sub_path = config.build_listing_sub_path
     url = f"{build_project_url}/{sub_path}/"
-    params = get_obs_filter_params(config.build_filter or build_regex)
+    params = get_obs_filter_params(build_regex)
     log.debug("Checking for '%s' files on %s with params %s", build_regex, url, params)
     rows = retried_requests.get(url, params=params).json().get("data", [])
 

openqabot/loader/incrementconfig.py

@@ -41,7 +41,6 @@ class IncrementConfig:
     build_listing_sub_path: str = ""
     build_regex: str = ""
     product_regex: str = ""
-    build_filter: str | None = field(default_factory=lambda: config.settings.build_filter)
     version_regex: str = DEFAULT_VERSION_REGEX
     packages: list[str] = field(default_factory=list)
     archs: set[str] = field(default_factory=set)
@@ -91,7 +90,6 @@ def from_config_entry(entry: dict[str, Any]) -> IncrementConfig:
             build_listing_sub_path=entry["build_listing_sub_path"],
             build_regex=entry["build_regex"],
             product_regex=entry["product_regex"],
-            build_filter=entry.get("build_filter", config.settings.build_filter),
             version_regex=entry.get("version_regex", DEFAULT_VERSION_REGEX),
             packages=entry.get("packages", []),
             archs=set(entry.get("archs", [])),