bot uses SMELT ids to track tests and approve updates, but release-request (ibs) ids should be used

[michaelgrifalconi]

Context:

Bot uses SMELT ids but they are not unique.

Today's example: https://smelt.suse.de/incident/32869/
The same SMELT id is used for 2 different updates, one tested until yesterday and then revoked, one under test now.

openQA only include SMELT ids to track what is being tested so when a human wants to check if a result is relevant, he needs:

• openQA settings with SMELT id
• check openQA test date > ibs release request creation date

I guess the reason is that updates are put in repos containing the SMELT id but such repos content can change when a new request is created in ibs. What is being approved is still the ibs release request id, not the incident.

Also mentioned here https://progress.opensuse.org/issues/153886

Current workaround:

The bot is completely unaware about this issue, but uses the dashboard database as job result cache. In that "cache", the data is altered to workaround this issue qem-dashboard/#78 and hide the problem.

Issue:

• Makes it impossible to move out of the dashboard "cache" in favor of a direct access to openQA

• This breaks the concept of looking at older results directly on openQA while trying to approve updates Approve jobs if at least older jobs passed #168

• Adds complexity to the approval decision, especially if a human needs to take a look manually

Proposal:

Add release requests ids to openQA jobs in a new ENV variable like "RR_IDS: 1234,1235,1236" the same as it's being done with incident ids (BASE_TEST_ISSUES, etc.).
This would be a non-disruptive change as it's just adding more information to test runs.

[dzedro]

Incidents already have RRID=SUSE:Maintenance:<ID>:<RR>, not sure how it's used.