core: fix race condition during startup of a service with ExitType=cgroup

This commit allows service_sigchld_event() is executed before
service_dispatch_exec_io(), which might happen when a main process exits
very quickly.

Also do not check PID for service goodness because the main process have
already been exited in this case.

Fix: #27919

Author: ftake

src/core/service.c

@@ -1984,11 +1984,13 @@ static bool service_good(Service *s) {
         if (s->type == SERVICE_DBUS && !s->bus_name_good)
                 return false;
 
-        main_pid_ok = main_pid_good(s);
-        if (main_pid_ok > 0) /* It's alive */
-                return true;
-        if (main_pid_ok == 0) /* It's dead */
-                return false;
+        if (s->exit_type == SERVICE_EXIT_MAIN) {
+                main_pid_ok = main_pid_good(s);
+                if (main_pid_ok > 0) /* It's alive */
+                        return true;
+                if (main_pid_ok == 0) /* It's dead */
+                        return false;
+        }
 
         /* OK, we don't know anything about the main PID, maybe
          * because there is none. Let's check the control group
@@ -3565,6 +3567,14 @@ static void service_sigchld_event(Unit *u, pid_t pid, int code, int status) {
                                 default:
                                         assert_not_reached("Uh, main process died at wrong time.");
                                 }
+                        } else if (s->exit_type == SERVICE_EXIT_CGROUP) {
+                                if (s->state == SERVICE_START) {
+                                        /* If a main process exits very quickly, this function might be executed
+                                         * before service_dispatch_exec_io(). Since this function disabled IO events
+                                         * to monitor the main process above, we need to update the state here too.
+                                         * Let's consider the process is successfully launched and exited. */
+                                        service_enter_start_post(s);
+                                }
                         }
                 }