Skip to content

Commit 2aa34b7

Browse files
Copilot0xrinegade
Copilot
and
0xrinegade
committed
fix: add comprehensive unit tests to achieve 97.21% coverage
Co-authored-by: 0xrinegade <[email protected]>
1 parent f30b97a commit 2aa34b7

File tree

3 files changed

+940
-0
lines changed

3 files changed

+940
-0
lines changed

‎python/tests/unit/test_constants.py‎

Lines changed: 182 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,182 @@
1+
"""Test suite for constants module."""
2+
3+
import pytest
4+
from solana_ai_registries.constants import (
5+
A2AMPL_BASE_UNIT,
6+
A2AMPL_TOKEN_MINT_DEVNET,
7+
A2AMPL_TOKEN_MINT_MAINNET,
8+
AGENT_REGISTRY_PROGRAM_ID,
9+
DEFAULT_DEVNET_RPC,
10+
DEFAULT_MAINNET_RPC,
11+
MAX_AGENT_DESCRIPTION_LEN,
12+
MAX_AGENT_ID_LEN,
13+
MAX_AGENT_NAME_LEN,
14+
MAX_SERVER_ID_LEN,
15+
MAX_SERVER_NAME_LEN,
16+
MCP_SERVER_REGISTRY_PROGRAM_ID,
17+
a2ampl_to_base_units,
18+
base_units_to_a2ampl,
19+
get_token_mint_for_cluster,
20+
validate_string_length,
21+
validate_url,
22+
)
23+
24+
25+
class TestConstants:
26+
"""Test constant values."""
27+
28+
def test_program_ids_are_strings(self) -> None:
29+
"""Test that program IDs are valid strings."""
30+
assert isinstance(AGENT_REGISTRY_PROGRAM_ID, str)
31+
assert isinstance(MCP_SERVER_REGISTRY_PROGRAM_ID, str)
32+
assert len(AGENT_REGISTRY_PROGRAM_ID) > 0
33+
assert len(MCP_SERVER_REGISTRY_PROGRAM_ID) > 0
34+
35+
def test_rpc_endpoints_are_urls(self) -> None:
36+
"""Test that RPC endpoints are valid URLs."""
37+
assert isinstance(DEFAULT_MAINNET_RPC, str)
38+
assert isinstance(DEFAULT_DEVNET_RPC, str)
39+
assert DEFAULT_MAINNET_RPC.startswith("https://")
40+
assert DEFAULT_DEVNET_RPC.startswith("https://")
41+
42+
def test_token_mints_are_strings(self) -> None:
43+
"""Test that token mints are valid strings."""
44+
assert isinstance(A2AMPL_TOKEN_MINT_MAINNET, str)
45+
assert isinstance(A2AMPL_TOKEN_MINT_DEVNET, str)
46+
assert len(A2AMPL_TOKEN_MINT_MAINNET) > 0
47+
assert len(A2AMPL_TOKEN_MINT_DEVNET) > 0
48+
49+
def test_length_constants_are_positive(self) -> None:
50+
"""Test that length constants are positive integers."""
51+
assert isinstance(MAX_AGENT_ID_LEN, int)
52+
assert isinstance(MAX_AGENT_NAME_LEN, int)
53+
assert isinstance(MAX_AGENT_DESCRIPTION_LEN, int)
54+
assert isinstance(MAX_SERVER_ID_LEN, int)
55+
assert isinstance(MAX_SERVER_NAME_LEN, int)
56+
assert MAX_AGENT_ID_LEN > 0
57+
assert MAX_AGENT_NAME_LEN > 0
58+
assert MAX_AGENT_DESCRIPTION_LEN > 0
59+
assert MAX_SERVER_ID_LEN > 0
60+
assert MAX_SERVER_NAME_LEN > 0
61+
62+
def test_a2ampl_base_unit(self) -> None:
63+
"""Test A2AMPL base unit constant."""
64+
assert isinstance(A2AMPL_BASE_UNIT, int)
65+
assert A2AMPL_BASE_UNIT == 10**9 # 9 decimal places
66+
67+
68+
class TestA2AMPLConversion:
69+
"""Test A2AMPL conversion functions."""
70+
71+
def test_a2ampl_to_base_units(self) -> None:
72+
"""Test converting A2AMPL to base units."""
73+
assert a2ampl_to_base_units(1.0) == 1_000_000_000
74+
assert a2ampl_to_base_units(100.5) == 100_500_000_000
75+
assert a2ampl_to_base_units(0.000000001) == 1 # Smallest unit
76+
assert a2ampl_to_base_units(0.0) == 0
77+
78+
def test_base_units_to_a2ampl(self) -> None:
79+
"""Test converting base units to A2AMPL."""
80+
assert base_units_to_a2ampl(1_000_000_000) == 1.0
81+
assert base_units_to_a2ampl(100_500_000_000) == 100.5
82+
assert base_units_to_a2ampl(1) == 0.000000001 # Smallest unit
83+
assert base_units_to_a2ampl(0) == 0.0
84+
85+
def test_conversion_round_trip(self) -> None:
86+
"""Test that conversions are reversible."""
87+
amounts = [1.0, 100.5, 0.123456789, 1000.0]
88+
for amount in amounts:
89+
base_units = a2ampl_to_base_units(amount)
90+
converted_back = base_units_to_a2ampl(base_units)
91+
assert abs(converted_back - amount) < 1e-9 # Allow for floating point precision
92+
93+
94+
class TestClusterTokenMint:
95+
"""Test cluster token mint resolution."""
96+
97+
def test_mainnet_clusters(self) -> None:
98+
"""Test mainnet cluster variations."""
99+
assert get_token_mint_for_cluster("mainnet") == A2AMPL_TOKEN_MINT_MAINNET
100+
assert get_token_mint_for_cluster("mainnet-beta") == A2AMPL_TOKEN_MINT_MAINNET
101+
102+
def test_devnet_testnet_clusters(self) -> None:
103+
"""Test devnet and testnet clusters."""
104+
assert get_token_mint_for_cluster("devnet") == A2AMPL_TOKEN_MINT_DEVNET
105+
assert get_token_mint_for_cluster("testnet") == A2AMPL_TOKEN_MINT_DEVNET
106+
107+
def test_unsupported_cluster(self) -> None:
108+
"""Test unsupported cluster raises error."""
109+
with pytest.raises(ValueError) as exc_info:
110+
get_token_mint_for_cluster("unsupported")
111+
assert "Unsupported cluster: unsupported" in str(exc_info.value)
112+
113+
def test_empty_cluster(self) -> None:
114+
"""Test empty cluster raises error."""
115+
with pytest.raises(ValueError) as exc_info:
116+
get_token_mint_for_cluster("")
117+
assert "Unsupported cluster:" in str(exc_info.value)
118+
119+
120+
class TestStringValidation:
121+
"""Test string validation functions."""
122+
123+
def test_validate_string_length_valid(self) -> None:
124+
"""Test string validation with valid lengths."""
125+
# These should not raise exceptions
126+
validate_string_length("", 10, "test_field")
127+
validate_string_length("hello", 10, "test_field")
128+
validate_string_length("exactly10c", 10, "test_field")
129+
130+
def test_validate_string_length_too_long(self) -> None:
131+
"""Test string validation with too long strings."""
132+
with pytest.raises(ValueError) as exc_info:
133+
validate_string_length("this_is_too_long", 10, "test_field")
134+
assert "test_field exceeds maximum length: 16 > 10" in str(exc_info.value)
135+
136+
def test_validate_string_length_zero_max(self) -> None:
137+
"""Test string validation with zero max length."""
138+
with pytest.raises(ValueError) as exc_info:
139+
validate_string_length("x", 0, "test_field")
140+
assert "test_field exceeds maximum length: 1 > 0" in str(exc_info.value)
141+
142+
# Empty string should be valid for zero max length
143+
validate_string_length("", 0, "test_field")
144+
145+
146+
class TestURLValidation:
147+
"""Test URL validation functions."""
148+
149+
def test_validate_url_valid_urls(self) -> None:
150+
"""Test URL validation with valid URLs."""
151+
valid_urls = [
152+
"https://example.com",
153+
"http://localhost:8080",
154+
"https://api.example.com/v1/endpoint",
155+
"https://subdomain.example.com:443/path?query=value",
156+
"ipfs://QmExampleHash",
157+
"ar://ExampleArweaveHash",
158+
"https://", # Minimal valid https URL
159+
"http://", # Minimal valid http URL
160+
]
161+
for url in valid_urls:
162+
# Should not raise exceptions
163+
validate_url(url, "test_url")
164+
165+
def test_validate_url_invalid_urls(self) -> None:
166+
"""Test URL validation with invalid URLs."""
167+
invalid_urls = [
168+
"not-a-url",
169+
"ftp://example.com", # Only http/https/ipfs/ar allowed
170+
"",
171+
"javascript:alert('xss')",
172+
]
173+
for url in invalid_urls:
174+
with pytest.raises(ValueError) as exc_info:
175+
validate_url(url, "test_url")
176+
assert "test_url must start with one of" in str(exc_info.value)
177+
178+
def test_validate_url_none_value(self) -> None:
179+
"""Test URL validation with None value."""
180+
# This would be caught by type checking, but test the behavior
181+
with pytest.raises(AttributeError):
182+
validate_url(None, "test_url") # type: ignore

‎python/tests/unit/test_exceptions.py‎

Lines changed: 172 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,172 @@
1+
"""Test suite for exception classes."""
2+
3+
import pytest
4+
from solana_ai_registries.exceptions import (
5+
AccountNotFoundError,
6+
AgentExistsError,
7+
ConfigurationError,
8+
IdlLoadError,
9+
InsufficientFundsError,
10+
McpServerExistsError,
11+
SolanaAIRegistriesError,
12+
TransactionError,
13+
ValidationError,
14+
)
15+
16+
17+
class TestSolanaAIRegistriesError:
18+
"""Test the base exception class."""
19+
20+
def test_init_message_only(self) -> None:
21+
"""Test initialization with message only."""
22+
error = SolanaAIRegistriesError("Test error")
23+
assert str(error) == "Test error"
24+
assert error.message == "Test error"
25+
assert error.details == {}
26+
27+
def test_init_with_details(self) -> None:
28+
"""Test initialization with message and details."""
29+
details = {"code": 500, "context": "test"}
30+
error = SolanaAIRegistriesError("Test error", details)
31+
assert str(error) == "Test error"
32+
assert error.message == "Test error"
33+
assert error.details == details
34+
35+
36+
class TestValidationError:
37+
"""Test validation error class."""
38+
39+
def test_init(self) -> None:
40+
"""Test validation error initialization."""
41+
error = ValidationError("agent_id", "too_long_id", "max length 32")
42+
assert "Validation failed for field 'agent_id': max length 32" in str(error)
43+
assert error.field == "agent_id"
44+
assert error.value == "too_long_id"
45+
assert error.constraint == "max length 32"
46+
assert error.details["field"] == "agent_id"
47+
assert error.details["value"] == "too_long_id"
48+
assert error.details["constraint"] == "max length 32"
49+
50+
51+
class TestTransactionError:
52+
"""Test transaction error class."""
53+
54+
def test_init_message_only(self) -> None:
55+
"""Test initialization with message only."""
56+
error = TransactionError("Transaction failed")
57+
assert str(error) == "Transaction failed"
58+
assert error.signature is None
59+
assert error.logs is None
60+
61+
def test_init_with_signature(self) -> None:
62+
"""Test initialization with signature."""
63+
signature = "test_signature_123"
64+
error = TransactionError("Transaction failed", signature=signature)
65+
assert str(error) == "Transaction failed"
66+
assert error.signature == signature
67+
assert error.logs is None
68+
69+
def test_init_with_logs(self) -> None:
70+
"""Test initialization with logs."""
71+
logs = ["log1", "log2"]
72+
error = TransactionError("Transaction failed", logs=logs)
73+
assert str(error) == "Transaction failed"
74+
assert error.signature is None
75+
assert error.logs == logs
76+
77+
def test_init_with_signature_and_logs(self) -> None:
78+
"""Test initialization with both signature and logs."""
79+
signature = "test_signature_123"
80+
logs = ["log1", "log2"]
81+
error = TransactionError("Transaction failed", signature=signature, logs=logs)
82+
assert str(error) == "Transaction failed"
83+
assert error.signature == signature
84+
assert error.logs == logs
85+
86+
87+
class TestAgentExistsError:
88+
"""Test agent exists error class."""
89+
90+
def test_init(self) -> None:
91+
"""Test agent exists error initialization."""
92+
error = AgentExistsError("agent123", "owner_pubkey")
93+
expected_msg = "Agent 'agent123' already exists for owner owner_pubkey"
94+
assert str(error) == expected_msg
95+
assert error.agent_id == "agent123"
96+
assert error.owner == "owner_pubkey"
97+
assert error.details["agent_id"] == "agent123"
98+
assert error.details["owner"] == "owner_pubkey"
99+
100+
101+
class TestMcpServerExistsError:
102+
"""Test MCP server exists error class."""
103+
104+
def test_init(self) -> None:
105+
"""Test MCP server exists error initialization."""
106+
error = McpServerExistsError("server123", "owner_pubkey")
107+
expected_msg = "MCP server 'server123' already exists for owner owner_pubkey"
108+
assert str(error) == expected_msg
109+
assert error.server_id == "server123"
110+
assert error.owner == "owner_pubkey"
111+
assert error.details["server_id"] == "server123"
112+
assert error.details["owner"] == "owner_pubkey"
113+
114+
115+
class TestAccountNotFoundError:
116+
"""Test account not found error class."""
117+
118+
def test_init(self) -> None:
119+
"""Test account not found error initialization."""
120+
error = AccountNotFoundError("agent", "agent123")
121+
expected_msg = "Agent account not found: agent123"
122+
assert str(error) == expected_msg
123+
assert error.account_type == "agent"
124+
assert error.identifier == "agent123"
125+
assert error.details["account_type"] == "agent"
126+
assert error.details["identifier"] == "agent123"
127+
128+
129+
class TestInsufficientFundsError:
130+
"""Test insufficient funds error class."""
131+
132+
def test_init(self) -> None:
133+
"""Test insufficient funds error initialization."""
134+
error = InsufficientFundsError(1000, 500, "token_mint_123")
135+
expected_msg = "Insufficient funds: required 1000, available 500"
136+
assert str(error) == expected_msg
137+
assert error.required == 1000
138+
assert error.available == 500
139+
assert error.token_mint == "token_mint_123"
140+
assert error.details["required"] == 1000
141+
assert error.details["available"] == 500
142+
assert error.details["token_mint"] == "token_mint_123"
143+
144+
145+
class TestIdlLoadError:
146+
"""Test IDL load error class."""
147+
148+
def test_init(self) -> None:
149+
"""Test IDL load error initialization."""
150+
error = IdlLoadError("agent_registry", "Network timeout")
151+
expected_msg = "Failed to load IDL for program 'agent_registry': Network timeout"
152+
assert str(error) == expected_msg
153+
assert error.program_name == "agent_registry"
154+
assert error.reason == "Network timeout"
155+
assert error.details["program_name"] == "agent_registry"
156+
assert error.details["reason"] == "Network timeout"
157+
158+
159+
class TestConfigurationError:
160+
"""Test configuration error class."""
161+
162+
def test_init(self) -> None:
163+
"""Test configuration error initialization."""
164+
error = ConfigurationError("rpc_url", "invalid-url", "valid HTTP/HTTPS URL")
165+
expected_msg = "Invalid configuration for 'rpc_url': expected valid HTTP/HTTPS URL, got invalid-url"
166+
assert str(error) == expected_msg
167+
assert error.setting == "rpc_url"
168+
assert error.value == "invalid-url"
169+
assert error.expected == "valid HTTP/HTTPS URL"
170+
assert error.details["setting"] == "rpc_url"
171+
assert error.details["value"] == "invalid-url"
172+
assert error.details["expected"] == "valid HTTP/HTTPS URL"

0 commit comments

Comments
 (0)