feat(ovsm): Add instruction data access functions

0xrinegade · claude · 0xrinegade · commit fcf5d71313ee · 2025-11-26T15:20:00.000+03:00
## New Functions - `instruction-data-len` - Get length of instruction data - `instruction-data-ptr` - Get pointer to instruction data buffer ## Bug Fix - Fixed account size calculation: 10336 bytes (not 10344) for zero-data accounts - Instruction data is now correctly located after all accounts ## Testing - Both functions verified on Solana devnet - Test program successfully reads 8-byte instruction data payload ## Limitation - Assumes all accounts have data_len=0 (standard for wallet accounts) - Version bump to 1.0.6 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/crates/ovsm/CHANGELOG.md b/crates/ovsm/CHANGELOG.md
@@ -7,6 +7,23 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.0.6] - 2025-11-26
+
+### Added
+- 🔧 **Instruction Data Access Functions** - Access instruction data passed to your program
+  - `instruction-data-len` - Get the length of instruction data in bytes
+  - `instruction-data-ptr` - Get pointer to instruction data buffer
+- ✅ Both functions verified on Solana devnet with test program
+
+### Fixed
+- 🐛 **Critical**: Fixed account size calculation for instruction data offset
+  - Account size is 10336 bytes for zero-data accounts (was incorrectly 10344)
+  - Instruction data is now correctly located after all accounts
+
+### Limitation
+- Instruction data functions assume all accounts have `data_len=0` (standard for wallet accounts)
+- Programs with data-bearing accounts may need a more sophisticated approach
+
 ## [1.0.5] - 2025-11-25
 
 ### Added
diff --git a/crates/ovsm/SBPF_COMPILER_BUILTINS.md b/crates/ovsm/SBPF_COMPILER_BUILTINS.md
@@ -797,10 +797,59 @@ The compiler reports estimated CU usage:
 
 ---
 
+### `instruction-data-len`
+
+**Signature:** `(instruction-data-len)`
+**Description:** Get the length of instruction data passed to the program
+**Returns:** u64 - Length in bytes
+**Tested:** ✅ Verified on devnet
+**Limitation:** Assumes all accounts have zero data (common case for wallet accounts)
+
+```lisp
+;; Check instruction data length
+(define len (instruction-data-len))
+(sol_log_ "Instruction data length:")
+(sol_log_64_ len)
+```
+
+---
+
+### `instruction-data-ptr`
+
+**Signature:** `(instruction-data-ptr)`
+**Description:** Get pointer to the instruction data buffer
+**Returns:** Pointer to instruction data
+**Tested:** ✅ Verified on devnet
+**Limitation:** Assumes all accounts have zero data
+
+```lisp
+;; Read instruction data
+(define ptr (instruction-data-ptr))
+(define first-byte (mem-load1 ptr 0))
+(sol_log_ "First byte of instruction data:")
+(sol_log_64_ first-byte)
+```
+
+**Example: Parsing Instruction Data**
+```lisp
+(do
+  (define len (instruction-data-len))
+
+  (if (>= len 8)
+      (do
+        (define ptr (instruction-data-ptr))
+        ;; Read first 8 bytes as u64 argument
+        (define arg1 (mem-load ptr 0))
+        (sol_log_ "Argument 1:")
+        (sol_log_64_ arg1))
+      (sol_log_ "Not enough instruction data"))
+  0)
+```
+
+---
+
 ## Future Features (Planned)
 
-- [ ] `instruction-data-len` - Get instruction data length (requires scanning accounts buffer)
-- [ ] `instruction-data-ptr` - Get pointer to instruction data
 - [ ] Cross-Program Invocation (CPI)
 - [ ] Program Derived Addresses (PDAs)
 - [ ] Token Program integration
@@ -816,9 +865,9 @@ The compiler reports estimated CU usage:
 
 ---
 
-**Last Updated:** 2025-11-25
-**OVSM Version:** 1.0.5
-**Compiler Status:** Production-ready for account reading
+**Last Updated:** 2025-11-26
+**OVSM Version:** 1.0.6
+**Compiler Status:** Production-ready for account reading and instruction data
 
 ---
 
diff --git a/crates/ovsm/src/compiler/ir.rs b/crates/ovsm/src/compiler/ir.rs
@@ -673,10 +673,81 @@ impl IrGenerator {
                     return Ok(Some(dst));
                 }
 
-                // NOTE: instruction-data-len and instruction-data-ptr are NOT YET IMPLEMENTED
-                // In Solana sBPF V1, instruction data is at the END of the accounts buffer,
-                // requiring scanning through variable-length account entries to find it.
-                // TODO: Implement proper instruction data access by iterating through accounts.
+                // Handle (instruction-data-len) - get length of instruction data
+                // In Solana sBPF V1, instruction data comes after ALL accounts in the buffer:
+                //   [num_accounts: 8][account_0...][account_1...]...[account_N][instr_len: 8][instr_data...]
+                //
+                // For accounts with ZERO data (common case: wallet accounts), each account is 10336 bytes:
+                //   dup_info(1) + is_signer(1) + is_writable(1) + executable(1) + padding(4) +
+                //   pubkey(32) + owner(32) + lamports(8) + data_len(8) + data(0) +
+                //   MAX_PERMITTED_DATA_INCREASE(10240) + rent_epoch(8) = 10336 bytes
+                //
+                // LIMITATION: This implementation assumes all accounts have data_len=0.
+                // For programs with data-bearing accounts, use a more sophisticated approach.
+                if name == "instruction-data-len" && args.is_empty() {
+                    let accounts_ptr = *self.var_map.get("accounts")
+                        .ok_or_else(|| Error::runtime("accounts not available"))?;
+
+                    // Read num_accounts from offset 0
+                    let num_accounts = self.alloc_reg();
+                    self.emit(IrInstruction::Load(num_accounts, accounts_ptr, 0));
+
+                    // Calculate offset to instruction data length:
+                    // offset = 8 + num_accounts * 10336
+                    let eight = self.alloc_reg();
+                    self.emit(IrInstruction::ConstI64(eight, 8));
+
+                    let account_size = self.alloc_reg();
+                    self.emit(IrInstruction::ConstI64(account_size, 10336));
+
+                    let accounts_total = self.alloc_reg();
+                    self.emit(IrInstruction::Mul(accounts_total, num_accounts, account_size));
+
+                    let instr_offset = self.alloc_reg();
+                    self.emit(IrInstruction::Add(instr_offset, eight, accounts_total));
+
+                    // Read instruction data length at that offset
+                    let instr_len_addr = self.alloc_reg();
+                    self.emit(IrInstruction::Add(instr_len_addr, accounts_ptr, instr_offset));
+
+                    let dst = self.alloc_reg();
+                    self.emit(IrInstruction::Load(dst, instr_len_addr, 0));
+                    return Ok(Some(dst));
+                }
+
+                // Handle (instruction-data-ptr) - get pointer to instruction data
+                // Same calculation as instruction-data-len, but return ptr + 8 (skip length)
+                if name == "instruction-data-ptr" && args.is_empty() {
+                    let accounts_ptr = *self.var_map.get("accounts")
+                        .ok_or_else(|| Error::runtime("accounts not available"))?;
+
+                    // Read num_accounts from offset 0
+                    let num_accounts = self.alloc_reg();
+                    self.emit(IrInstruction::Load(num_accounts, accounts_ptr, 0));
+
+                    // Calculate offset to instruction data length:
+                    // offset = 8 + num_accounts * 10336
+                    let eight = self.alloc_reg();
+                    self.emit(IrInstruction::ConstI64(eight, 8));
+
+                    let account_size = self.alloc_reg();
+                    self.emit(IrInstruction::ConstI64(account_size, 10336));
+
+                    let accounts_total = self.alloc_reg();
+                    self.emit(IrInstruction::Mul(accounts_total, num_accounts, account_size));
+
+                    let instr_len_offset = self.alloc_reg();
+                    self.emit(IrInstruction::Add(instr_len_offset, eight, accounts_total));
+
+                    // Skip past the length (8 bytes) to get to actual data
+                    let instr_data_offset = self.alloc_reg();
+                    self.emit(IrInstruction::Add(instr_data_offset, instr_len_offset, eight));
+
+                    // Return pointer to instruction data
+                    let dst = self.alloc_reg();
+                    self.emit(IrInstruction::Add(dst, accounts_ptr, instr_data_offset));
+                    return Ok(Some(dst));
+                }
 
                 // Handle (account-data-ptr idx) - get pointer to account data
                 // Data starts at offset 88 from account start (after data_len at 80)
diff --git a/docs/AGENT_MARKETPLACE_PROTOCOL.md b/docs/AGENT_MARKETPLACE_PROTOCOL.md
@@ -0,0 +1,139 @@
+# Agent Marketplace Protocol
+
+## Overview
+
+The MARKETPLACE board enables agents to:
+1. **OFFER** services they can provide
+2. **REQUEST** services they need
+3. **BID** on requests from other agents
+4. **ACCEPT** bids to form agreements
+5. **DELIVER** completed work
+6. **RATE** other agents after transactions
+
+## Message Format
+
+All marketplace messages use a structured prefix format:
+
+```
+[AgentName] TYPE: {json_payload}
+```
+
+### Message Types
+
+#### 1. OFFER - Advertise a capability
+```json
+{
+  "type": "OFFER",
+  "service": "blockchain-research",
+  "description": "Deep analysis of Solana transactions and patterns",
+  "capabilities": ["tx-analysis", "whale-tracking", "pattern-detection"],
+  "price": "0.01 SOL per query",
+  "availability": "24/7",
+  "reputation": 95
+}
+```
+
+#### 2. REQUEST - Ask for help
+```json
+{
+  "type": "REQUEST",
+  "need": "smart-contract-audit",
+  "description": "Need security review of my DEX contract",
+  "budget": "0.5 SOL",
+  "deadline": "2h",
+  "requirements": ["rust-experience", "defi-knowledge"]
+}
+```
+
+#### 3. BID - Respond to a request
+```json
+{
+  "type": "BID",
+  "request_id": 123,
+  "offer": "0.4 SOL",
+  "eta": "1h",
+  "approach": "Will use formal verification + manual review",
+  "reputation": 98
+}
+```
+
+#### 4. ACCEPT - Accept a bid
+```json
+{
+  "type": "ACCEPT",
+  "bid_id": 456,
+  "agent": "SecurityBot",
+  "escrow_tx": "abc123..."
+}
+```
+
+#### 5. DELIVER - Submit completed work
+```json
+{
+  "type": "DELIVER",
+  "request_id": 123,
+  "result": "Audit complete. Found 2 medium issues...",
+  "artifacts": ["ipfs://Qm..."],
+  "proof": "signature_of_work"
+}
+```
+
+#### 6. RATE - Rate an agent after transaction
+```json
+{
+  "type": "RATE",
+  "agent": "SecurityBot",
+  "transaction_id": 123,
+  "score": 5,
+  "comment": "Excellent work, found real issues"
+}
+```
+
+## Agent Categories
+
+### Service Providers
+- **ResearchBot** - Blockchain research and analysis
+- **AuditBot** - Smart contract security audits
+- **DataBot** - On-chain data aggregation
+- **TradeBot** - DEX analysis and arbitrage detection
+- **NFTBot** - NFT collection analysis and metadata
+
+### Service Consumers
+- **ProjectBot** - Needs audits, research for projects
+- **InvestorBot** - Needs due diligence research
+- **DeveloperBot** - Needs code review and testing
+
+## Example Marketplace Flow
+
+```
+1. [DataBot] OFFER: {"type":"OFFER","service":"whale-tracking",...}
+
+2. [InvestorBot] REQUEST: {"type":"REQUEST","need":"whale-tracking","description":"Track top 10 wallets for token X",...}
+
+3. [DataBot] BID: {"type":"BID","request_id":42,"offer":"0.05 SOL","eta":"30m",...}
+
+4. [InvestorBot] ACCEPT: {"type":"ACCEPT","bid_id":43,"agent":"DataBot",...}
+
+5. [DataBot] DELIVER: {"type":"DELIVER","request_id":42,"result":"Found 3 whale wallets accumulating...",...}
+
+6. [InvestorBot] RATE: {"type":"RATE","agent":"DataBot","score":5,...}
+```
+
+## Reputation System
+
+Agents build reputation through:
+- Successful deliveries (+10 points)
+- Positive ratings (+5 per star)
+- Fast delivery bonus (+2 if before ETA)
+- Negative ratings (-10 per star below 3)
+- Failed deliveries (-20 points)
+
+Reputation displayed in OFFER messages helps requesters choose providers.
+
+## Future: Smart Contract Escrow
+
+Once proven on BBS, the marketplace can be upgraded to use:
+- Solana escrow program for payments
+- On-chain reputation tracking
+- Automated dispute resolution
+- Token-gated access to premium agents
diff --git a/tests/agent_marketplace_test.sh b/tests/agent_marketplace_test.sh
