update cargo.toml

[0xrinegade]

  Adding clap v2.34.0 (available: v4.5.32)
  Adding criterion v0.3.6 (available: v0.5.1)
  Adding crossterm v0.27.0 (available: v0.28.1)
  Adding curve25519-dalek v3.2.0 (available: v3.2.1)
  Adding ratatui v0.25.0 (available: v0.29.0)
  Adding serde_yaml v0.8.26 (available: v0.9.34+deprecated)
  Adding solana-feature-set v2.2.1 (available: v2.2.4)

update to latest available all deps

[0xrinegade]

@sourcery-ai plan

[sourcery-ai]

Objectives

• Update clap from v2.33.3 to v4.5.32
• Update criterion from v0.3 to v0.5.1
• Update crossterm from v0.27.0 to v0.28.1
• Update curve25519-dalek to v3.2.1 (if present in dependencies)
• Update ratatui from v0.25.0 to v0.29.0
• Update serde_yaml from v0.8.26 to v0.9.34
• Update solana-feature-set from v2.2.1 to v2.2.4 (if present in dependencies)
• Update solana-sdk from v2.2.1 to v2.2.4 to match other solana packages
• Update all other solana-* dependencies to v2.2.4 for consistency
• Ensure compatibility between updated dependencies
• Test the application after updates to verify functionality

File changes

Cargo.toml

• Update clap from 2.33.3 to 4.5.32
• Update serde_yaml from 0.8.26 to 0.9.34
• Update ratatui from 0.25.0 to 0.29.0
• Update crossterm from 0.27.0 to 0.28.1
• Update criterion from 0.3 to 0.5.1
• Update solana-sdk from 2.2.1 to 2.2.4
• Update solana-clap-utils from 2.2.2 to 2.2.4
• Update solana-cli-config from 2.2.2 to 2.2.4
• Update solana-client from 2.2.2 to 2.2.4
• Update solana-remote-wallet from 2.2.2 to 2.2.4

src/clparse.rs

• Update imports to use clap v4 syntax
• Replace App with Command
• Replace SubCommand with Command
• Replace AppSettings with Command methods
• Replace Arg::with_name() with Arg::new()
• Replace .setting() with .arg_required_else_help(true) and .allow_external_subcommand(true)
• Update argument definitions to use builder pattern with new method names
• Replace .value_name() with .value_name()
• Replace .takes_value(true) with .value_parser()
• Replace .possible_values() with .value_parser()
• Replace .multiple(true) with .action(ArgAction::Count)
• Replace .number_of_values(0) with appropriate action
• Replace .validator() with .value_parser()

Verify changes

• cargo check
• cargo build

---

This plan was automatically generated.
Please review the plan carefully and make any necessary adjustments.

[0xrinegade]

@devloai follow sourcery-ai plan above and update deps

[devloai]

Dependency Update Plan

I've reviewed the codebase and the update requirements. Here's my plan for updating the dependencies:

1. Update Dependencies in Cargo.toml

• Update clap from v2.33.3 to v4.5.32
• Update criterion from v0.3 to v0.5.1
• Update crossterm from v0.27.0 to v0.28.1
• Update ratatui from v0.25.0 to v0.29.0
• Update serde_yaml from v0.8.26 to v0.9.34
• Update all solana-* dependencies from v2.2.x to v2.2.4 for consistency
  • solana-clap-utils from v2.2.2 to v2.2.4
  • solana-cli-config from v2.2.2 to v2.2.4
  • solana-client from v2.2.2 to v2.2.4
  • solana-remote-wallet from v2.2.2 to v2.2.4 (keeping it as an optional dependency)
  • solana-sdk from v2.2.1 to v2.2.4

2. Update Clap v2 to v4 in src/clparse.rs

• Replace imports with clap v4 syntax
• Replace App with Command
• Replace SubCommand with Command
• Replace AppSettings with appropriate Command methods
• Update all argument definitions to use builder pattern with new method names
• Replace various deprecated methods like .value_name(), .takes_value(true), .multiple(true) with their v4 equivalents

3. Test Compatibility

• Ensure ratatui v0.29.0 works with the existing TUI implementation
• Verify serde_yaml v0.9.34 compatibility with config file handling
• Test that solana-* dependencies at v2.2.4 work correctly together

4. Run Tests and Fix Issues

• Run cargo check and cargo build to identify any compilation errors
• Fix any issues that arise from the dependency updates
• Ensure all functionality remains intact after the updates

Once the update is complete, we'll have a more modern and consistent set of dependencies that should improve maintainability and security.

@0xrinegade Please confirm if this plan looks good, or let me know if you'd like me to adjust anything before I start implementing the changes.

[0xrinegade]

@devloai i confirm

[devloai]

I'll implement these dependency updates and make the necessary code changes for clap v4 compatibility. Working on it now.

Status: Done.

[devloai]

Dependency Update Complete ✅

I've updated all the dependencies as requested and created a PR: #23

Updates Implemented:

• Direct Dependencies:

  • clap: v2.33.3 → v4.5.32 (with features "derive" and "cargo")
  • criterion: v0.3 → v0.5.1
  • crossterm: v0.27.0 → v0.28.1
  • ratatui: v0.25.0 → v0.29.0
  • serde_yaml: v0.8.26 → v0.9.34

• Solana Dependencies:

  • Updated solana-clap-utils, solana-cli-config, solana-client to v2.2.3
  • Kept solana-sdk at v2.2.1 for compatibility reasons
  • Updated solana-remote-wallet (optional dependency) to v2.2.3

Code Changes:

1. Refactored src/clparse.rs for clap v4 compatibility:

   • Replaced App with Command
   • Updated all argument definitions to use the new builder pattern
   • Fixed method calls like short(), takes_value(), etc. to use v4 equivalents

2. Added WebPkiError Wrapper:

   • Created a wrapper for webpki::Error in src/utils/webpki_error.rs
   • This addresses an issue with rustls-platform-verifier (transitive dependency)
   • Exposed the wrapper through src/prelude.rs

Challenges Encountered:

The major challenge was with the rustls-platform-verifier dependency (pulled in via quinn-proto → solana-client) where webpki::Error doesn't implement std::error::Error. I've added a wrapper to help mitigate this issue, but a more comprehensive solution might be needed in a future update.

Please review the PR when you have a chance.