Skip to content

Commit cc175a5

Browse files
Copilot0xrinegade
andcommitted
Fix UI issues: profile dropdown positioning, theme selector functionality, and blueprint shadow styling
Co-authored-by: 0xrinegade <[email protected]>
1 parent 2f25515 commit cc175a5

File tree

3 files changed

+69
-16
lines changed

3 files changed

+69
-16
lines changed

src/components/profile/ProfileSettings.js

Lines changed: 34 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -238,38 +238,59 @@ const ProfileSettings = ({ settings, onSaveSettings }) => {
238238
<style jsx>{`
239239
.profile-theme-selector {
240240
width: 100%;
241-
background: var(--color-background);
242-
border: 1px solid var(--color-border);
243-
border-radius: 0;
241+
background: var(--card-bg, var(--color-background));
242+
border: 1px solid var(--border-color, var(--color-border));
243+
border-radius: var(--border-radius, 0);
244+
position: relative;
244245
}
245246
246-
.profile-theme-selector .app-header-control {
247+
.profile-theme-selector .app-header-control,
248+
.profile-theme-selector .app-dropdown-trigger {
247249
width: 100%;
248-
background: var(--color-background);
249-
border: 1px solid var(--color-border);
250-
color: var(--color-foreground);
250+
background: var(--card-bg, var(--color-background));
251+
border: 1px solid var(--border-color, var(--color-border));
252+
color: var(--text-primary, var(--color-foreground));
251253
padding: 8px 12px;
252-
border-radius: 0;
253-
font-family: inherit;
254+
border-radius: var(--border-radius, 0);
255+
font-family: var(--font-family, inherit);
254256
font-size: 14px;
255257
text-align: left;
258+
cursor: pointer;
259+
display: flex;
260+
align-items: center;
261+
justify-content: space-between;
256262
}
257263
258-
.profile-theme-selector .app-dropdown-menu {
264+
.profile-theme-selector .app-header-control:hover,
265+
.profile-theme-selector .app-dropdown-trigger:hover {
266+
background: var(--secondary-bg, var(--color-background-alt));
267+
border-color: var(--accent-color, var(--color-primary));
268+
}
269+
270+
.profile-theme-selector .app-dropdown-menu,
271+
.profile-theme-selector .theme-selector-menu {
259272
width: 100%;
260273
max-width: none;
261274
left: 0 !important;
262275
right: 0;
276+
position: absolute;
277+
top: 100%;
278+
background: var(--card-bg, var(--color-background));
279+
border: 1px solid var(--border-color, var(--color-border));
280+
box-shadow: var(--shadow, 0 4px 6px rgba(0, 0, 0, 0.1));
281+
z-index: 1000;
282+
max-height: 200px;
283+
overflow-y: auto;
263284
}
264285
265286
.app-form-info {
266-
background: var(--secondary-bg);
267-
border: 1px solid var(--border-color);
287+
background: var(--secondary-bg, var(--color-background-alt));
288+
border: 1px solid var(--border-color, var(--color-border));
268289
border-radius: var(--border-radius, 0px);
269290
padding: 12px;
270291
margin-top: 16px;
271292
font-size: var(--font-size-sm, 12px);
272-
color: var(--text-muted);
293+
color: var(--text-muted, var(--color-foreground-muted));
273294
}
274295
275296
.app-form-info p {

src/styles/ascii-theme.css

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3319,6 +3319,14 @@ button:focus-visible {
33193319
font-family: 'Courier New', Courier, monospace !important;
33203320
}
33213321

3322+
/* Blueprint theme specific dropdown positioning */
3323+
.theme-blueprint .ascii-dropdown-menu {
3324+
/* Ensure dropdown always expands downward from navbar */
3325+
top: 100%;
3326+
bottom: auto;
3327+
transform: none;
3328+
}
3329+
33223330
/* Dropdown items */
33233331
.ascii-dropdown-item {
33243332
display: block;

src/styles/themes/blueprint.css

Lines changed: 27 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,10 @@
8888
--border-style: solid;
8989
--border-style-dashed: dashed;
9090
--border-style-dotted: dotted;
91-
--shadow: 3px 3px 0px var(--border-color);
92-
--shadow-hover: 5px 5px 0px var(--border-color);
91+
--shadow: 0 0 8px rgba(30, 64, 175, 0.4), 3px 3px 0px var(--border-color);
92+
--shadow-hover: 0 0 12px rgba(30, 64, 175, 0.6), 5px 5px 0px var(--border-color);
9393
--shadow-inset: inset 0 1px 3px rgba(30, 64, 175, 0.1);
94-
--shadow-technical: 0 0 0 1px var(--border-color), 2px 2px 0 var(--border-light);
94+
--shadow-technical: 0 0 6px rgba(30, 64, 175, 0.3), 0 0 0 1px var(--border-color), 2px 2px 0 var(--border-light);
9595

9696
/* Blueprint Animation */
9797
--transition-fast: 0.15s ease;
@@ -516,6 +516,18 @@
516516
position: relative;
517517
padding: var(--spacing-4);
518518
z-index: 100;
519+
/* Ensure dropdown always expands downward from navbar */
520+
top: 100%;
521+
bottom: auto;
522+
transform: none;
523+
}
524+
525+
/* Theme selector dropdown in blueprint theme */
526+
.theme-blueprint .app-dropdown-menu {
527+
background: var(--card-bg);
528+
border: var(--border-width-thick) solid var(--border-color);
529+
box-shadow: var(--shadow-hover);
530+
z-index: 100;
519531
}
520532

521533
.theme-blueprint .ascii-dropdown-menu::before {
@@ -758,6 +770,7 @@
758770
min-width: 320px;
759771
max-height: 480px;
760772
overflow-y: auto;
773+
box-shadow: var(--shadow-technical);
761774
}
762775

763776
.theme-blueprint .theme-option-content {
@@ -783,6 +796,17 @@
783796
font-style: italic;
784797
}
785798

799+
/* Profile settings theme selector specific styling */
800+
.theme-blueprint .profile-theme-selector .app-dropdown-trigger {
801+
box-shadow: var(--shadow-technical);
802+
border: var(--border-width-thick) solid var(--border-color);
803+
}
804+
805+
.theme-blueprint .profile-theme-selector .app-dropdown-menu {
806+
box-shadow: var(--shadow-hover);
807+
border: var(--border-width-thick) solid var(--border-color);
808+
}
809+
786810
/* Enhanced network indicator */
787811
.theme-blueprint .network-indicator {
788812
width: 12px;

0 commit comments

Comments
 (0)