ROUND 1: Fix critical wallet error and memory leak - enable OS polyfills and fix WalletInjectionService cleanup

Co-authored-by: 0xrinegade <[email protected]>

Author: Copilot

src/polyfills/ultimate-fix.js

@@ -110,6 +110,18 @@ function initializeOsPolyfill() {
         configurable: false,
       });
     }
+
+    // Patch any existing require cache to return our polyfill
+    if (globalScope.require && globalScope.require.cache) {
+      globalScope.require.cache.os = { exports: osPolyfill };
+    }
+
+    // Additional safety: intercept any direct os.homedir calls
+    if (typeof globalScope.c !== 'undefined' && globalScope.c && typeof globalScope.c === 'object') {
+      if (!globalScope.c.homedir || typeof globalScope.c.homedir !== 'function') {
+        globalScope.c.homedir = osPolyfill.homedir;
+      }
+    }
   }
 }
 
@@ -135,10 +147,30 @@ function setupSecureErrorHandling() {
           ) ||
           message.includes(
             "Cannot read properties of undefined (reading 'buffer')",
-          ))
+          ) ||
+          message.includes('resolve is not a function') ||
+          message.includes('os.homedir is not a function'))
       ) {
         logError('OS/Buffer access error intercepted:', message);
 
+        // Emergency polyfill injection
+        try {
+          if (typeof window !== 'undefined') {
+            // Ensure os polyfill is available
+            if (!window.os || !window.os.homedir) {
+              window.os = osPolyfill;
+            }
+            // Fix any undefined 'c' object that might be causing issues
+            if (typeof window.c === 'undefined') {
+              window.c = { homedir: osPolyfill.homedir };
+            } else if (window.c && !window.c.homedir) {
+              window.c.homedir = osPolyfill.homedir;
+            }
+          }
+        } catch (recoveryError) {
+          logError('Emergency polyfill injection failed:', recoveryError);
+        }
+
         // Show user-friendly error instead of crashing
         if (
           document.body &&
@@ -160,14 +192,16 @@ function setupSecureErrorHandling() {
             max-width: 300px;
           `;
           errorDiv.textContent =
-            'Compatibility issue detected. Attempting to recover...';
+            'System compatibility issue detected. Recovering automatically...';
           document.body.appendChild(errorDiv);
 
           setTimeout(() => {
             if (errorDiv.parentNode) {
               errorDiv.parentNode.removeChild(errorDiv);
             }
-          }, 3000);
+            // Attempt to reload the problematic component
+            window.location.reload();
+          }, 2000);
         }
 
         return true; // Prevent default error handling

src/services/WalletInjectionService.ts

@@ -30,6 +30,7 @@ export class WalletInjectionService {
   private wallet: any = null;
   private injected = new Set<string>();
   private messageHandlers = new Map<string, (data: any) => void>();
+  private messageListener: ((event: MessageEvent) => void) | null = null;
 
   // Rate limiting for request throttling
   private requestCounts = new Map<string, number>();
@@ -173,7 +174,7 @@ export class WalletInjectionService {
    * Handle messages from the iframe with rate limiting and enhanced security
    */
   private setupMessageListener(): void {
-    window.addEventListener('message', (event) => {
+    this.messageListener = (event) => {
       try {
         if (!this.iframe || event.source !== this.iframe.contentWindow) {
           return;
@@ -200,7 +201,9 @@ export class WalletInjectionService {
       } catch (error) {
         logError('WalletInjectionService: Error processing message:', error, event.data);
       }
-    });
+    };
+
+    window.addEventListener('message', this.messageListener);
   }
 
   /**
@@ -467,6 +470,29 @@ export class WalletInjectionService {
     this.requestCounts.clear();
   }
 
+  /**
+   * Clean up event listeners and resources to prevent memory leaks
+   */
+  public destroy(): void {
+    // Clean up message listener
+    if (this.messageListener) {
+      window.removeEventListener('message', this.messageListener);
+      this.messageListener = null;
+    }
+
+    // Clean up rate limiting interval
+    if (this.rateLimitCleanupInterval) {
+      clearInterval(this.rateLimitCleanupInterval);
+      this.rateLimitCleanupInterval = null;
+    }
+
+    // Clean up other resources
+    this.iframe = null;
+    this.injected.clear();
+    this.messageHandlers.clear();
+    this.requestCounts.clear();
+  }
+
   /**
    * Check if providers are injected for a specific iframe
    */

src/utils/featureFlags.ts

@@ -38,11 +38,11 @@ export interface FeatureFlags {
  * unless explicitly needed for wallet extension compatibility.
  */
 const DEFAULT_FLAGS: FeatureFlags = {
-  // Global patches - disabled by default for safety
-  enableOsPolyfill: process.env.REACT_APP_ENABLE_OS_POLYFILL === 'true',
-  enableBufferPolyfill: process.env.REACT_APP_ENABLE_BUFFER_POLYFILL === 'true',
-  enableSafeEventListeners: process.env.REACT_APP_ENABLE_SAFE_EVENT_LISTENERS === 'true',
-  enableCryptoPolyfill: process.env.REACT_APP_ENABLE_CRYPTO_POLYFILL === 'true',
+  // Global patches - enabled by default for wallet compatibility
+  enableOsPolyfill: process.env.REACT_APP_ENABLE_OS_POLYFILL !== 'false',
+  enableBufferPolyfill: process.env.REACT_APP_ENABLE_BUFFER_POLYFILL !== 'false',
+  enableSafeEventListeners: process.env.REACT_APP_ENABLE_SAFE_EVENT_LISTENERS !== 'false',
+  enableCryptoPolyfill: process.env.REACT_APP_ENABLE_CRYPTO_POLYFILL !== 'false',
 
   // Security features - enabled by default
   enableAdvancedRateLimiting: process.env.REACT_APP_DISABLE_RATE_LIMITING !== 'true',