Running ansible on Right to Know removes rbenv

[benrfairless]

Describe the bug
rbenv is a requirement for Right to Know, however running make check-righttoknow STAGE=staging tries to nuke rbenv.

To Reproduce
Steps to reproduce the behavior:
A. Run

   make check-righttoknow STAGE=staging

B. Wait for the tasks to get to the rbenv removal stage

Expected behavior
Right to Know uses rbenv and therefore it should not be uninstalled when running ansible

Screenshots/Output
N/A

Additional context
This appears to have been introduced in 54cdf2d

Related:

• Fix righttoknow ansible playbook #477

[benrfairless]

Ruby configuration for Right to Know is done here:

infrastructure/roles/internal/righttoknow/meta/main.yml

Lines 124 to 133 in 8a4989a

	- role: zzet.rbenv
	rbenv:
	env: user
	version: v1.1.2
	default_ruby: "{{ ruby_version_staging if 'righttoknow_staging' in group_names else ruby_version_production }}"
	rubies:
	- version: "{{ ruby_version_staging }}"
	- version: "{{ ruby_version_production }}"
	rbenv_users:
	- deploy

When I check openaustralia I can't find a similar entry.

[benrfairless]

@ianheggie-oaf it appears that we are getting into a bit of a mess here. I note that we currently run a removal job every time we run the main playbook:

infrastructure/site.yml

Lines 171 to 199 in 8a4989a

	- hosts: all
	name: "Remove unused ruby managers"
	become: true
	tags:
	- cleanup
	- ruby
	tasks:
	- name: Remove rbenv
	tags:
	- rbenv
	import_role:
	name: internal/remove_rbenv
	vars:
	rbenv_users:
	- deploy
	when: "ruby_manager != 'rbenv'"
	- name: Remove rvm
	import_role:
	name: internal/remove_rvm
	tags:
	- rvm
	when: "ruby_manager != 'rvm'"
	- name: Remove mise
	import_role:
	name: internal/remove_mise
	tags:
	- mise
	when: "ruby_manager != 'mise'"

We need to revisit this with a goal to reduce deployment time while reducing the need to remember where we need to configure things in various roles, especially if it's going to uninstall somethhing.