read button only once

amandel · amandel · commit 45fde04a6937 · 2025-02-28T15:21:27.000+01:00
diff --git a/src/OpenBikeSensorFirmware.cpp b/src/OpenBikeSensorFirmware.cpp
@@ -240,12 +240,14 @@ static void powerKeepAliveTimerISR()
   if(shutdownState == 0)
   {
     unsigned long timeSinceLastPowerKeepAlive = millis() - timeOfLastPowerKeepAlive;
-    if(!digitalRead(IP5306_BUTTON) && timeSinceLastPowerKeepAlive > POWER_KEEP_ALIVE_INTERVAL_MS)
+    bool ip5306ButtonState = digitalRead(IP5306_BUTTON);
+
+    if(!ip5306ButtonState && timeSinceLastPowerKeepAlive > POWER_KEEP_ALIVE_INTERVAL_MS)
     {
       timeOfLastPowerKeepAlive = millis();
       digitalWrite(IP5306_BUTTON, HIGH);
     }
-    else if(digitalRead(IP5306_BUTTON) && timeSinceLastPowerKeepAlive > 300)
+    else if(ip5306ButtonState && timeSinceLastPowerKeepAlive > 300)
     {
       timeOfLastPowerKeepAlive = millis();
       digitalWrite(IP5306_BUTTON, LOW);

Original file line number	Diff line number	Diff line change
`@@ -240,12 +240,14 @@ static void powerKeepAliveTimerISR()`
`240`	`240`	`if(shutdownState == 0)`
`241`	`241`	`{`
`242`	`242`	`unsigned long timeSinceLastPowerKeepAlive = millis() - timeOfLastPowerKeepAlive;`
`243`		`- if(!digitalRead(IP5306_BUTTON) && timeSinceLastPowerKeepAlive > POWER_KEEP_ALIVE_INTERVAL_MS)`
	`243`	`+ bool ip5306ButtonState = digitalRead(IP5306_BUTTON);`
	`244`	`+`
	`245`	`+ if(!ip5306ButtonState && timeSinceLastPowerKeepAlive > POWER_KEEP_ALIVE_INTERVAL_MS)`
`244`	`246`	`{`
`245`	`247`	`timeOfLastPowerKeepAlive = millis();`
`246`	`248`	`digitalWrite(IP5306_BUTTON, HIGH);`
`247`	`249`	`}`
`248`		`- else if(digitalRead(IP5306_BUTTON) && timeSinceLastPowerKeepAlive > 300)`
	`250`	`+ else if(ip5306ButtonState && timeSinceLastPowerKeepAlive > 300)`
`249`	`251`	`{`
`250`	`252`	`timeOfLastPowerKeepAlive = millis();`
`251`	`253`	`digitalWrite(IP5306_BUTTON, LOW);`