Skip to content

Commit b0ca437

Browse files
authored
Remove cutoff package dependency (removed from CRAN) (#302)
* Initial plan * fix: remove cutoff package dependency (removed from CRAN) The `cutoff` package was removed from CRAN, causing the CI build to fail when resolving dependencies. The package was loaded but never actually used in the tutorial code (the cutoff calculation uses base R's median()). Closes #301 * fix: use GitHub version of cutoff package (choisy/cutoff) since it was removed from CRAN Instead of removing the cutoff dependency entirely, switch to installing from GitHub to keep the tutorial unchanged. Closes #301 * fix: add GitHub remotes for fastStat transitive deps (set, do, tmcn) These packages were also removed from CRAN, causing pak to fail when resolving the dependency chain: fastStat → set → do → tmcn. * fix: add set, do, tmcn as direct Imports so pak resolves them from Remotes pak only resolves Remotes for packages listed as direct dependencies. Adding these as Imports ensures pak looks for them in our Remotes field instead of failing to find them on CRAN. * Remove fastStat and its broken deps (set, do, tmcn) — unused and incompatible with current data.table --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
1 parent 0cc33b7 commit b0ca437

3 files changed

Lines changed: 6 additions & 15 deletions

File tree

DESCRIPTION

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,6 @@ Imports:
168168
EnhancedVolcano,
169169
ggradar,
170170
streamgraph,
171-
fastStat,
172171
apyramid,
173172
flow,
174173
survminer,
@@ -262,7 +261,6 @@ Remotes:
262261
kevinblighe/EnhancedVolcano,
263262
ricardo-bion/ggradar,
264263
hrbrmstr/streamgraph,
265-
yikeshu0611/fastStat,
266264
wch/extrafont,
267265
hrbrmstr/hrbrthemes,
268266
hrbrmstr/waffle,
@@ -280,4 +278,5 @@ Remotes:
280278
jinworks/CellChat,
281279
cran/smoother,
282280
cran/regplot,
283-
YuLab-SMU/fanyi
281+
YuLab-SMU/fanyi,
282+
choisy/cutoff

Hiplot/155-risk-plot.qmd

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ This page is the tutorial for source code version of the Hiplot `Risk Factor Ana
1919

2020
- Programming language: R
2121

22-
- Dependent packages: `data.table`; `jsonlite`; `survminer`; `fastStat`; `cutoff`; `ggplot2`; `cowplot`
22+
- Dependent packages: `data.table`; `jsonlite`; `survminer`; `cutoff`; `ggplot2`; `cowplot`
2323

2424
```{r packages setup, message=FALSE, warning=FALSE, output=FALSE}
2525
# Install packages
@@ -32,11 +32,8 @@ if (!requireNamespace("jsonlite", quietly = TRUE)) {
3232
if (!requireNamespace("survminer", quietly = TRUE)) {
3333
install.packages("survminer")
3434
}
35-
if (!requireNamespace("fastStat", quietly = TRUE)) {
36-
remotes::install_github("yikeshu0611/fastStat")
37-
}
3835
if (!requireNamespace("cutoff", quietly = TRUE)) {
39-
install.packages("cutoff")
36+
remotes::install_github("choisy/cutoff")
4037
}
4138
if (!requireNamespace("ggplot2", quietly = TRUE)) {
4239
install.packages("ggplot2")
@@ -49,7 +46,6 @@ if (!requireNamespace("cowplot", quietly = TRUE)) {
4946
library(data.table)
5047
library(jsonlite)
5148
library(survminer)
52-
library(fastStat)
5349
library(cutoff)
5450
library(ggplot2)
5551
library(cowplot)

Hiplot/155-risk-plot.zh.qmd

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ author:
1919

2020
- 编程语言: R
2121

22-
- 依赖包: `data.table`; `jsonlite`; `survminer`; `fastStat`; `cutoff`; `ggplot2`; `cowplot`
22+
- 依赖包: `data.table`; `jsonlite`; `survminer`; `cutoff`; `ggplot2`; `cowplot`
2323

2424
```{r packages setup, message=FALSE, warning=FALSE, output=FALSE}
2525
# 安装包
@@ -32,11 +32,8 @@ if (!requireNamespace("jsonlite", quietly = TRUE)) {
3232
if (!requireNamespace("survminer", quietly = TRUE)) {
3333
install.packages("survminer")
3434
}
35-
if (!requireNamespace("fastStat", quietly = TRUE)) {
36-
remotes::install_github("yikeshu0611/fastStat")
37-
}
3835
if (!requireNamespace("cutoff", quietly = TRUE)) {
39-
install.packages("cutoff")
36+
remotes::install_github("choisy/cutoff")
4037
}
4138
if (!requireNamespace("ggplot2", quietly = TRUE)) {
4239
install.packages("ggplot2")
@@ -49,7 +46,6 @@ if (!requireNamespace("cowplot", quietly = TRUE)) {
4946
library(data.table)
5047
library(jsonlite)
5148
library(survminer)
52-
library(fastStat)
5349
library(cutoff)
5450
library(ggplot2)
5551
library(cowplot)

0 commit comments

Comments
 (0)