System Event Log (SEL) Improperly Tied to Dynamic Sensors Switch

[iwoloschin]

I'm trying to enable the System Event Log (SEL) on one of my platforms, all of which use the Dynamic Sensors functionality with inventory defined in Entity Manager and telemetry managed by dbus-sensors. The sensors & FRUs all work as expected, but when I tried enabling the SEL (via phosphor-sel-logger with appropriate recipe modifications) it works great in Redfish, but shows nothing in IPMI.

Digging into the code it is clear that the SEL methods are completely override with the "rsyslog approach" when enabling Dynamic Sensors:
https://github.com/openbmc/phosphor-host-ipmid/blob/master/dbus-sdr/storagecommands.cpp#L1298-L1326
https://github.com/openbmc/phosphor-host-ipmid/blob/master/storagehandler.cpp#L887-L928

I'm not clear on the reasons for a divergence in logging, but given that the SEL is a separate function from Inventory I believe that tying SEL to Dynamic Sensors is a bug. At a minimum I think that a new switch needs to added, with the default being the dbus SEL, as it seems that is the preferred method for the project moving forward.

I naively tried disabling the Dynamic Sensors SEL Handlers and re-enabling the original SEL Handlers, I can get an accurate number of SEL Entries, but some sort of dbus association is failing so the SEL Event Number & Message do not appear correctly. I have not had time to fully grasp how dbus works here, so potentially we'll still need some slightly different handling for the dbus-based SEL if we are using Dynamic Sensors.