Skip to content

simulator should be set in 1 place (better not in the validator) #468

@cattabiani

Description

@cattabiani

the simulator is set in at least 2 places:

if cls.cli_options.simulator:

def _set_simulator(config: _SimConfig):

it is very confusing. It is also a break of paradigm: a validator should not set stuff. Also, it is strange that we set it in the class, not in an instance.

In addition it is very restrictive that the CLIOptions object has the enums that are mandatory. Why can't we have optional enums? If not there, we use None, otherwise the enum

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions