Skip to content

Commit ef618cc

Browse files
committed
Display only directly assigned roles in user modal
Not only assigned but also derived roles were display in the "Roles" tab of the user modal.
1 parent d5e1b99 commit ef618cc

File tree

4 files changed

+19
-8
lines changed

4 files changed

+19
-8
lines changed

src/components/shared/wizard/SelectContainer.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,8 @@ const SelectContainer = ({
252252
onChange={(e) => handleChangeRemove(e)}
253253
value={markedForRemoval}
254254
>
255-
{/* @ts-expect-error TS(7006): Parameter 'item' implicitly has an 'any' type. */}
255+
{/* Show assigned users or directly assigned roles*/}
256+
{/* @ts-expect-error TS(7006): Parameter 'item' implicitly has an 'any' type. */}
256257
{selectedItems.map((item, key) => (
257258
<option key={key} value={item.name}>
258259
{item.name}

src/components/users/partials/modal/UserDetails.tsx

+12-2
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,11 @@ const UserDetails: React.FC<{
2424
const [page, setPage] = useState(0);
2525

2626
const userDetails = useAppSelector(state => getUserDetails(state));
27+
const assignedRoles = userDetails.roles.filter(role => role.type === "GROUP" || role.type === "INTERNAL")
2728

2829
const initialValues = {
2930
...userDetails,
31+
assignedRoles,
3032
password: "",
3133
passwordConfirmation: "",
3234
};
@@ -58,8 +60,16 @@ const UserDetails: React.FC<{
5860
setPage(tabNr);
5961
};
6062

61-
const handleSubmit = (values: UpdateUser) => {
62-
dispatch(updateUserDetails({values: values, username: userDetails.username}));
63+
const handleSubmit = (values: any) => {
64+
const newValues: UpdateUser = {
65+
email: values.email,
66+
name: values.name,
67+
username: values.username,
68+
roles: values.assignedRoles,
69+
password: values.password,
70+
};
71+
72+
dispatch(updateUserDetails({values: newValues, username: userDetails.username}));
6373
close();
6474
};
6575

src/components/users/partials/wizard/UserRolesTab.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ const UserRolesTab = <T extends RequiredFormProps>({
4444
label: "USERS.USERS.DETAILS.ROLES",
4545
items: roles,
4646
}}
47-
formikField="roles"
47+
formikField="assignedRoles"
4848
manageable={formik.values.manageable}
4949
/>
5050
)}

src/slices/eventSlice.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -245,10 +245,10 @@ export const fetchEvents = createAppAsyncThunk('events/fetchEvents', async (_, {
245245

246246
// Add a secondary filter to enforce order of events
247247
// (Elasticsearch does not guarantee ordering)
248-
params = {
249-
...params,
250-
sort: params.sort ? params.sort + ",uid:asc" : "uid:asc"
251-
}
248+
//params = {
249+
// ...params,
250+
// sort: params.sort ? params.sort + ",uid:asc" : "uid:asc"
251+
//}
252252

253253
// Only if the notes column is enabled, fetch comment information for events
254254
if (state.events.columns.find(column => column.label === "EVENTS.EVENTS.TABLE.ADMINUI_NOTES" && !column.deactivated)) {

0 commit comments

Comments
 (0)