Skip to content

Add tooltip text to the close button of Modals. #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

luniki
Copy link
Contributor

@luniki luniki commented May 13, 2025

Fixes #1218.

Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1220

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1220

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@luniki luniki added the type:accessibility This would help impaired users label May 13, 2025
Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/1220/2025-05-13_11-42-21/ .
It might take a few minutes for it to become available.

Copy link
Contributor

@NadiaUoM NadiaUoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hard coding the CLOSE text directly can you please read it from lang-en_US.json file. If you do so internalization can be possible if needed....

@lkiesow
Copy link
Member

lkiesow commented May 13, 2025

Instead of hard coding the CLOSE text directly can you please read it from lang-en_US.json file. If you do so internalization can be possible if needed....

Internationalization already works. It's not actually hard-coded. That's the translation string. So, I think we can ignore that complaint.

However, looking at the placement of the tooltip, that doesn't seem right. The placement is far too low:

Screenshot from 2025-05-13 14-40-34

@lkiesow lkiesow self-assigned this May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:accessibility This would help impaired users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close button of Modals must have discernible text
3 participants