Performance Issues with filters

[ppettit]

Currently /admin-ng/resources/events/filters.json is requested twice on events/events page load. It is not cached at all as it is set to expire at unix epoch. This includes

• every series name and ID (we have ~14000 in our test system)
• every capture agent name and ID (we have around 600 in our test system) the data is also duplicated in the json under "agent" and "location".

This takes around 2.5MB of download and 10-15s (I think the slowness is probably OC not network bandwidth as I've tried gzipping this in the past and that didn't speed things up)

Clicking on the series filter and scrolling down the list is extremely slow as is typing into the box.

old admin screencast (slow to load but responsive once loaded):

filters.-.old.admin.mp4

new admin screencast (slow to load and generally unresponsive):

filters.-.new.admin.mp4

We should probably only request data once when it is actually required, or even better, use some sort of autocomplete so that the entire list is never fetched.

[ppettit]

I also notice that lots of endpoints are requested twice at almost the same time (for example pretty much any endpoint requested when browsing around the event dialog such as assets.json, ACL.json, ACL.ACTIONS.json, access.json, publications.json) mostly these don't cause performance problems as they are small though.

[Arnei]

I also notice that lots of endpoints are requested twice at almost the same time (for example pretty much any endpoint requested when browsing around the event dialog such as assets.json, ACL.json, ACL.ACTIONS.json, access.json, publications.json) mostly these don't cause performance problems as they are small though.

You are running the admin interface locally via npm start, right? That means you are running the app in "development mode", which means React Strict Mode is enabled. This is a development-only feature that, among other things, causes renders and effects to be run an additional time. It is supposed to help find bugs early, but can also cause side-effects to run twice, like for example sending the same web request twice.

[ppettit]

Yes, I guess that is the issue. Also I just noticed if i go to http://localhost:3000/ it seems to work fine but if I go to http://localhost:3000/admin-ng/index.html you get the double/quadruple loads

[Arnei]

Now that is weird, React Strict Mode should be enabled no matter the routing. Not sure what is going on there.