Skip to content

parameter names are discarded? #31

@aspiers

Description

@aspiers

Even if I run cast ups on a JSON ABI file which includes names of all the parameters for each function, these are apparently discarded by OpenChain's API on upload, or at least not used, because if I later perform a lookup, only the function is named in the response, e.g.:

$ curl -X 'GET' 'https://api.openchain.xyz/signature-database/v1/lookup?function=0x84d8b61a&filter=true' -H 'accept: application/json' | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   188  100   188    0     0    420      0 --:--:-- --:--:-- --:--:--   421
{
  "ok": true,
  "result": {
    "event": {},
    "function": {
      "0x84d8b61a": [
        {
          "name": "requestRetirement((uint256[],uint256,string,address,string,string,string,string,uint256,uint256))",
          "filtered": false
        }
      ]
    }
  }
}

I know that function parameter names are not used in the construction of the function selector hash, but that doesn't stop them being very useful during development and debugging.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions