fix: harden remote Parallels snapshot checks

Author: steipete

CHANGELOG.md

@@ -9,6 +9,7 @@
 ### Fixed
 
 - Fixed portal and documentation theme toggles so dark mode shows only the sun icon and light mode shows only the moon icon.
+- Fixed remote Parallels hosts so `prlctl` is found on standard Mac install paths, and made snapshot fork dry-runs reject non-forkable power-on snapshots consistently.
 
 ### Changed
 

internal/cli/checkpoint.go

@@ -361,7 +361,11 @@ func (a App) checkpointListParallelsSnapshots(ctx context.Context, cfg Config, i
 		return json.NewEncoder(a.Stdout).Encode(views)
 	}
 	if len(views) == 0 {
-		fmt.Fprintf(a.Stdout, "no snapshots source=%s\n", vm.ID)
+		kind := "snapshots"
+		if opts.ForkableOnly {
+			kind = "forkable snapshots"
+		}
+		fmt.Fprintf(a.Stdout, "no %s source=%s\n", kind, vm.ID)
 		return nil
 	}
 	for _, view := range views {
@@ -831,6 +835,9 @@ func (a App) checkpointForkParallelsSnapshot(ctx context.Context, fs *flag.FlagS
 		if err != nil {
 			return err
 		}
+		if err := validateParallelsSnapshotCloneMode(snapshot, cfg.Parallels.CloneMode); err != nil {
+			return err
+		}
 		fmt.Fprintf(a.Stdout, "would fork provider=parallels host=%s source=%s snapshot=%s name=%q slug=%s\n", blank(selected.Parallels.SelectedHost, "local"), cfg.Parallels.Source, snapshot.ID, snapshot.Name, blank(requestedSlug, "-"))
 		return nil
 	}

internal/cli/parallels.go

@@ -199,8 +199,10 @@ func (c *ParallelsClient) Clone(ctx context.Context, source, snapshotID, leaseID
 			if err != nil {
 				return Server{}, err
 			}
-			if ok && !strings.EqualFold(snapshot.State, "poweroff") {
-				return Server{}, exit(2, "Parallels linked clones require a power-off snapshot; snapshot %q state=%s", snapshot.Name, blank(snapshot.State, "unknown"))
+			if ok {
+				if err := validateParallelsSnapshotCloneMode(snapshot, c.Cfg.Parallels.CloneMode); err != nil {
+					return Server{}, err
+				}
 			}
 		}
 		args = append(args, "--linked")
@@ -598,7 +600,7 @@ touch /var/lib/crabbox/bootstrapped 2>/dev/null || true
 
 func (c *ParallelsClient) prlctl(ctx context.Context, extraEnv []string, args ...string) (LocalCommandResult, error) {
 	if c.Cfg.Parallels.Host != "" {
-		remote := append([]string{"prlctl"}, args...)
+		remote := "PATH=/usr/local/bin:/opt/homebrew/bin:$PATH " + strings.Join(shellWords(append([]string{"prlctl"}, args...)), " ")
 		sshArgs := []string{}
 		if c.Cfg.Parallels.HostKey != "" {
 			sshArgs = append(sshArgs, "-i", c.Cfg.Parallels.HostKey, "-o", "IdentitiesOnly=yes")
@@ -607,12 +609,26 @@ func (c *ParallelsClient) prlctl(ctx context.Context, extraEnv []string, args ..
 		if c.Cfg.Parallels.HostUser != "" {
 			host = c.Cfg.Parallels.HostUser + "@" + host
 		}
-		sshArgs = append(sshArgs, host, strings.Join(shellWords(remote), " "))
+		sshArgs = append(sshArgs, host, remote)
 		return c.Runner.Run(ctx, LocalCommandRequest{Name: "ssh", Args: sshArgs, Env: extraEnv})
 	}
 	return c.Runner.Run(ctx, LocalCommandRequest{Name: "prlctl", Args: args, Env: extraEnv})
 }
 
+func validateParallelsSnapshotCloneMode(snapshot ParallelsSnapshot, cloneMode string) error {
+	switch strings.ToLower(strings.TrimSpace(cloneMode)) {
+	case "", "linked":
+		if !strings.EqualFold(snapshot.State, "poweroff") {
+			return exit(2, "Parallels linked clones require a power-off snapshot; snapshot %q state=%s", snapshot.Name, blank(snapshot.State, "unknown"))
+		}
+		return nil
+	case "full", "unlink":
+		return exit(2, "Parallels snapshot forks require cloneMode=linked; prlctl selects snapshots only for linked clones")
+	default:
+		return exit(2, "parallels.cloneMode must be linked, full, or unlink")
+	}
+}
+
 func parseParallelsVMs(data string) ([]ParallelsVM, error) {
 	var raw []map[string]any
 	if err := json.Unmarshal([]byte(data), &raw); err != nil {

internal/cli/parallels_test.go

@@ -122,6 +122,9 @@ func TestParallelsRemoteCommandUsesSSHHostThenCommand(t *testing.T) {
 	if strings.HasPrefix(runner.lastReq.Args[1], "-- ") {
 		t.Fatalf("remote command should not start with --: %#v", runner.lastReq.Args)
 	}
+	if !strings.HasPrefix(runner.lastReq.Args[1], "PATH=/usr/local/bin:/opt/homebrew/bin:$PATH ") {
+		t.Fatalf("remote command should add Mac binary dirs to PATH: %q", runner.lastReq.Args[1])
+	}
 	if !strings.Contains(runner.lastReq.Args[1], "prlctl") || !strings.Contains(runner.lastReq.Args[1], "--version") {
 		t.Fatalf("remote command=%q", runner.lastReq.Args[1])
 	}
@@ -161,6 +164,14 @@ func TestParallelsLinkedCloneRequiresExplicitSnapshot(t *testing.T) {
 	}
 }
 
+func TestValidateParallelsSnapshotCloneModeRejectsPowerOnDryRun(t *testing.T) {
+	snapshot := ParallelsSnapshot{Name: "macOS 26.3.1 LATEST", State: "poweron"}
+	err := validateParallelsSnapshotCloneMode(snapshot, "linked")
+	if err == nil || !strings.Contains(err.Error(), "power-off snapshot") {
+		t.Fatalf("err=%v", err)
+	}
+}
+
 func TestApplyParallelsTemplateConfig(t *testing.T) {
 	cfg := baseConfig()
 	cfg.Provider = "parallels"