ci: keep sqlc refactor checks green

Author: steipete

.github/workflows/ci.yml

@@ -72,12 +72,15 @@ jobs:
       - name: Test with coverage
         run: go test -count=1 ./... -coverprofile=coverage.out
 
+      - name: Exclude generated code from coverage
+        run: grep -v '^github.com/openclaw/discrawl/internal/store/storedb/' coverage.out > coverage.filtered.out
+
       - name: Test with race detector
         run: go test -count=1 -race ./...
 
       - name: Enforce coverage floor
         run: |
-          total="$(go tool cover -func=coverage.out | awk '/^total:/ { sub(/%$/, "", $3); print $3 }')"
+          total="$(go tool cover -func=coverage.filtered.out | awk '/^total:/ { sub(/%$/, "", $3); print $3 }')"
           awk -v total="$total" 'BEGIN {
             if (total == "") {
               print "missing coverage total"

internal/store/attachments_test.go

@@ -56,6 +56,7 @@ func TestAttachmentMediaUpdatesAndFilters(t *testing.T) {
 		FetchStatus:   "fetched",
 	}))
 	require.NoError(t, s.UpdateAttachmentFetchStatus(ctx, "a2", "2026-05-15T12:06:00Z", "failed", "boom"))
+	require.NoError(t, seedAttachmentForGuild(ctx, s, "g1", "c1", "m1", "a1"))
 
 	rows, err := s.ListAttachments(ctx, AttachmentListOptions{MissingOnly: true})
 	require.NoError(t, err)

internal/store/query.go

@@ -45,7 +45,7 @@ type SemanticSearchOptions struct {
 func (s *Store) GetSyncState(ctx context.Context, scope string) (string, error) {
 	cursor, err := s.q.GetSyncState(ctx, scope)
 	if err != nil {
-		if err == sql.ErrNoRows {
+		if errors.Is(err, sql.ErrNoRows) {
 			return "", nil
 		}
 		return "", err
@@ -670,18 +670,18 @@ func (s *Store) Status(ctx context.Context, dbPath, defaultGuildID string) (Stat
 	status.ThreadCount = int(threadCount)
 
 	lastSync, err := s.q.GetSyncUpdatedAt(ctx, "sync:last_success")
-	if err != nil && err != sql.ErrNoRows {
+	if err != nil && !errors.Is(err, sql.ErrNoRows) {
 		return Status{}, err
 	}
 	status.LastSyncAt = parseTime(lastSync)
 	lastTail, err := s.q.GetSyncUpdatedAt(ctx, "tail:last_event")
-	if err != nil && err != sql.ErrNoRows {
+	if err != nil && !errors.Is(err, sql.ErrNoRows) {
 		return Status{}, err
 	}
 	status.LastTailEventAt = parseTime(lastTail)
 	if defaultGuildID != "" {
 		name, err := s.q.GetGuildName(ctx, defaultGuildID)
-		if err != nil && err != sql.ErrNoRows {
+		if err != nil && !errors.Is(err, sql.ErrNoRows) {
 			return Status{}, err
 		}
 		status.DefaultGuildName = name

internal/store/sqlc_schema_test.go

@@ -25,7 +25,7 @@ func TestSQLCSchemaMirrorsRuntimeTables(t *testing.T) {
 
 	body, err := os.ReadFile(filepath.Join("sqlc", "schema.sql"))
 	require.NoError(t, err)
-	for _, stmt := range strings.Split(string(body), ";") {
+	for stmt := range strings.SplitSeq(string(body), ";") {
 		stmt = strings.TrimSpace(stmt)
 		if stmt == "" || strings.HasPrefix(stmt, "--") {
 			continue
@@ -46,14 +46,14 @@ func TestSQLCSchemaMirrorsRuntimeTables(t *testing.T) {
 		"embedding_jobs",
 		"message_embeddings",
 	} {
-		require.Equal(t, tableColumns(t, runtimeStore.DB(), table), tableColumns(t, schemaDB, table), table)
+		require.Equal(t, tableColumns(ctx, t, runtimeStore.DB(), table), tableColumns(ctx, t, schemaDB, table), table)
 	}
 }
 
-func tableColumns(t *testing.T, db *sql.DB, table string) []string {
+func tableColumns(ctx context.Context, t *testing.T, db *sql.DB, table string) []string {
 	t.Helper()
 
-	rows, err := db.Query(`pragma table_info(` + table + `)`)
+	rows, err := db.QueryContext(ctx, `pragma table_info(`+table+`)`)
 	require.NoError(t, err)
 	defer func() { _ = rows.Close() }()
 

internal/store/store_test.go

@@ -153,6 +153,20 @@ func TestStoreMaintenanceHelpers(t *testing.T) {
 	require.NoError(t, err)
 	require.Equal(t, os.FileMode(0o600), info.Mode().Perm())
 	require.NoError(t, s.RebuildSearchIndexes(ctx))
+	messageVersion, err := s.GetSyncState(ctx, "schema:message_fts_rowid_version")
+	require.NoError(t, err)
+	require.Equal(t, messageFTSVersion, messageVersion)
+	memberVersion, err := s.GetSyncState(ctx, "schema:member_fts_rowid_version")
+	require.NoError(t, err)
+	require.Equal(t, memberFTSVersion, memberVersion)
+	require.NoError(t, s.RebuildMessageSearchIndex(ctx))
+	messageVersion, err = s.GetSyncState(ctx, "schema:message_fts_rowid_version")
+	require.NoError(t, err)
+	require.Equal(t, messageFTSVersion, messageVersion)
+	require.NoError(t, s.RebuildMemberSearchIndex(ctx))
+	memberVersion, err = s.GetSyncState(ctx, "schema:member_fts_rowid_version")
+	require.NoError(t, err)
+	require.Equal(t, memberFTSVersion, memberVersion)
 	version, err := s.schemaVersion(ctx)
 	require.NoError(t, err)
 	require.Equal(t, storeSchemaVersion, version)

internal/store/write.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"database/sql"
 	"encoding/json"
+	"errors"
 	"time"
 
 	"github.com/openclaw/discrawl/internal/store/storedb"
@@ -295,7 +296,7 @@ func upsertMessageTx(ctx context.Context, tx *sql.Tx, qtx *storedb.Queries, mess
 	if opts.EnqueueEmbedding {
 		normalized, err := qtx.GetMessageNormalizedContent(ctx, message.ID)
 		previousErr = err
-		if previousErr != nil && previousErr != sql.ErrNoRows {
+		if previousErr != nil && !errors.Is(previousErr, sql.ErrNoRows) {
 			return previousErr
 		}
 		if previousErr == nil {
@@ -321,7 +322,7 @@ func upsertMessageTx(ctx context.Context, tx *sql.Tx, qtx *storedb.Queries, mess
 			return err
 		}
 	}
-	queueEmbedding := opts.EnqueueEmbedding && (previousErr == sql.ErrNoRows || previousNormalized.String != message.NormalizedContent || !jobExists)
+	queueEmbedding := opts.EnqueueEmbedding && (errors.Is(previousErr, sql.ErrNoRows) || previousNormalized.String != message.NormalizedContent || !jobExists)
 	if queueEmbedding {
 		if err := qtx.UpsertEmbeddingJobPending(ctx, storedb.UpsertEmbeddingJobPendingParams{MessageID: message.ID, UpdatedAt: now}); err != nil {
 			return err