fix(sheets): cover rich-text hyperlinks in links command (#374) (thanks @omothm)

Author: steipete

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 ### Added
 - Sheets: add `sheets insert` to insert rows/columns into a sheet. (#203) — thanks @andybergon.
+- Sheets: add `sheets links` (alias `hyperlinks`) to list cell links from ranges, including rich-text links. (#374) — thanks @omothm.
 - Gmail: add `watch serve --history-types` filtering (`messageAdded|messageDeleted|labelAdded|labelRemoved`) and include `deletedMessageIds` in webhook payloads. (#168) — thanks @salmonumbrella.
 - Contacts: support `--org`, `--title`, `--url`, `--note`, and `--custom` on create/update; include custom fields in get output with deterministic ordering. (#199) — thanks @phuctm97.
 - Drive: add `drive ls --all` (alias `--global`) to list across all accessible files; make `--all` and `--parent` mutually exclusive. (#107) — thanks @struong.

README.md

@@ -906,6 +906,7 @@ gog sheets export <spreadsheetId> --format pdf --out ./sheet.pdf
 gog sheets format <spreadsheetId> 'Sheet1!A1:B2' --format-json '{"textFormat":{"bold":true}}' --format-fields 'userEnteredFormat.textFormat.bold'
 gog sheets insert <spreadsheetId> "Sheet1" rows 2 --count 3
 gog sheets notes <spreadsheetId> 'Sheet1!A1:B10'
+gog sheets links <spreadsheetId> 'Sheet1!A1:B10'
 ```
 
 ### Contacts
@@ -997,6 +998,7 @@ gog sheets insert <spreadsheetId> "Sheet1" cols 3 --after
 
 # Notes
 gog sheets notes <spreadsheetId> 'Sheet1!A1:B10'
+gog sheets links <spreadsheetId> 'Sheet1!A1:B10'   # Includes rich-text links
 
 # Create
 gog sheets create "My New Spreadsheet" --sheets "Sheet1,Sheet2"

internal/cmd/sheets_links.go

@@ -6,6 +6,8 @@ import (
 	"os"
 	"strings"
 
+	"google.golang.org/api/sheets/v4"
+
 	"github.com/steipete/gogcli/internal/outfmt"
 	"github.com/steipete/gogcli/internal/ui"
 )
@@ -39,7 +41,7 @@ func (c *SheetsLinksCmd) Run(ctx context.Context, flags *RootFlags) error {
 	resp, err := svc.Spreadsheets.Get(spreadsheetID).
 		Ranges(rangeSpec).
 		IncludeGridData(true).
-		Fields("sheets(properties(title),data(startRow,startColumn,rowData(values(hyperlink,formattedValue))))").
+		Fields("sheets(properties(title),data(startRow,startColumn,rowData(values(hyperlink,formattedValue,userEnteredFormat(textFormat(link(uri))),textFormatRuns(format(link(uri)))))))").
 		Do()
 	if err != nil {
 		return err
@@ -78,19 +80,22 @@ func (c *SheetsLinksCmd) Run(ctx context.Context, flags *RootFlags) error {
 					if cell == nil {
 						continue
 					}
-					if cell.Hyperlink == "" {
+					cellLinks := extractCellLinks(cell)
+					if len(cellLinks) == 0 {
 						continue
 					}
 					absRow := startRow + ri + 1
 					absCol := startCol + ci + 1
-					links = append(links, cellLink{
-						Sheet: sheetTitle,
-						A1:    formatA1Cell(sheetTitle, absRow, absCol),
-						Row:   absRow,
-						Col:   absCol,
-						Value: cell.FormattedValue,
-						Link:  cell.Hyperlink,
-					})
+					for _, link := range cellLinks {
+						links = append(links, cellLink{
+							Sheet: sheetTitle,
+							A1:    formatA1Cell(sheetTitle, absRow, absCol),
+							Row:   absRow,
+							Col:   absCol,
+							Value: cell.FormattedValue,
+							Link:  link,
+						})
+					}
 				}
 			}
 		}
@@ -121,3 +126,38 @@ func (c *SheetsLinksCmd) Run(ctx context.Context, flags *RootFlags) error {
 	}
 	return nil
 }
+
+func extractCellLinks(cell *sheets.CellData) []string {
+	if cell == nil {
+		return nil
+	}
+
+	seen := make(map[string]struct{})
+	links := make([]string, 0, 1)
+	add := func(link string) {
+		trimmed := strings.TrimSpace(link)
+		if trimmed == "" {
+			return
+		}
+		if _, ok := seen[trimmed]; ok {
+			return
+		}
+		seen[trimmed] = struct{}{}
+		links = append(links, trimmed)
+	}
+
+	add(cell.Hyperlink)
+
+	if cell.UserEnteredFormat != nil && cell.UserEnteredFormat.TextFormat != nil && cell.UserEnteredFormat.TextFormat.Link != nil {
+		add(cell.UserEnteredFormat.TextFormat.Link.Uri)
+	}
+
+	for _, run := range cell.TextFormatRuns {
+		if run == nil || run.Format == nil || run.Format.Link == nil {
+			continue
+		}
+		add(run.Format.Link.Uri)
+	}
+
+	return links
+}

internal/cmd/sheets_links_test.go

@@ -7,6 +7,7 @@ import (
 	"net/http"
 	"net/http/httptest"
 	"os"
+	"reflect"
 	"strings"
 	"testing"
 
@@ -285,3 +286,122 @@ func TestSheetsLinksCmd_NoLinks(t *testing.T) {
 		t.Errorf("expected 'No links found' on stderr: %q", errOut)
 	}
 }
+
+func TestSheetsLinksCmd_RichTextRunsAndCellLevelLinks(t *testing.T) {
+	origNew := newSheetsService
+	t.Cleanup(func() { newSheetsService = origNew })
+
+	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		w.Header().Set("Content-Type", "application/json")
+		_ = json.NewEncoder(w).Encode(map[string]any{
+			"sheets": []map[string]any{
+				{
+					"properties": map[string]any{
+						"title": "Sheet1",
+					},
+					"data": []map[string]any{
+						{
+							"startRow":    2,
+							"startColumn": 2,
+							"rowData": []map[string]any{
+								{
+									"values": []map[string]any{
+										{
+											"formattedValue": "Rich links",
+											"userEnteredFormat": map[string]any{
+												"textFormat": map[string]any{
+													"link": map[string]any{"uri": "https://cell.example"},
+												},
+											},
+											"textFormatRuns": []map[string]any{
+												{"startIndex": 0, "format": map[string]any{"link": map[string]any{"uri": "https://cell.example"}}},
+												{"startIndex": 4, "format": map[string]any{"link": map[string]any{"uri": "https://run1.example"}}},
+												{"startIndex": 8, "format": map[string]any{"link": map[string]any{"uri": " https://run2.example "}}},
+											},
+										},
+									},
+								},
+							},
+						},
+					},
+				},
+			},
+		})
+	}))
+	defer srv.Close()
+
+	svc, err := sheets.NewService(context.Background(),
+		option.WithoutAuthentication(),
+		option.WithHTTPClient(srv.Client()),
+		option.WithEndpoint(srv.URL+"/"),
+	)
+	if err != nil {
+		t.Fatalf("NewService: %v", err)
+	}
+	newSheetsService = func(context.Context, string) (*sheets.Service, error) { return svc, nil }
+
+	flags := &RootFlags{Account: "a@b.com"}
+	u, uiErr := ui.New(ui.Options{Stdout: io.Discard, Stderr: io.Discard, Color: "never"})
+	if uiErr != nil {
+		t.Fatalf("ui.New: %v", uiErr)
+	}
+	ctx := ui.WithUI(context.Background(), u)
+	ctx = outfmt.WithMode(ctx, outfmt.Mode{JSON: true})
+
+	out := captureStdout(t, func() {
+		if err := runKong(t, &SheetsLinksCmd{}, []string{"s1", "Sheet1!C3"}, ctx, flags); err != nil {
+			t.Fatalf("links: %v", err)
+		}
+	})
+
+	var result map[string]any
+	if err := json.Unmarshal([]byte(out), &result); err != nil {
+		t.Fatalf("unmarshal: %v (output: %q)", err, out)
+	}
+
+	linksAny, ok := result["links"].([]any)
+	if !ok {
+		t.Fatalf("expected links array, got %T", result["links"])
+	}
+	if len(linksAny) != 3 {
+		t.Fatalf("expected 3 deduped links, got %d", len(linksAny))
+	}
+
+	got := make([]string, 0, len(linksAny))
+	for _, entry := range linksAny {
+		row := entry.(map[string]any)
+		if row["a1"] != "Sheet1!C3" {
+			t.Fatalf("unexpected a1: %v", row["a1"])
+		}
+		got = append(got, row["link"].(string))
+	}
+
+	want := []string{"https://cell.example", "https://run1.example", "https://run2.example"}
+	if !reflect.DeepEqual(got, want) {
+		t.Fatalf("unexpected links: got %v want %v", got, want)
+	}
+}
+
+func TestExtractCellLinks(t *testing.T) {
+	cell := &sheets.CellData{
+		Hyperlink: " https://a.example ",
+		UserEnteredFormat: &sheets.CellFormat{
+			TextFormat: &sheets.TextFormat{
+				Link: &sheets.Link{Uri: "https://a.example"},
+			},
+		},
+		TextFormatRuns: []*sheets.TextFormatRun{
+			{Format: &sheets.TextFormat{Link: &sheets.Link{Uri: "https://b.example"}}},
+			{Format: &sheets.TextFormat{Link: &sheets.Link{Uri: "https://a.example"}}},
+			nil,
+			{Format: nil},
+			{Format: &sheets.TextFormat{Link: &sheets.Link{Uri: "   "}}},
+		},
+	}
+
+	got := extractCellLinks(cell)
+	want := []string{"https://a.example", "https://b.example"}
+	if !reflect.DeepEqual(got, want) {
+		t.Fatalf("unexpected links: got %v want %v", got, want)
+	}
+}

internal/cmd/sheets_validation_more_test.go

@@ -197,6 +197,12 @@ func TestSheetsClearMetadataCreate_ValidationErrors(t *testing.T) {
 	if err := (&SheetsMetadataCmd{}).Run(ctx, flags); err == nil {
 		t.Fatalf("expected metadata missing spreadsheetId error")
 	}
+	if err := (&SheetsLinksCmd{}).Run(ctx, flags); err == nil {
+		t.Fatalf("expected links missing spreadsheetId error")
+	}
+	if err := (&SheetsLinksCmd{SpreadsheetID: "s1"}).Run(ctx, flags); err == nil {
+		t.Fatalf("expected links missing range error")
+	}
 	if err := (&SheetsCreateCmd{}).Run(ctx, flags); err == nil {
 		t.Fatalf("expected create missing title error")
 	}