fix(gmail): avoid err shadow

steipete · steipete · commit 1a125efbb369 · 2026-02-14T14:06:25.000+01:00
diff --git a/internal/cmd/gmail_attachment.go b/internal/cmd/gmail_attachment.go
@@ -49,12 +49,12 @@ func (c *GmailAttachmentCmd) Run(ctx context.Context, flags *RootFlags) error {
 	}
 
 	// Avoid touching auth/keyring and avoid writing files in dry-run mode.
-	if err := dryRunExit(ctx, flags, "gmail.attachment.download", map[string]any{
+	if dryRunErr := dryRunExit(ctx, flags, "gmail.attachment.download", map[string]any{
 		"message_id":    messageID,
 		"attachment_id": attachmentID,
 		"path":          destPath,
-	}); err != nil {
-		return err
+	}); dryRunErr != nil {
+		return dryRunErr
 	}
 
 	account, err := requireAccount(flags)

Original file line number	Diff line number	Diff line change
`@@ -49,12 +49,12 @@ func (c GmailAttachmentCmd) Run(ctx context.Context, flags RootFlags) error {`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`// Avoid touching auth/keyring and avoid writing files in dry-run mode.`
`52`		`- if err := dryRunExit(ctx, flags, "gmail.attachment.download", map[string]any{`
	`52`	`+ if dryRunErr := dryRunExit(ctx, flags, "gmail.attachment.download", map[string]any{`
`53`	`53`	`"message_id": messageID,`
`54`	`54`	`"attachment_id": attachmentID,`
`55`	`55`	`"path": destPath,`
`56`		`- }); err != nil {`
`57`		`- return err`
	`56`	`+ }); dryRunErr != nil {`
	`57`	`+ return dryRunErr`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`account, err := requireAccount(flags)`