feat: debounce map loading spinner to avoid flash on cached timesteps#755
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
suvanbanerjee
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Debounce the forecast map loading spinner so it only appears for genuine loads, not the brief flicker when flipping between already-cached timesteps.
Set a single isLoading boolean and gate the spinner behind a debounced showSpinner state that only turns on after loading persists for 700ms. Cached re-renders resolve well within that window so the spinner never shows; genuine network loads still surface it. Timer is cleared whenever loading resolves, preventing a stale flash. Existing 3s mapDataLoading safety timeout left untouched as a backstop.
Fixes #754
How Has This Been Tested?
Checklist: