Remove suffix vfs test case

Author: TheOneRing

test/testsyncmove.cpp

@@ -989,7 +989,6 @@ private Q_SLOTS:
         QTest::addColumn<Vfs::Mode>("vfsMode");
 
         QTest::newRow("Vfs::Off") << Vfs::Off;
-        QTest::newRow("Vfs::WithSuffix") << Vfs::WithSuffix;
 #ifdef Q_OS_WIN32
         if (VfsPluginManager::instance().isVfsPluginAvailable(Vfs::WindowsCfApi)) {
             QTest::newRow("Vfs::WindowsCfApi") << Vfs::WindowsCfApi;
@@ -1002,14 +1001,6 @@ private Q_SLOTS:
     void testMovedWithError()
     {
         QFETCH(Vfs::Mode, vfsMode);
-        const auto getName = [vfsMode] (const QString &s)
-        {
-            if (vfsMode == Vfs::WithSuffix)
-            {
-                return QStringLiteral("%1%2").arg(s, Theme::instance()->appDotVirtualFileSuffix());
-            }
-            return s;
-        };
         const QString src = QStringLiteral("folder/folderA/file.txt");
         const QString dest = QStringLiteral("folder/folderB/file.txt");
         FakeFolder fakeFolder{ FileInfo{ QString(), { FileInfo{ QStringLiteral("folder"), { FileInfo{ QStringLiteral("folderA"), { { QStringLiteral("file.txt"), 400 } } }, QStringLiteral("folderB") } } } } };
@@ -1032,7 +1023,7 @@ private Q_SLOTS:
 
 
         fakeFolder.serverErrorPaths().append(src, 403);
-        fakeFolder.localModifier().rename(getName(src), getName(dest));
+        fakeFolder.localModifier().rename(src, dest);
         QVERIFY(fakeFolder.currentRemoteState().find(src));
         QVERIFY(!fakeFolder.currentRemoteState().find(dest));
 
@@ -1049,12 +1040,7 @@ private Q_SLOTS:
         }
 
         QVERIFY(!fakeFolder.currentLocalState().find(src));
-        QVERIFY(fakeFolder.currentLocalState().find(getName(dest)));
-        if (vfsMode == Vfs::WithSuffix)
-        {
-            // the placeholder was not restored as it is still in error state
-            QVERIFY(!fakeFolder.currentLocalState().find(dest));
-        }
+        QVERIFY(fakeFolder.currentLocalState().find(dest));
         QVERIFY(fakeFolder.currentRemoteState().find(src));
         QVERIFY(!fakeFolder.currentRemoteState().find(dest));
     }