Skip to content

Commit c877c3b

Browse files
committed
Use opencloud in webfinger rel
1 parent 4a142b3 commit c877c3b

File tree

3 files changed

+13
-10
lines changed

3 files changed

+13
-10
lines changed

src/gui/newwizard/jobs/webfingeruserinfojobfactory.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
#include "webfingeruserinfojobfactory.h"
1616
#include "common/utility.h"
1717
#include "creds/httpcredentials.h"
18+
#include "creds/webfinger.h"
1819

1920
#include <QApplication>
2021
#include <QJsonArray>
@@ -83,7 +84,7 @@ CoreJob *WebFingerInstanceLookupJobFactory::startJob(const QUrl &url, QObject *p
8384
const QString rel = linkObject.value(QStringLiteral("rel")).toString();
8485
const QString href = linkObject.value(QStringLiteral("href")).toString();
8586

86-
if (rel != QStringLiteral("http://webfinger.owncloud/rel/server-instance")) {
87+
if (rel != WebFinger::relId()) {
8788
qCDebug(lcWebFingerUserInfoJob) << "skipping invalid link" << href << "with rel" << rel;
8889
continue;
8990
}

src/libsync/creds/webfinger.cpp

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,6 @@
2727

2828
Q_LOGGING_CATEGORY(lcWebFinger, "sync.credentials.webfinger", QtInfoMsg)
2929

30-
namespace {
31-
32-
auto relId()
33-
{
34-
return QStringLiteral("http://webfinger.owncloud/rel/server-instance");
35-
}
36-
}
37-
3830
using namespace OCC;
3931

4032
WebFinger::WebFinger(QNetworkAccessManager *nam, QObject *parent)
@@ -45,7 +37,7 @@ WebFinger::WebFinger(QNetworkAccessManager *nam, QObject *parent)
4537

4638
void WebFinger::start(const QUrl &url, const QString &resourceId)
4739
{
48-
// GET /.well-known/webfinger?rel=http://webfinger.owncloud/rel/server-instance&resource=acct:test@owncloud.com HTTP/1.1
40+
// GET /.well-known/webfinger?rel=http://webfinger.opencloud.eu/rel/server-instance&resource=acct:test@owncloud.com HTTP/1.1
4941
if (OC_ENSURE(url.scheme() == QLatin1String("https"))) {
5042
QUrlQuery query;
5143
query.setQueryItems({ { QStringLiteral("resource"), QString::fromUtf8(QUrl::toPercentEncoding(resourceId)) },
@@ -93,3 +85,8 @@ const QUrl &WebFinger::href() const
9385
{
9486
return _href;
9587
}
88+
89+
QString WebFinger::relId()
90+
{
91+
return QStringLiteral("http://webfinger.opencloud.eu/rel/server-instance");
92+
}

src/libsync/creds/webfinger.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,11 @@ class OWNCLOUDSYNC_EXPORT WebFinger : public QObject
3535

3636
const QUrl &href() const;
3737

38+
/***
39+
* ID used to describe our rel attribute
40+
*/
41+
static QString relId();
42+
3843
Q_SIGNALS:
3944
void finished();
4045

0 commit comments

Comments
 (0)