Reactivate clang-tidy

Author: TheOneRing

.github/workflows/.run-clang-tidy.ps1

@@ -1,7 +1 @@
-cd "${env:GITHUB_WORKSPACE}"
-
-# allow errors as some files can't be compiled on all platforms
-$oldErrorActio = $ErrorActionPreference
-$ErrorActionPreference="Continue"
-git ls-files *.cpp | ForEach-Object -Parallel {clang-tidy -p $env:BUILD_DIR/compile_commands.json $_ } -ThrottleLimit 5 | Tee-Object -Path "$([System.IO.Path]::GetTempPath())/clang-tidy.log"
-$ErrorActionPreference = $oldErrorActio
+run-clang-tidy -p "$env:BUILD_DIR" | Tee-Object -Path "$([System.IO.Path]::GetTempPath())/clang-tidy.log"

.github/workflows/main.yml

@@ -164,7 +164,7 @@ jobs:
 
     - name: Clang tidy
       # disable for now
-      if: ${{ false && github.event_name != 'pull_request' }}
+      if: ${{ true || github.event_name != 'pull_request' }}
       run: |
         & "${env:GITHUB_WORKSPACE}/.github/workflows/.craft.ps1" -c libs/llvm python-modules/pip
         & "${env:GITHUB_WORKSPACE}/.github/workflows/.craft.ps1" -c --run python3 -m pip install clang-html