Add XAttr based plugin for VFS for Linux and later Mac

Author: dragotin

CMakeLists.txt

@@ -103,7 +103,7 @@ add_feature_info(AppImageUpdate WITH_APPIMAGEUPDATER "Built-in libappimageupdate
 option(WITH_EXTERNAL_BRANDING "A URL to an external branding repo" "")
 
 # specify additional vfs plugins
-set(VIRTUAL_FILE_SYSTEM_PLUGINS off cfapi CACHE STRING "Name of internal plugin in src/libsync/vfs or the locations of virtual file plugins")
+set(VIRTUAL_FILE_SYSTEM_PLUGINS off cfapi xattr CACHE STRING "Name of internal plugin in src/libsync/vfs or the locations of virtual file plugins")
 
 if(APPLE)
   set( SOCKETAPI_TEAM_IDENTIFIER_PREFIX "" CACHE STRING "SocketApi prefix (including a following dot) that must match the codesign key's TeamIdentifier/Organizational Unit" )

src/libsync/common/pinstate.cpp

@@ -19,6 +19,26 @@
 
 using namespace OCC;
 
+
+template <>
+QString Utility::enumToDisplayName(PinState pState)
+{
+    switch (pState) {
+    case PinState::AlwaysLocal:
+        return QStringLiteral("alwayslocal");
+    case PinState::Excluded:
+        return QStringLiteral("excluded");
+    case PinState::Inherited:
+        return QStringLiteral("inherited");
+    case PinState::OnlineOnly:
+        return QStringLiteral("onlineonly");
+    case PinState::Unspecified:
+        return QStringLiteral("unspecified");
+    }
+    Q_UNREACHABLE();
+}
+
+
 template <>
 QString Utility::enumToDisplayName(VfsItemAvailability availability)
 {

src/libsync/common/pinstate.h

@@ -137,6 +137,8 @@ using namespace PinStateEnums;
 
 template <>
 OPENCLOUD_SYNC_EXPORT QString Utility::enumToDisplayName(VfsItemAvailability availability);
+template <>
+OPENCLOUD_SYNC_EXPORT QString Utility::enumToDisplayName(PinState pState);
 }
 
 #endif

src/libsync/vfs/vfs.cpp

@@ -51,6 +51,8 @@ Optional<Vfs::Mode> Vfs::modeFromString(const QString &str)
         return Off;
     } else if (str == QLatin1String("cfapi")) {
         return WindowsCfApi;
+    } else if (str == QLatin1String("xattr")) {
+        return XAttr;
     }
     return {};
 }
@@ -65,6 +67,8 @@ QString Utility::enumToString(Vfs::Mode mode)
         return QStringLiteral("cfapi");
     case Vfs::Mode::Off:
         return QStringLiteral("off");
+    case Vfs::Mode::XAttr:
+        return QStringLiteral("xattr");
     }
     Q_UNREACHABLE();
 }
@@ -146,6 +150,7 @@ void Vfs::wipeDehydratedVirtualFiles()
 
 QFuture<Result<void, QString>> Vfs::hydrateFile(const QByteArray &fileId)
 {
+    Q_UNUSED(fileId)
     // nothing to do
     return QtFuture::makeReadyValueFuture(Result<void, QString>{});
 }
@@ -207,6 +212,8 @@ Vfs::Mode OCC::VfsPluginManager::bestAvailableVfsMode() const
 {
     if (isVfsPluginAvailable(Vfs::WindowsCfApi)) {
         return Vfs::WindowsCfApi;
+    } else if (isVfsPluginAvailable(Vfs::XAttr)) {
+        return Vfs::XAttr;
     } else if (isVfsPluginAvailable(Vfs::Off)) {
         return Vfs::Off;
     }

src/libsync/vfs/vfs.h

@@ -97,7 +97,7 @@ class OPENCLOUD_SYNC_EXPORT Vfs : public QObject
      * Currently plugins and modes are one-to-one but that's not required.
      * The raw integer values are used in Qml
      */
-    enum Mode : uint8_t { Off = 0, WindowsCfApi = 1 };
+    enum Mode : uint8_t { Off = 0, WindowsCfApi = 1, XAttr = 2 };
     Q_ENUM(Mode)
     enum class ConvertToPlaceholderResult : uint8_t { Ok, Locked };
     Q_ENUM(ConvertToPlaceholderResult)
@@ -251,9 +251,9 @@ public Q_SLOTS:
      */
     virtual void startImpl(const VfsSetupParams &params) = 0;
 
-private:
     // the parameters passed to start()
     std::unique_ptr<VfsSetupParams> _setupParams;
+private:
 
     friend class OwncloudPropagator;
 };

src/plugins/vfs/xattr/CMakeLists.txt

@@ -0,0 +1,4 @@
+    add_vfs_plugin(NAME xattr
+        SRC
+            vfs_xattr.cpp
+    )