Skip to content

Commit 25c78d1

Browse files
committed
chore(search): trim the live photo comments
1 parent ad53ebe commit 25c78d1

2 files changed

Lines changed: 4 additions & 9 deletions

File tree

services/search/pkg/content/tika_live_photo.go

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,10 @@ import (
88
)
99

1010
func (t Tika) getLivePhoto(meta map[string][]string) *libregraph.LivePhoto {
11-
// ContentId pairs the two halves and is what makes it a live photo, so without
12-
// it there is no facet. The video exposes it via the QuickTime item list; the
13-
// still image carries it in the Apple maker note (tag 0x0011), which tika
14-
// surfaces generically under "Content Identifier" (the HEIC maker note is
15-
// parsed since metadata-extractor 2.21.0). A file is only ever one half, so
16-
// reading both keys covers both.
11+
// ContentId pairs the two halves, without it there is no live photo. The
12+
// video carries it in the QuickTime item list, the still image in the Apple
13+
// maker note, which tika surfaces as "Content Identifier". A file is only
14+
// ever one half, so both keys are read.
1715
contentID, err := getFirstValue(meta, "com.apple.quicktime.content.identifier", "Content Identifier")
1816
if err != nil || contentID == "" {
1917
return nil

services/search/pkg/content/tika_live_photo_test.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@ var _ = Describe("getLivePhoto", func() {
2626
})
2727

2828
It("maps the still half via the Apple maker-note content identifier", func() {
29-
// the still carries the pairing id in the Apple maker note, which tika
30-
// surfaces under "Content Identifier" (HEIC maker note parsed since
31-
// metadata-extractor 2.21.0, drewnoakes/metadata-extractor#739).
3229
livePhoto := Tika{}.getLivePhoto(map[string][]string{
3330
"Content-Type": {"image/heic"},
3431
"Content Identifier": {"6F1A2B3C-1234-4E5F-9A8B-0011223344CC"},

0 commit comments

Comments
 (0)