test(decomposedfs): assert a space manager may disable a project space

Since #672 a space manager may disable but not purge a project space.
The "can delete (purge) project spaces" context asserts only the denial
side ("fails as a space manager" purge); the positive counterpart, that a
manager may still disable, was untested. A regression breaking manager
disable would pass the suite unnoticed.

Add the counterpart It: create a fresh project space and disable it as
the space manager, expecting success (the shared space in BeforeEach is
already disabled, so the test uses its own). Test-only, no production
change.

Author: michaelstingl

pkg/storage/pkg/decomposedfs/spaces_test.go

@@ -203,6 +203,17 @@ var _ = Describe("Spaces", func() {
 				err := env.Fs.DeleteStorageSpace(ctx, delReq)
 				Expect(err).To(HaveOccurred())
 			})
+			It("succeeds at disabling as a space manager", func() {
+				// The positive counterpart to the purge denial above: since #672
+				// a space manager may still disable (but not purge) a project
+				// space. delReq's space is pre-disabled in BeforeEach, so use a
+				// fresh one.
+				resp, err := env.Fs.CreateStorageSpace(env.Ctx, &provider.CreateStorageSpaceRequest{Name: "Manager Disables", Type: "project"})
+				Expect(err).ToNot(HaveOccurred())
+				ctx := ctxpkg.ContextSetUser(context.Background(), env.SpaceManager)
+				err = env.Fs.DeleteStorageSpace(ctx, &provider.DeleteStorageSpaceRequest{Id: resp.StorageSpace.GetId()})
+				Expect(err).To(Not(HaveOccurred()))
+			})
 			// Reproducer for opencloud-eu/opencloud#2985: purging a space must
 			// invalidate ALL of its msgpack indexes, not only the by-type index.
 			// The by-user-id index keeps a stale entry pointing at the purged