|
| 1 | +// Copyright 2026 OpenCloud GmbH <mail@opencloud.eu> |
| 2 | +// SPDX-License-Identifier: Apache-2.0 |
| 3 | + |
| 4 | +package tus |
| 5 | + |
| 6 | +import ( |
| 7 | + "context" |
| 8 | + "errors" |
| 9 | + |
| 10 | + userpb "github.com/cs3org/go-cs3apis/cs3/identity/user/v1beta1" |
| 11 | + provider "github.com/cs3org/go-cs3apis/cs3/storage/provider/v1beta1" |
| 12 | + "github.com/rs/zerolog" |
| 13 | + tusd "github.com/tus/tusd/v2/pkg/handler" |
| 14 | + |
| 15 | + . "github.com/onsi/ginkgo/v2" |
| 16 | + . "github.com/onsi/gomega" |
| 17 | + |
| 18 | + "github.com/opencloud-eu/reva/v2/internal/http/services/owncloud/ocdav/net" |
| 19 | + ctxpkg "github.com/opencloud-eu/reva/v2/pkg/ctx" |
| 20 | + "github.com/opencloud-eu/reva/v2/pkg/storage" |
| 21 | +) |
| 22 | + |
| 23 | +// fakeResolver implements storage.UploadSessionResolver. Embedding storage.FS satisfies the |
| 24 | +// rest of that interface (those methods are never called by the callback under test). It |
| 25 | +// records the upload info it was called with and returns a preconfigured resource, context |
| 26 | +// and error, so the tests can drive the callback without a real storage backend. |
| 27 | +type fakeResolver struct { |
| 28 | + storage.FS |
| 29 | + ri *provider.ResourceInfo |
| 30 | + ctx context.Context |
| 31 | + err error |
| 32 | + gotInfo tusd.FileInfo |
| 33 | +} |
| 34 | + |
| 35 | +func (f *fakeResolver) ResolveUpload(ctx context.Context, info tusd.FileInfo) (*provider.ResourceInfo, context.Context, error) { |
| 36 | + f.gotInfo = info |
| 37 | + rctx := f.ctx |
| 38 | + if rctx == nil { |
| 39 | + rctx = ctx |
| 40 | + } |
| 41 | + return f.ri, rctx, f.err |
| 42 | +} |
| 43 | + |
| 44 | +// plainFS implements only storage.FS, not the resolver, so the callback takes its no-op path. |
| 45 | +type plainFS struct{ storage.FS } |
| 46 | + |
| 47 | +// testManager builds a manager with a no-op logger, the way New sets one in production, so the |
| 48 | +// callback's warn path does not dereference a nil logger. |
| 49 | +func testManager() *manager { |
| 50 | + l := zerolog.Nop() |
| 51 | + return &manager{log: &l} |
| 52 | +} |
| 53 | + |
| 54 | +var _ = Describe("preFinishResponseCallback", func() { |
| 55 | + executant := &userpb.UserId{Idp: "https://idp.example", OpaqueId: "executant-1"} |
| 56 | + asExecutant := ctxpkg.ContextSetUser(context.Background(), &userpb.User{Id: executant}) |
| 57 | + |
| 58 | + // a resource the executant may edit; owned by someone else unless overridden |
| 59 | + editable := func(etag, ownerID string) *provider.ResourceInfo { |
| 60 | + return &provider.ResourceInfo{ |
| 61 | + Etag: etag, |
| 62 | + Type: provider.ResourceType_RESOURCE_TYPE_FILE, |
| 63 | + Owner: &userpb.UserId{Idp: "https://idp.example", OpaqueId: ownerID}, |
| 64 | + PermissionSet: &provider.ResourcePermissions{ |
| 65 | + Stat: true, ListContainer: true, InitiateFileDownload: true, |
| 66 | + InitiateFileUpload: true, Move: true, Delete: true, |
| 67 | + }, |
| 68 | + } |
| 69 | + } |
| 70 | + |
| 71 | + hook := tusd.HookEvent{ |
| 72 | + Context: context.Background(), |
| 73 | + Upload: tusd.FileInfo{ID: "upload-1", Storage: map[string]string{"NodeId": "node-1"}}, |
| 74 | + } |
| 75 | + |
| 76 | + It("resolves the finished upload and sets etag and permissions", func() { |
| 77 | + fs := &fakeResolver{ri: editable(`"abc123"`, "other-owner"), ctx: asExecutant} |
| 78 | + |
| 79 | + resp, err := testManager().preFinishResponseCallback(fs)(hook) |
| 80 | + |
| 81 | + Expect(err).ToNot(HaveOccurred()) |
| 82 | + // the in-hand tus info is handed to the resolver, not looked up by id in the session store |
| 83 | + Expect(fs.gotInfo.ID).To(Equal("upload-1")) |
| 84 | + // etag mirrored into both headers |
| 85 | + Expect(resp.Header[net.HeaderOCETag]).To(Equal(`"abc123"`)) |
| 86 | + Expect(resp.Header[net.HeaderETag]).To(Equal(`"abc123"`)) |
| 87 | + // resolved as a user who does not own the resource -> shared -> permissions lead with S |
| 88 | + Expect(resp.Header[net.HeaderOCPermissions]).To(HavePrefix("S")) |
| 89 | + }) |
| 90 | + |
| 91 | + It("omits the shared marker when the resource is owned by the resolving user", func() { |
| 92 | + fs := &fakeResolver{ri: editable(`"abc123"`, "executant-1"), ctx: asExecutant} |
| 93 | + |
| 94 | + resp, err := testManager().preFinishResponseCallback(fs)(hook) |
| 95 | + |
| 96 | + Expect(err).ToNot(HaveOccurred()) |
| 97 | + Expect(resp.Header[net.HeaderOCPermissions]).ToNot(BeEmpty()) |
| 98 | + Expect(resp.Header[net.HeaderOCPermissions]).ToNot(HavePrefix("S")) |
| 99 | + }) |
| 100 | + |
| 101 | + It("is best-effort: no headers and no error when the resolve fails", func() { |
| 102 | + fs := &fakeResolver{err: errors.New("not found"), ctx: asExecutant} |
| 103 | + |
| 104 | + resp, err := testManager().preFinishResponseCallback(fs)(hook) |
| 105 | + |
| 106 | + Expect(err).ToNot(HaveOccurred()) |
| 107 | + Expect(resp.Header).ToNot(HaveKey(net.HeaderOCETag)) |
| 108 | + Expect(resp.Header).ToNot(HaveKey(net.HeaderETag)) |
| 109 | + Expect(resp.Header).ToNot(HaveKey(net.HeaderOCPermissions)) |
| 110 | + }) |
| 111 | + |
| 112 | + It("is best-effort: no headers and no error when the resolve returns no resource", func() { |
| 113 | + fs := &fakeResolver{ri: nil, ctx: asExecutant} |
| 114 | + |
| 115 | + resp, err := testManager().preFinishResponseCallback(fs)(hook) |
| 116 | + |
| 117 | + Expect(err).ToNot(HaveOccurred()) |
| 118 | + Expect(resp.Header).ToNot(HaveKey(net.HeaderOCPermissions)) |
| 119 | + Expect(resp.Header).ToNot(HaveKey(net.HeaderOCETag)) |
| 120 | + }) |
| 121 | + |
| 122 | + It("omits the etag header when the resource has none", func() { |
| 123 | + fs := &fakeResolver{ri: editable("", "other-owner"), ctx: asExecutant} |
| 124 | + |
| 125 | + resp, err := testManager().preFinishResponseCallback(fs)(hook) |
| 126 | + |
| 127 | + Expect(err).ToNot(HaveOccurred()) |
| 128 | + Expect(resp.Header).ToNot(HaveKey(net.HeaderOCETag)) |
| 129 | + Expect(resp.Header).To(HaveKey(net.HeaderOCPermissions)) |
| 130 | + }) |
| 131 | + |
| 132 | + It("does nothing when the storage driver cannot resolve uploads", func() { |
| 133 | + resp, err := testManager().preFinishResponseCallback(plainFS{})(hook) |
| 134 | + |
| 135 | + Expect(err).ToNot(HaveOccurred()) |
| 136 | + Expect(resp.Header).ToNot(HaveKey(net.HeaderOCETag)) |
| 137 | + Expect(resp.Header).ToNot(HaveKey(net.HeaderOCPermissions)) |
| 138 | + }) |
| 139 | +}) |
0 commit comments