Skip to content

refactor how solver parameters are handled #2257

Open
@rmtfleming

Description

@rmtfleming

Passing non-solver specific parameters to a solver gives an error. But this approach to split parameter structures

[problemTypeParams, extraParams] = parseSolverParameters(problemType, varargin)

and use extraParams for the solver needs to be replaced with one where a single parameter structure is stripped of any non-solver specific parameters before. What is problemType specific is defined here
paramNames = getCobraSolverParamsOptionsForType(problemType)
but that changes over time, making it confusing what parameter is a solver, problem-type vs other type of parameter with the potential for the same parameter to be different in different parameter structures. Better to only have one parameter structure then strip that to the solver specific ones just before calling the solver. One strip function per solver.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions