Added port serdes attributes for various taps (#2207)

Signed-off-by: Prince George <prgeor@microsoft.com>

Author: prgeor

inc/saiport.h

@@ -3965,7 +3965,7 @@ typedef enum _sai_port_serdes_attr_t
     /**
      * @brief Port serdes control TX FIR PRE1 filter
      *
-     * List of port serdes TX fir precursor1 tap-filter values.
+     * List of port serdes TX FIR precursor1 tap-filter values.
      * The values are of type sai_s32_list_t where the count is number lanes in
      * a port and the list specifies list of values to be applied to each lane.
      *
@@ -3978,7 +3978,7 @@ typedef enum _sai_port_serdes_attr_t
     /**
      * @brief Port serdes control TX FIR PRE2 filter
      *
-     * List of port serdes TX fir precursor2 tap-filter values.
+     * List of port serdes TX FIR precursor2 tap-filter values.
      * The values are of type sai_s32_list_t where the count is number lanes in
      * a port and the list specifies list of values to be applied to each lane.
      *
@@ -3991,7 +3991,7 @@ typedef enum _sai_port_serdes_attr_t
     /**
      * @brief Port serdes control TX FIR PRE3 filter
      *
-     * List of port serdes TX fir precursor3 tap-filter values.
+     * List of port serdes TX FIR precursor3 tap-filter values.
      * The values are of type sai_s32_list_t where the count is number lanes in
      * a port and the list specifies list of values to be applied to each lane.
      *
@@ -4004,7 +4004,7 @@ typedef enum _sai_port_serdes_attr_t
     /**
      * @brief Port serdes control TX FIR MAIN filter
      *
-     * List of port serdes TX fir maincursor tap-filter values.
+     * List of port serdes TX FIR maincursor tap-filter values.
      * The values are of type sai_s32_list_t where the count is number lanes in
      * a port and the list specifies list of values to be applied to each lane.
      *
@@ -4017,7 +4017,7 @@ typedef enum _sai_port_serdes_attr_t
     /**
      * @brief Port serdes control TX FIR POST1 filter
      *
-     * List of port serdes TX fir postcursor1 tap-filter values.
+     * List of port serdes TX FIR postcursor1 tap-filter values.
      * The values are of type sai_s32_list_t where the count is number lanes in
      * a port and the list specifies list of values to be applied to each lane.
      *
@@ -4030,7 +4030,7 @@ typedef enum _sai_port_serdes_attr_t
     /**
      * @brief Port serdes control TX FIR POST2 filter
      *
-     * List of port serdes TX fir postcursor2 tap-filter values.
+     * List of port serdes TX FIR postcursor2 tap-filter values.
      * The values are of type sai_s32_list_t where the count is number lanes in
      * a port and the list specifies list of values to be applied to each lane.
      *
@@ -4043,7 +4043,7 @@ typedef enum _sai_port_serdes_attr_t
     /**
      * @brief Port serdes control TX FIR POST3 filter
      *
-     * List of port serdes TX fir postcursor3 tap-filter values.
+     * List of port serdes TX FIR postcursor3 tap-filter values.
      * The values are of type sai_s32_list_t where the count is number lanes in
      * a port and the list specifies list of values to be applied to each lane.
      *
@@ -4056,7 +4056,7 @@ typedef enum _sai_port_serdes_attr_t
     /**
      * @brief Port serdes control TX FIR attenuation
      *
-     * List of port serdes TX fir attn values.
+     * List of port serdes TX FIR attn values.
      * The values are of type sai_s32_list_t where the count is number lanes in
      * a port and the list specifies list of values to be applied to each lane.
      *
@@ -4277,6 +4277,76 @@ typedef enum _sai_port_serdes_attr_t
      */
     SAI_PORT_SERDES_ATTR_RX_POLARITY,
 
+    /**
+     * @brief Total number of RX FFE taps supported
+     *
+     * @type sai_uint32_t
+     * @flags READ_ONLY
+     */
+    SAI_PORT_SERDES_ATTR_RX_FFE_COUNT,
+
+    /**
+     * @brief Total number of TX FIR taps supported
+     *
+     * @type sai_uint32_t
+     * @flags READ_ONLY
+     */
+    SAI_PORT_SERDES_ATTR_TX_FIR_COUNT,
+
+    /**
+     * @brief Total number of RX DFE taps supported
+     *
+     * @type sai_uint32_t
+     * @flags READ_ONLY
+     */
+    SAI_PORT_SERDES_ATTR_RX_DFE_COUNT,
+
+    /**
+     * @brief Port serdes RX FFE taps
+     *
+     * List of port serdes RX FFE tap values
+     *
+     * @type sai_taps_list_t
+     * @flags CREATE_AND_SET
+     * @default internal
+     */
+    SAI_PORT_SERDES_ATTR_RX_FFE_TAPS_LIST,
+
+    /**
+     * @brief Port serdes TX FIR taps
+     *
+     * List of port serdes TX FIR tap values
+     *
+     * @type sai_taps_list_t
+     * @flags CREATE_AND_SET
+     * @default internal
+     */
+    SAI_PORT_SERDES_ATTR_TX_FIR_TAPS_LIST,
+
+    /**
+     * @brief Port serdes DFE taps
+     *
+     * List of port serdes RX DFE tap values
+     *
+     * @type sai_taps_list_t
+     * @flags CREATE_AND_SET
+     * @default internal
+     */
+    SAI_PORT_SERDES_ATTR_RX_DFE_TAPS_LIST,
+
+    /**
+     * @brief Port serdes VGA settings
+     *
+     * List of port serdes VGA settings values
+     * The values are of type sai_u32_list_t where the count is number of lanes
+     * in a port and the list specifies list of VGA settings for each lane.
+     *
+     * @type sai_u32_list_t
+     * @flags CREATE_AND_SET
+     * @default internal
+     */
+    SAI_PORT_SERDES_ATTR_RX_VGA,
+
     /**
      * @brief End of attributes
      */

inc/saitypes.h

@@ -392,6 +392,18 @@ typedef struct _sai_vlan_list_t
 
 } sai_vlan_list_t;
 
+/**
+ * @brief Defines a list of FIR/FFE/DFE taps
+ */
+typedef struct _sai_taps_list_t
+{
+    /** Number of taps */
+    uint32_t count;
+
+    /** List of tap values */
+    sai_s32_list_t *list;
+} sai_taps_list_t;
+
 typedef enum _sai_ip_addr_family_t
 {
     SAI_IP_ADDR_FAMILY_IPV4,
@@ -1696,6 +1708,9 @@ typedef union _sai_attribute_value_t
 
     /** @validonly meta->attrvaluetype == SAI_ATTR_VALUE_TYPE_PORT_PAM4_EYE_VALUES_LIST */
     sai_port_pam4_eye_values_list_t portpam4eyevalues;
+
+    /** @validonly meta->attrvaluetype == SAI_ATTR_VALUE_TYPE_TAPS_LIST */
+    sai_taps_list_t portserdestaps;
 } sai_attribute_value_t;
 
 /**

meta/acronyms.txt

@@ -27,6 +27,7 @@ CMIS - Common Management Interface Specification
 CPLD - Complex programmable logic device
 CPU - Central Processing Unit
 CRC - Cyclic Redundancy Code
+DFE - Decision Feedback Equalizer
 DHCP - Dynamic Host Configuration Protocol
 DHCPV6 - Dynamic Host Configuration Protocol for IPv6
 DLD - Dead Lock Detection
@@ -54,6 +55,8 @@ FCS - Frame Check Sequence
 FD - File Descriptor
 FDB - Forwarding Data Base
 FEC - Forward Error Correction
+FFE - Feedforward Equalizer
+FIR - Finite Impulse Response
 FPGA - Field Programmable Gate Array
 FW  - Firmware
 GCM - Galois Counter Mode
@@ -173,6 +176,7 @@ UDP - User Datagram Protocol
 USD - Ultimate Segment Decapsulation
 USP - Ultimate Segment Pop
 USXGMII - Universal Serial 10 Gigabit Media Independent Interface
+VGA - Variable Gain Amplifier
 VNET - Virtual Network
 VNI - Virtual Network Interface
 VNID - Virtual Network Identifier

meta/saimetadatatypes.h

@@ -500,6 +500,11 @@ typedef enum _sai_attr_value_type_t
      * @brief Attribute value is port PAM4 eye values list.
      */
     SAI_ATTR_VALUE_TYPE_PORT_PAM4_EYE_VALUES_LIST,
+
+    /**
+     * @brief Attribute value is port SerDes tap values list.
+     */
+    SAI_ATTR_VALUE_TYPE_TAPS_LIST
 } sai_attr_value_type_t;
 
 /**

meta/saisanitycheck.c

@@ -848,6 +848,7 @@ void check_attr_object_type_provided(
         case SAI_ATTR_VALUE_TYPE_IP_PREFIX_LIST:
         case SAI_ATTR_VALUE_TYPE_ACL_CHAIN_LIST:
         case SAI_ATTR_VALUE_TYPE_POE_PORT_POWER_CONSUMPTION:
+        case SAI_ATTR_VALUE_TYPE_TAPS_LIST:
 
             if (md->allowedobjecttypes != NULL)
             {
@@ -1113,6 +1114,7 @@ void check_attr_default_required(
         case SAI_ATTR_VALUE_TYPE_SYSTEM_PORT_CONFIG_LIST:
         case SAI_ATTR_VALUE_TYPE_IP_PREFIX_LIST:
         case SAI_ATTR_VALUE_TYPE_ACL_CHAIN_LIST:
+        case SAI_ATTR_VALUE_TYPE_TAPS_LIST:
 
             if (((md->objecttype == SAI_OBJECT_TYPE_PORT) || (md->objecttype == SAI_OBJECT_TYPE_PORT_SERDES))
                  && md->defaultvaluetype == SAI_DEFAULT_VALUE_TYPE_SWITCH_INTERNAL)
@@ -2978,6 +2980,7 @@ void check_attr_is_primitive(
         case SAI_ATTR_VALUE_TYPE_JSON:
         case SAI_ATTR_VALUE_TYPE_IP_PREFIX_LIST:
         case SAI_ATTR_VALUE_TYPE_ACL_CHAIN_LIST:
+        case SAI_ATTR_VALUE_TYPE_TAPS_LIST:
 
             if (md->isprimitive)
             {
@@ -6318,6 +6321,7 @@ void check_struct_and_union_size()
     CHECK_STRUCT_SIZE(sai_u32_range_t, 8);
     CHECK_STRUCT_SIZE(sai_u8_list_t, 16);
     CHECK_STRUCT_SIZE(sai_vlan_list_t, 16);
+    CHECK_STRUCT_SIZE(sai_taps_list_t, 16)
 }
 #pragma GCC diagnostic pop