Fix Arista failures in telemetry_interface_last_change_test (gNMI-1.25)

Add subinterface_0_state_unsupported deviation for Arista as
state telemetry is not populated on the default (index 0) subinterface
(both LAG and Ethernet). The deviation is defined broadly to cover
any unsupported state on subinterface 0, but in this PR it is used
specifically to skip last-change validation while parent interface
validation continues.

Fix LAGMemberFlap and OTGLAGFlap timeout by expecting
LOWER_LAYER_DOWN oper-status on Arista when the LAG goes down due
to member port disable or link loss. The oper-status remains
DOWN when LAG itself is shutdown.

Author: smharis-arista

feature/interface/otg_tests/telemetry_interface_last_change_test/metadata.textproto

@@ -20,5 +20,6 @@ platform_exceptions: {
   deviations: {
     interface_enabled: true
     fr_breakout_fix: true
+    subinterface_0_state_unsupported: true
   }
 }

feature/interface/otg_tests/telemetry_interface_last_change_test/telemetry_interface_last_change_test.go

@@ -156,15 +156,19 @@ func performLAGFlapTest(t *testing.T, dut *ondatra.DUTDevice, aggID string, dutA
 	gnmi.Await(t, dut, aggIntfPath.OperStatus().State(), awaitTimeout, oc.Interface_OperStatus_UP)
 
 	// Get initial last-change values when the interface is UP.
+	skipSubintf := deviations.Subinterface0StateUnsupported(dut)
 	initialIntfLCVal, present := gnmi.Lookup(t, dut, aggIntfPath.LastChange().State()).Val()
 	if !present {
 		t.Fatalf("[%s] Failed to lookup initial LastChange for interface %s", testName, aggID)
 	}
-	initialSubintfLCVal, present := gnmi.Lookup(t, dut, aggIntfPath.Subinterface(0).LastChange().State()).Val()
-	if !present {
-		t.Fatalf("[%s] Failed to lookup initial LastChange for subinterface %s:0", testName, aggID)
+	var initialSubintfLCVal uint64
+	if !skipSubintf {
+		initialSubintfLCVal, present = gnmi.Lookup(t, dut, aggIntfPath.Subinterface(0).LastChange().State()).Val()
+		if !present {
+			t.Fatalf("[%s] Failed to lookup initial LastChange for subinterface %s:0", testName, aggID)
+		}
+		t.Logf("[%s] Initial LastChange values: Interface %s: %d, Subinterface %s:0: %d", testName, aggID, initialIntfLCVal, aggID, initialSubintfLCVal)
 	}
-	t.Logf("[%s] Initial LastChange values: Interface %s: %d, Subinterface %s:0: %d", testName, aggID, initialIntfLCVal, aggID, initialSubintfLCVal)
 
 	prevIntfLC := initialIntfLCVal
 	prevSubintfLC := initialSubintfLCVal
@@ -181,6 +185,9 @@ func performLAGFlapTest(t *testing.T, dut *ondatra.DUTDevice, aggID string, dutA
 			if dut.Vendor() == ondatra.JUNIPER {
 				targetOperStatus = oc.Interface_OperStatus_LOWER_LAYER_DOWN
 			}
+			if dut.Vendor() == ondatra.ARISTA && (testName == "LAGMemberFlap" || testName == "OTGLAGFlap") {
+				targetOperStatus = oc.Interface_OperStatus_LOWER_LAYER_DOWN
+			}
 		} else { // In even-numbered iterations, enable the interface.
 			action = "Enable"
 			enabledState = true
@@ -200,20 +207,20 @@ func performLAGFlapTest(t *testing.T, dut *ondatra.DUTDevice, aggID string, dutA
 			t.Errorf("[%s] Failed to lookup LastChange for interface %s after %s (state change %d)", testName, aggID, action, i)
 			continue
 		}
-		currentSubintfLCVal, present := gnmi.Lookup(t, dut, aggIntfPath.Subinterface(0).LastChange().State()).Val()
-		if !present {
-			t.Errorf("[%s] Failed to lookup LastChange for subinterface %s:0 after %s (state change %d)", testName, aggID, action, i)
-			continue
-		}
-		t.Logf("[%s] LastChange values after %s: Interface %s: %d, Subinterface %s:0: %d", testName, action, aggID, currentIntfLCVal, aggID, currentSubintfLCVal)
-
-		// Verify that last-change increased for both the LAG interface and its subinterface.
+		// Verify that last-change increased for the LAG interface.
 		validateLastChangeIncrease(t, fmt.Sprintf("%s after %s (state change %d)", testName, action, i), aggID, prevIntfLC, currentIntfLCVal)
-		validateLastChangeIncrease(t, fmt.Sprintf("%s after %s (state change %d)", testName, action, i), fmt.Sprintf("%s:%d", aggID, 0), prevSubintfLC, currentSubintfLCVal)
-
-		// Store current timestamps for comparison in the next iteration.
 		prevIntfLC = currentIntfLCVal
-		prevSubintfLC = currentSubintfLCVal
+
+		if !skipSubintf {
+			currentSubintfLCVal, present := gnmi.Lookup(t, dut, aggIntfPath.Subinterface(0).LastChange().State()).Val()
+			if !present {
+				t.Errorf("[%s] Failed to lookup LastChange for subinterface %s:0 after %s (state change %d)", testName, aggID, action, i)
+				continue
+			}
+			t.Logf("[%s] LastChange values after %s: Interface %s: %d, Subinterface %s:0: %d", testName, action, aggID, currentIntfLCVal, aggID, currentSubintfLCVal)
+			validateLastChangeIncrease(t, fmt.Sprintf("%s after %s (state change %d)", testName, action, i), fmt.Sprintf("%s:%d", aggID, 0), prevSubintfLC, currentSubintfLCVal)
+			prevSubintfLC = currentSubintfLCVal
+		}
 	}
 }
 
@@ -341,15 +348,19 @@ func TestEthernetInterfaceLastChangeState(t *testing.T) {
 		gnmi.Await(t, dut, intfPath.OperStatus().State(), awaitTimeout, oc.Interface_OperStatus_UP)
 
 		// Get initial last-change values when the interface is UP.
+		skipSubintf := deviations.Subinterface0StateUnsupported(dut)
 		initialIntfLCVal, present := gnmi.Lookup(t, dut, intfPath.LastChange().State()).Val()
 		if !present {
 			t.Fatalf("[%s] Failed to lookup initial LastChange for interface %s", testName, port.Name())
 		}
-		initialSubintfLCVal, present := gnmi.Lookup(t, dut, intfPath.Subinterface(0).LastChange().State()).Val()
-		if !present {
-			t.Fatalf("[%s] Failed to lookup initial LastChange for subinterface %s:0", testName, port.Name())
+		var initialSubintfLCVal uint64
+		if !skipSubintf {
+			initialSubintfLCVal, present = gnmi.Lookup(t, dut, intfPath.Subinterface(0).LastChange().State()).Val()
+			if !present {
+				t.Fatalf("[%s] Failed to lookup initial LastChange for subinterface %s:0", testName, port.Name())
+			}
+			t.Logf("[%s] Initial LastChange values: Interface %s: %d, Subinterface %s:0: %d", testName, port.Name(), initialIntfLCVal, port.Name(), initialSubintfLCVal)
 		}
-		t.Logf("[%s] Initial LastChange values: Interface %s: %d, Subinterface %s:0: %d", testName, port.Name(), initialIntfLCVal, port.Name(), initialSubintfLCVal)
 
 		prevIntfLC := initialIntfLCVal
 		prevSubintfLC := initialSubintfLCVal
@@ -382,29 +393,28 @@ func TestEthernetInterfaceLastChangeState(t *testing.T) {
 				t.Errorf("[%s] Failed to lookup LastChange for interface %s after %s (state change %d)", testName, port.Name(), action, i)
 				continue
 			}
-			currentSubintfLCVal, present := gnmi.Lookup(t, dut, intfPath.Subinterface(0).LastChange().State()).Val()
-			if !present {
-				t.Errorf("[%s] Failed to lookup LastChange for subinterface %s:0 after %s (state change %d)", testName, port.Name(), action, i)
-				continue
-			}
-
-			// Verify that last-change increased.
-			subIntfName := fmt.Sprintf("%s:%d", port.Name(), 0)
+			// Verify that last-change increased for the interface.
 			if currentIntfLCVal <= prevIntfLC {
 				t.Errorf("[%s] State Change %d (%s): Interface %s LastChange timestamp did not increase, initial: %d, final: %d", testName, i, action, port.Name(), prevIntfLC, currentIntfLCVal)
 			} else {
 				t.Logf("[%s] State Change %d (%s): Interface %s LastChange timestamp increased as expected, initial: %d, final: %d", testName, i, action, port.Name(), prevIntfLC, currentIntfLCVal)
 			}
+			prevIntfLC = currentIntfLCVal
 
-			if currentSubintfLCVal <= prevSubintfLC {
-				t.Errorf("[%s] State Change %d (%s): Subinterface %s LastChange timestamp did not increase, initial: %d, final: %d", testName, i, action, subIntfName, prevSubintfLC, currentSubintfLCVal)
-			} else {
-				t.Logf("[%s] State Change %d (%s): Subinterface %s LastChange timestamp increased as expected, initial: %d, final: %d", testName, i, action, subIntfName, prevSubintfLC, currentSubintfLCVal)
+			if !skipSubintf {
+				currentSubintfLCVal, present := gnmi.Lookup(t, dut, intfPath.Subinterface(0).LastChange().State()).Val()
+				if !present {
+					t.Errorf("[%s] Failed to lookup LastChange for subinterface %s:0 after %s (state change %d)", testName, port.Name(), action, i)
+					continue
+				}
+				subIntfName := fmt.Sprintf("%s:%d", port.Name(), 0)
+				if currentSubintfLCVal <= prevSubintfLC {
+					t.Errorf("[%s] State Change %d (%s): Subinterface %s LastChange timestamp did not increase, initial: %d, final: %d", testName, i, action, subIntfName, prevSubintfLC, currentSubintfLCVal)
+				} else {
+					t.Logf("[%s] State Change %d (%s): Subinterface %s LastChange timestamp increased as expected, initial: %d, final: %d", testName, i, action, subIntfName, prevSubintfLC, currentSubintfLCVal)
+				}
+				prevSubintfLC = currentSubintfLCVal
 			}
-
-			// Store current timestamps for the next iteration's comparison.
-			prevIntfLC = currentIntfLCVal
-			prevSubintfLC = currentSubintfLCVal
 		}
 	}
 

internal/deviations/deviations.go

@@ -2042,3 +2042,9 @@ func AcctzRecordsAuthzStatusDenyUnsupported(dut *ondatra.DUTDevice) bool {
 func FpgaFt(dut *ondatra.DUTDevice) string {
 	return lookupDUTDeviations(dut).GetFpgaFt()
 }
+
+// Subinterface0StateUnsupported returns true if the device does not populate
+// state on subinterface 0 that is implicitly created.
+func Subinterface0StateUnsupported(dut *ondatra.DUTDevice) bool {
+	return lookupDUTDeviations(dut).GetSubinterface_0StateUnsupported()
+}

proto/metadata.proto

@@ -1231,6 +1231,11 @@ message Metadata {
     // Cisco: https://partnerissuetracker.corp.google.com/issues/429156503
     string fpga_ft = 398;
 
+    // Device does not populate state on subinterface 0
+    // that is implicitly created.
+    // Arista: https://partnerissuetracker.corp.google.com/issues/456175792
+    bool subinterface_0_state_unsupported = 399;
+
     // Reserved field numbers and identifiers.
     reserved 84, 9, 28, 20, 38, 43, 90, 97, 55, 89, 19, 36, 35, 40, 113, 131, 141, 173, 234, 254, 231, 300, 241;
   }