Skip to content

Commit cde5228

Browse files
Updated based on feedback from repo owner
* updated user guide to communicate the default value of to 0 * fixed ordering of comment * made BufferSize a uint to default to 0 if not set
1 parent dbfa73d commit cde5228

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

docs/user_guide/outputs/jetstream_output.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,11 @@ outputs:
122122
write-timeout: 5s
123123
# boolean, enables extra logging for the nats output
124124
debug: false
125-
# boolean, enables the collection and export (via prometheus) of output specific metrics
126125
# integer, sets the size of the local buffer where received
127126
# NATS messages are stored before being sent to outputs.
128-
# This value is set per worker. Defaults to 100 messages
129-
buffer-size: 100
127+
# This value is set per worker. Defaults to 0 messages
128+
buffer-size: 0
129+
# boolean, enables the collection and export (via prometheus) of output specific metrics
130130
enable-metrics: false
131131
# list of processors to apply to the message before writing
132132
event-processors:

docs/user_guide/outputs/nats_output.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,11 @@ outputs:
7272
write-timeout: 5s
7373
# boolean, enables extra logging for the nats output
7474
debug: false
75-
# boolean, enables the collection and export (via prometheus) of output specific metrics
7675
# integer, sets the size of the local buffer where received
7776
# NATS messages are stored before being sent to outputs.
78-
# This value is set per worker. Defaults to 100 messages
79-
buffer-size: 100
77+
# This value is set per worker. Defaults to 0 messages
78+
buffer-size: 0
79+
# boolean, enables the collection and export (via prometheus) of output specific metrics
8080
enable-metrics: false
8181
# list of processors to apply on the message before writing
8282
event-processors:

pkg/outputs/nats_outputs/jetstream/jetstream_output.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ type config struct {
8787
NumWorkers int `mapstructure:"num-workers,omitempty" json:"num-workers,omitempty"`
8888
WriteTimeout time.Duration `mapstructure:"write-timeout,omitempty" json:"write-timeout,omitempty"`
8989
Debug bool `mapstructure:"debug,omitempty" json:"debug,omitempty"`
90-
BufferSize int `mapstructure:"buffer-size,omitempty"`
90+
BufferSize uint `mapstructure:"buffer-size,omitempty"`
9191
EnableMetrics bool `mapstructure:"enable-metrics,omitempty" json:"enable-metrics,omitempty"`
9292
EventProcessors []string `mapstructure:"event-processors,omitempty" json:"event-processors,omitempty"`
9393
}

pkg/outputs/nats_outputs/nats/nats_output.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ type Config struct {
8787
NumWorkers int `mapstructure:"num-workers,omitempty"`
8888
WriteTimeout time.Duration `mapstructure:"write-timeout,omitempty"`
8989
Debug bool `mapstructure:"debug,omitempty"`
90-
BufferSize int `mapstructure:"buffer-size,omitempty"`
90+
BufferSize uint `mapstructure:"buffer-size,omitempty"`
9191
EnableMetrics bool `mapstructure:"enable-metrics,omitempty"`
9292
EventProcessors []string `mapstructure:"event-processors,omitempty"`
9393
}

0 commit comments

Comments
 (0)