containerz: UpdateContainerRequest contains duplicate params?

[LimeHat]

UpdateContainerRequest contains image_name and image_tag fields in the body of the request:

gnoi/containerz/containerz.proto

Lines 567 to 581 in 1cc12cd

	message UpdateContainerRequest {
	// The name of the running container to update.
	string instance_name = 1;
	// The image and tag to update the container to.
	string image_name = 2;
	string image_tag = 3;
	// The set of parameters to run the container with.
	StartContainerRequest params = 4;
	// Run this operation asynchronously or not.
	bool async = 5;
	}

But the same parameters are included in the StartContainerRequest message, which is also part of the UpdateContainerRequest message

gnoi/containerz/containerz.proto

Lines 391 to 396 in 1cc12cd

	message StartContainerRequest {
	// The name and tag of the container to start.
	string image_name = 1;
	string tag = 2;
	string cmd = 3;

Could you please clarify how is this supposed to be used? Can we deprecate one of the sets (name+tag)?

@alshabib @robshakir

[alshabib]

They are both useful:

• The StartContainer one indicates to Containerz which image:tag to start a container on
• The UpdateContainer one indicates what image:tag to update the image to.

Does this help clarify?

[LimeHat]

Sorry, I'm not following..
IMO in either case it will be translated into a single docker run cmd (or equivalent). Can you provide an example how/where a second tag can be used with Docker syntax?

[LimeHat]

Just to clarify further, I don't question the standalone StartContainer RPC. All I'm saying is that in UpdateContainerRequest an image:tag combination can be included twice (because the update request already includes the StartContainerRequest, and then adds more fields.. which appear to be redundant)

[alshabib]

Oh I see - I think image:tag in update container is the one to honour. The start container in the update container request is just to pass start parameters to containerz.

[LimeHat]

Ok. Just to confirm, would it be fair to say that

• image_name and image_tag at the top level of UpdateContainerRequest are mandatory.
• we can silently ignore image_name and tag in the embedded StartContainerRequest when executing UpdateContainer RPC?

[alshabib]

Yes that is correct