From 83deb1427f09518d0b989650e791c49dc8ec4fc8 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Thu, 16 Jan 2025 01:10:26 +0100 Subject: [PATCH 1/5] fix minor linting issues in tests Just to please the linters; verifiers_test.go:28:11: Error return value of `rand.Read` is not checked (errcheck) rand.Read(p) ^ verifiers_test.go:33:9: Error return value of `io.Copy` is not checked (errcheck) io.Copy(verifier, bytes.NewReader(p)) ^ Signed-off-by: Sebastiaan van Stijn --- verifiers_test.go | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/verifiers_test.go b/verifiers_test.go index 0e35115..ae181d6 100644 --- a/verifiers_test.go +++ b/verifiers_test.go @@ -25,12 +25,18 @@ import ( func TestDigestVerifier(t *testing.T) { p := make([]byte, 1<<20) - rand.Read(p) + _, err := rand.Read(p) + if err != nil { + t.Fatal(err) + } digest := FromBytes(p) verifier := digest.Verifier() - io.Copy(verifier, bytes.NewReader(p)) + _, err = io.Copy(verifier, bytes.NewReader(p)) + if err != nil { + t.Fatal(err) + } if !verifier.Verified() { t.Fatalf("bytes not verified") From 1927f8e90ee94596f6d9775d64b492ebbf426812 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Thu, 16 Jan 2025 01:19:24 +0100 Subject: [PATCH 2/5] gha: set default permission to read Signed-off-by: Sebastiaan van Stijn --- .github/workflows/test.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index bf71ee6..ffeb555 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,5 +1,9 @@ -on: [push, pull_request] name: Test +on: [push, pull_request] + +permissions: + contents: read + jobs: test: strategy: From be77b89d6beddb9e6379399860f75fd5e6c9370e Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Thu, 23 Apr 2026 10:01:50 +0200 Subject: [PATCH 3/5] gha: set GOTOOLCHAIN=local Prevent implicit upgrades of Go Signed-off-by: Sebastiaan van Stijn --- .github/workflows/test.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ffeb555..72ffa48 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -11,6 +11,8 @@ jobs: go-version: [1.18.x, 1.19.x, 1.20.x, 1.21.x, 1.22.x] platform: [ubuntu-latest, windows-latest] runs-on: ${{ matrix.platform }} + env: + GOTOOLCHAIN: local steps: - name: Install Go uses: actions/setup-go@v6 From 488466d27df1e7fe0cb39ee3c222b9875eab4739 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Thu, 23 Apr 2026 09:53:58 +0200 Subject: [PATCH 4/5] gha: add go1.23 - go1.26 Signed-off-by: Sebastiaan van Stijn --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 72ffa48..866f908 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -8,7 +8,7 @@ jobs: test: strategy: matrix: - go-version: [1.18.x, 1.19.x, 1.20.x, 1.21.x, 1.22.x] + go-version: [1.18.x, 1.19.x, 1.20.x, 1.21.x, 1.22.x, 1.23.x, 1.24.x, 1.25.x, 1.26.x] platform: [ubuntu-latest, windows-latest] runs-on: ${{ matrix.platform }} env: From d7ab6995961d77ca91f15f4a93ce333ddc44ef7d Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Thu, 16 Jan 2025 01:21:17 +0100 Subject: [PATCH 5/5] gha: add golangci-lint Signed-off-by: Sebastiaan van Stijn --- .github/workflows/test.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 866f908..091ea59 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -22,6 +22,14 @@ jobs: uses: actions/checkout@v6 - name: Test run: go test -v ./... + - name: Lint + uses: golangci/golangci-lint-action@v9 + with: + version: v2.11 - name: Test Blake3 run: go test -v ./... working-directory: blake3 + - name: Lint Blake3 + uses: golangci/golangci-lint-action@v9 + with: + version: v2.11