go-selinux: move to internal/impl

This moves (git mv) the whole package to under internal, with the
minimal changes:
 - package name;
 - remove the deprecated ReserveLabel;
 - remove the deprecated notice from ContainerLabels (it will stay as
   internal function).

This commit breaks git-bisect; this is done deliberately to show this is
merely the moving files around. The next commit fixes things.

Technically, we can also remove the wrappers and instead make the actual
implementation methods public, but there is no need.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

Author: kolyshkin

.codespellrc

@@ -1,2 +1,2 @@
 [codespell]
-skip = ./.git,./go.sum,./go-selinux/testdata
+skip = ./.git,./go.sum,,./internal/impl/testdata

.github/workflows/validate.yml

@@ -147,7 +147,7 @@ jobs:
       # https://github.com/opencontainers/selinux/issues/225
       - name: "racy test"
         continue-on-error: true
-        run: lima bash -c 'cd /tmp/selinux && go test -timeout 10m -count 100000 ./go-selinux'
+        run: lima bash -c 'cd /tmp/selinux && go test -timeout 10m -count 100000 ./internal/impl'
 
       - name: "Show AVC denials"
         run: lima sudo ausearch -m AVC,USER_AVC || true

go-selinux/selinux.go internal/impl/selinux.gogo-selinux/selinux.go renamed to internal/impl/selinux.go

@@ -1,4 +1,4 @@
-package selinux
+package impl
 
 import (
 	"errors"
@@ -224,15 +224,8 @@ func ClearLabels() {
 }
 
 // ReserveLabel reserves the MLS/MCS level component of the specified label.
-//
-// Deprecated: use [ReserveLabelV2] instead.
-func ReserveLabel(label string) {
-	_ = reserveLabel(label)
-}
-
-// ReserveLabelV2 reserves the MLS/MCS level component of the specified label.
 // Returns an error if the label can't be reserved.
-func ReserveLabelV2(label string) error {
+func ReserveLabel(label string) error {
 	return reserveLabel(label)
 }
 
@@ -308,9 +301,6 @@ func InitContainerLabel() (string, error) {
 
 // ContainerLabels returns an allocated processLabel and fileLabel to be used for
 // container labeling by the calling process.
-//
-// Deprecated: this (apparently) has no users and will be removed from the
-// future version of this package. Open a bug report if you use it.
 func ContainerLabels() (processLabel string, fileLabel string) {
 	return containerLabels()
 }

go-selinux/selinux_linux.go internal/impl/selinux_linux.gogo-selinux/selinux_linux.go renamed to internal/impl/selinux_linux.go

@@ -1,4 +1,4 @@
-package selinux
+package impl
 
 import (
 	"bufio"

go-selinux/selinux_linux_test.go internal/impl/selinux_linux_test.gogo-selinux/selinux_linux_test.go renamed to internal/impl/selinux_linux_test.go

@@ -1,4 +1,4 @@
-package selinux
+package impl
 
 import (
 	"bufio"

go-selinux/selinux_stub.go internal/impl/selinux_stub.gogo-selinux/selinux_stub.go renamed to internal/impl/selinux_stub.go

@@ -1,6 +1,6 @@
 //go:build !linux
 
-package selinux
+package impl
 
 func readConThreadSelf(string) (string, error) {
 	return "", nil

go-selinux/selinux_stub_test.go internal/impl/selinux_stub_test.gogo-selinux/selinux_stub_test.go renamed to internal/impl/selinux_stub_test.go

@@ -1,6 +1,6 @@
 //go:build !linux
 
-package selinux
+package impl
 
 import (
 	"testing"
@@ -46,7 +46,9 @@ func TestSELinuxStubs(t *testing.T) {
 
 	ClearLabels()
 
-	ReserveLabel(testLabel)
+	if err := ReserveLabel(testLabel); err != nil {
+		t.Error(err)
+	}
 	ReleaseLabel(testLabel)
 	if _, err := DupSecOpt(testLabel); err != nil {
 		t.Error(err)

go-selinux/xattrs_linux.go internal/impl/xattrs_linux.gogo-selinux/xattrs_linux.go renamed to internal/impl/xattrs_linux.go

@@ -1,4 +1,4 @@
-package selinux
+package impl
 
 import (
 	"golang.org/x/sys/unix"