Skip to content

Commit 77952b9

Browse files
committed
fix: Use real kibana secret from github
1 parent 9b25f26 commit 77952b9

File tree

8 files changed

+49
-27
lines changed

8 files changed

+49
-27
lines changed

.github/TEMPLATES/secret-mapping-deps.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@ postgres-admin-user:
2525
- POSTGRES_USER
2626
- POSTGRES_PASSWORD
2727

28+
kibana-users-secret:
29+
- KIBANA_USERNAME
30+
- KIBANA_PASSWORD
2831

2932
# REPLICAS
3033

.github/workflows/github-to-k8s-sync-env.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ jobs:
6161
6262
# Iterate over all kubernetes secret names in mapping
6363
for secret_name in $(yq e 'keys | .[]' "$mapping_file"); do
64+
skip_manifest=false
6465
echo "🔧 Generating Secret: $secret_name"
6566
6667
{
@@ -92,9 +93,14 @@ jobs:
9293
else
9394
echo "⚠️ Warning: $github_var not found in env_file → setting $k8s_var as empty" >&2
9495
echo " $k8s_var: ''"
96+
skip_manifest=true
9597
fi
9698
done
9799
} > "k8s-secrets/$secret_name.yaml"
100+
if [ "$skip_manifest" = true ]; then
101+
echo "⚠️ Skipping $secret_name manifest due to missing variables"
102+
rm -f "k8s-secrets/$secret_name.yaml"
103+
fi
98104
done
99105
100106
echo "✅ Generated manifests:"

charts/dependencies/templates/kibana-encryption-secret.yaml

Lines changed: 0 additions & 12 deletions
This file was deleted.
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
{{- if .Values.monitoring.enabled }}
2+
{{- $encryption_secret_name := "kibana-encryption-secret" }}
3+
{{- $encryption_secret := lookup "v1" "Secret" .Release.Namespace $encryption_secret_name }}
4+
{{- if not $encryption_secret }}
5+
---
6+
apiVersion: v1
7+
kind: Secret
8+
metadata:
9+
name: {{ $encryption_secret_name }}
10+
annotations:
11+
"helm.sh/resource-policy": keep
12+
stringData:
13+
KIBANA_ENCRYPTION_KEY: {{ .Values.encryptionKey | default (randAlphaNum 32) }}
14+
{{- end }}
15+
16+
{{- $user_secret := lookup "v1" "Secret" .Release.Namespace .Values.kibana.users_secret }}
17+
{{- if not $user_secret }}
18+
---
19+
apiVersion: v1
20+
kind: Secret
21+
metadata:
22+
name: {{ .Values.kibana.users_secret }}
23+
annotations:
24+
"helm.sh/resource-policy": keep
25+
stringData:
26+
KIBANA_USERNAME: {{ randAlphaNum 12 | lower }}
27+
KIBANA_PASSWORD: {{ randAlphaNum 32 }}
28+
{{- end }}
29+
{{- end }}

charts/dependencies/templates/kibana.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,13 +70,13 @@ spec:
7070
- name: KIBANA_USERNAME
7171
valueFrom:
7272
secretKeyRef:
73-
name: {{ .Values.elasticsearch.users_secret }}
74-
key: KIBANA_USER_ELASTIC_USERNAME
73+
name: {{ .Values.kibana.users_secret }}
74+
key: KIBANA_USERNAME
7575
- name: KIBANA_PASSWORD
7676
valueFrom:
7777
secretKeyRef:
78-
name: {{ .Values.elasticsearch.users_secret }}
79-
key: KIBANA_USER_ELASTIC_PASSWORD
78+
name: {{ .Values.kibana.users_secret }}
79+
key: KIBANA_PASSWORD
8080
- name: METRICBEAT_ELASTIC_USERNAME
8181
valueFrom:
8282
secretKeyRef:

charts/dependencies/templates/metricbeat.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,13 @@ spec:
6262
- name: KIBANA_USERNAME
6363
valueFrom:
6464
secretKeyRef:
65-
name: elasticsearch-opencrvs-users
66-
key: KIBANA_USER_ELASTIC_USERNAME
65+
name: {{ .Values.kibana.users_secret }}
66+
key: KIBANA_USERNAME
6767
- name: KIBANA_PASSWORD
6868
valueFrom:
6969
secretKeyRef:
70-
name: elasticsearch-opencrvs-users
71-
key: KIBANA_USER_ELASTIC_PASSWORD
70+
name: {{ .Values.kibana.users_secret }}
71+
key: KIBANA_PASSWORD
7272
- name: BEATS_USERNAME
7373
valueFrom:
7474
secretKeyRef:

charts/dependencies/templates/minio-secrets.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,6 @@
66
{{- if not $secret }}
77
{{- $username := randAlphaNum 16 }}
88
{{- $password := randAlphaNum 32 }}
9-
{{- if $.Values.chart_dev_mode }}
10-
{{- $username = "minioadmin" }}
11-
{{- $password = "miniopassword" }}
12-
{{- end }}
139
---
1410
apiVersion: v1
1511
kind: Secret

charts/dependencies/values.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ elasticsearch:
5252
admin_user_secret_name: elasticsearch-admin-user
5353
auth_mode: auto
5454
auth_users:
55-
- KIBANA_USER
5655
- KIBANA_SYSTEM:kibana_system
5756
- METRICBEAT:beats_system
5857
- APM:apm_system
@@ -75,7 +74,8 @@ elasticsearch:
7574
monitoring:
7675
enabled: false
7776

78-
kibana: {}
77+
kibana:
78+
users_secret: kibana-users-secret
7979
metricbeat:
8080
dashboards:
8181
- kubernetes-e0195ce0-bcaf-11ec-b64f-7dd6e8e82013
@@ -163,7 +163,7 @@ restore:
163163
backup_server_secret: backup-server-ssh-credentials
164164
# backup_server_dir: /home/backup/demo
165165
backup_encryption_secret: restore-encryption-secret
166-
166+
167167
env: {}
168168
# Priority class for datastore pods to avoid eviction
169169
priority_class:

0 commit comments

Comments
 (0)