clean up

Author: Nil20

packages/commons/src/events/EventConfig.ts

@@ -134,6 +134,9 @@ export const EventConfig = z
       }
     }
 
+    const isInherentFlag = (value: unknown): value is InherentFlags =>
+      Object.values(InherentFlags).includes(value as InherentFlags)
+
     // Validate that all referenced action flags are configured in the event flags array.
     const configuredFlagIds = event.flags.map((flag) => flag.id)
     const actionFlagIds = event.actions.flatMap((action) =>
@@ -142,10 +145,7 @@ export const EventConfig = z
 
     for (const actionFlagId of actionFlagIds) {
       const isConfigured = configuredFlagIds.includes(actionFlagId)
-      const isInherent = Object.values(InherentFlags).includes(
-        // @ts-expect-error - actionFlagId can be a inherent flag or any string
-        actionFlagId
-      )
+      const isInherent = isInherentFlag(actionFlagId)
 
       if (!isConfigured && !isInherent) {
         ctx.addIssue({

packages/commons/src/scopes.ts

@@ -328,7 +328,7 @@ const ConfigurableRawScopes = z.discriminatedUnion('type', [
 ])
 
 export const ConfigurableActionScopes = z.discriminatedUnion('type', [
-  // @TODO - Configure actual action scopes
+  // @TODO - Record scope holds non-action scopes as well e.g., `record.read`
   RecordScope,
   CustomActionScope
 ])