Merge pull request #627 from jembi/ocrvs-1316-required-last-name-en

Ocrvs 1316 Person english last names made required - release

Author: rcrichton

packages/register/src/forms/register/fieldDefinitions/birth/child-section.ts

@@ -279,7 +279,7 @@ export const childSection: IFormSection = {
       name: 'familyNameEng',
       type: TEXT,
       label: messages.childFamilyNameEng,
-      required: false,
+      required: true,
       initialValue: '',
       validate: [englishOnlyNameFormat],
       mapping: {

packages/register/src/forms/register/fieldDefinitions/birth/father-section.ts

@@ -279,7 +279,7 @@ export const fatherSection: IFormSection = {
       name: 'familyNameEng',
       type: TEXT,
       label: messages.fatherFamilyNameEng,
-      required: false,
+      required: true,
       initialValue: '',
       validate: [englishOnlyNameFormat],
       conditionals: [conditionals.fathersDetailsExist],

packages/register/src/forms/register/fieldDefinitions/birth/mother-section.ts

@@ -237,7 +237,7 @@ export const motherSection: IFormSection = {
       name: 'familyNameEng',
       type: TEXT,
       label: messages.motherFamilyNameEng,
-      required: false,
+      required: true,
       initialValue: '',
       validate: [englishOnlyNameFormat],
       mapping: {

packages/register/src/forms/register/fieldDefinitions/death/application-section.ts

@@ -316,7 +316,7 @@ export const applicantsSection: IFormSection = {
       name: 'applicantFamilyNameEng',
       type: TEXT,
       label: messages.applicantsFamilyNameEng,
-      required: false,
+      required: true,
       initialValue: '',
       validate: [englishOnlyNameFormat],
       mapping: {

packages/register/src/forms/register/fieldDefinitions/death/deceased-section.ts

@@ -332,7 +332,7 @@ export const deceasedSection: IFormSection = {
       name: 'familyNameEng',
       type: TEXT,
       label: messages.deceasedFamilyNameEng,
-      required: false,
+      required: true,
       initialValue: '',
       validate: [englishOnlyNameFormat],
       mapping: {

packages/register/src/tests/util.tsx

@@ -430,7 +430,7 @@ export const mockDeathApplicationData = {
     applicantFirstNames: '',
     applicantFamilyName: 'ইসলাম',
     applicantFirstNamesEng: 'Islam',
-    applicantFamilyNameEng: '',
+    applicantFamilyNameEng: 'Islam',
     nationality: 'BGD',
     applicantBirthDate: '',
     applicantsRelationToDeceased: 'MOTHER',
@@ -758,7 +758,7 @@ export const mockDeathApplicationDataWithoutFirstNames = {
     applicantFirstNames: '',
     applicantFamilyName: 'ইসলাম',
     applicantFirstNamesEng: 'Islam',
-    applicantFamilyNameEng: '',
+    applicantFamilyNameEng: 'Islam',
     nationality: 'BGD',
     applicantBirthDate: '',
     applicantsRelationToDeceased: 'MOTHER',

packages/register/src/views/PrintCertificate/PrintCertificateAction.test.tsx

@@ -76,7 +76,7 @@ describe('when user wants to print certificate', async () => {
                   {
                     use: 'en',
                     firstNames: '',
-                    familyName: '',
+                    familyName: 'Mashrur',
                     __typename: 'HumanName'
                   }
                 ],
@@ -551,7 +551,7 @@ describe('when user wants to print certificate', async () => {
                     {
                       use: 'en',
                       firstNames: '',
-                      familyName: '',
+                      familyName: 'Mashrur',
                       __typename: 'HumanName'
                     }
                   ],