fix: continue unassigning other declarations (#9660)

* fix: continue unassigning other declarations

One failing unassign was blocking all the other unassign actions
from continuing

* docs: update CHANGELOG

* chore: descriptive variable name

Author: Zangetsu101

CHANGELOG.md

@@ -15,6 +15,7 @@
 - Fix practitioner role history entries from being created with every view and download [#9462](https://github.com/opencrvs/opencrvs-core/issues/9462)
 - Fix a child's NID form field cannot be added eithe rmanually or via ESignet. A father section cannot be placed before a mother section if you wish to use a radio button to control mapping addresses from one individual to aother to make data entry easier [#9582](https://github.com/opencrvs/opencrvs-core/issues/9582)
 - Fix the role of the certifier unable to get resolved for new users which in turn caused the download of the declaration to fail [#9643](https://github.com/opencrvs/opencrvs-core/issues/9643)
+- Fix one failing unassign blocking all other unassign actions from continuing [#9651](https://github.com/opencrvs/opencrvs-core/issues/9651)
 
 ## [1.7.1](https://github.com/opencrvs/opencrvs-core/compare/v1.7.0...v1.7.1)
 

packages/client/src/declarations/index.ts

@@ -1886,7 +1886,12 @@ export const declarationsReducer: LoopReducer<IDeclarationsState, Action> = (
       )
     case UNASSIGN_DECLARATION_FAILED: {
       const error = action.payload.error
-      const declarationNextToUnassign = state.declarations.find(
+      /*
+       * The next declaration that's ready to be unassigned.
+       * We don't want to hold up the unassign queue because
+       * of one failed unassign action
+       */
+      const nextInUnassignQueue = state.declarations.find(
         (declaration) =>
           declaration.downloadStatus === DOWNLOAD_STATUS.READY_TO_UNASSIGN
       )
@@ -1906,10 +1911,10 @@ export const declarationsReducer: LoopReducer<IDeclarationsState, Action> = (
                 )
               ),
               Cmd.action(updateRegistrarWorkqueue()),
-              declarationNextToUnassign
+              nextInUnassignQueue
                 ? Cmd.action(
                     executeUnassignDeclaration(
-                      declarationNextToUnassign.id,
+                      nextInUnassignQueue.id,
                       action.payload.client,
                       action.payload.refetchQueries
                     )
@@ -1920,6 +1925,18 @@ export const declarationsReducer: LoopReducer<IDeclarationsState, Action> = (
           )
         )
       }
+      if (nextInUnassignQueue) {
+        return loop(
+          state,
+          Cmd.action(
+            executeUnassignDeclaration(
+              nextInUnassignQueue.id,
+              action.payload.client,
+              action.payload.refetchQueries
+            )
+          )
+        )
+      }
       return state
     }