Merge pull request #6504 from opencrvs/release-v1.4.1

Release v1.4.1

Author: euanmillar

.github/DISCUSSION_TEMPLATE/Installation.yml

@@ -21,14 +21,14 @@ body:
     id: core-version
     attributes:
       label: OpenCRVS Core version
-      description: e.g 1.4.0
+      description: e.g 1.4.1
     validations:
       required: true
   - type: input
     id: countryconfig-version
     attributes:
       label: OpenCRVS Countryconfig version
-      description: e.g 1.4.0
+      description: e.g 1.4.1
     validations:
       required: true
   - type: input

.github/workflows/lint-and-test.yml

@@ -40,8 +40,3 @@ jobs:
 
       - name: Run Unit Test
         run: yarn test
-
-      - name: Run code coverage
-        run: |
-          npm install codecov
-          ./node_modules/.bin/codecov

CHANGELOG CHANGELOG.mdCHANGELOG renamed to CHANGELOG.md

@@ -1,5 +1,21 @@
 # Changelog
 
+## [1.4.1](https://github.com/opencrvs/opencrvs-core/compare/v1.3.3...v1.4.1)
+
+- Fix Metabase versions in Dashboards service. Previously the version used for local development wasn't the one built into the docker image, which caused the locally generated initialisation file to fail in deployed environments.
+- Fix a seeding script bug, where it failed when done too quickly [#6553](https://github.com/opencrvs/opencrvs-core/issues/6553)
+- Update minimum password length validation [#6559](https://github.com/opencrvs/opencrvs-core/issues/6559)
+- Include middlename when generating fullnames
+  - Refactored out the scattered logic for generating fullnames and converged them into a single function
+  - Make lastname optional for a registered declaration
+- Recognize occupation as an optional field in informant section
+- Fix download failure when `arrayToFieldTransormer` is used in template mapping
+- Fix multiple records not being downloaded simultaneously [#6492](https://github.com/opencrvs/opencrvs-core/issues/6492#issuecomment-1961098936)
+- Fix showing unassigned toast for reinstated declarations [#6492](https://github.com/opencrvs/opencrvs-core/issues/6492#issuecomment-1961098936)
+- Fix system crash when opening the started action modal [#6551](https://github.com/opencrvs/opencrvs-core/issues/6551)
+- Make language names used in language select dropdowns configurable in country resource package copy
+- Fix login to field agent when an incomplete record is previously retrieved by them [#6584](https://github.com/opencrvs/opencrvs-core/issues/6584)
+
 ## [1.4.0](https://github.com/opencrvs/opencrvs-core/compare/v1.3.3...v1.4.0)
 
 In this release, we made **no changes** to OpenCRVS Core. All changes in this release apply only to the [OpenCRVS country configuration](https://github.com/opencrvs/opencrvs-countryconfig/releases/tag/v1.4.0) repository.

README.md

@@ -5,7 +5,7 @@
 <br>
 <a href="https://github.com/opencrvs/opencrvs-core/issues">Report an issue</a>  ·  <a href="https://community.opencrvs.org">Join our community</a>  ·  <a href="https://documentation.opencrvs.org">Read our documentation</a>  ·  <a href="https://www.opencrvs.org">www.opencrvs.org</a></p>
 
-[![codecov](https://codecov.io/gh/opencrvs/opencrvs-core/branch/master/graph/badge.svg)](https://codecov.io/gh/opencrvs/opencrvs-core)[![License: MPL 2.0](https://img.shields.io/badge/License-MPL%202.0-brightgreen.svg)](https://opensource.org/licenses/MPL-2.0)
+[![License: MPL 2.0](https://img.shields.io/badge/License-MPL%202.0-brightgreen.svg)](https://opensource.org/licenses/MPL-2.0)
 
 <!-- START doctoc generated TOC please keep comment here to allow auto update -->
 <!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->

package.json

@@ -1,7 +1,7 @@
 {
   "description": "OpenCRVS core workspace",
   "license": "MPL-2.0",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "private": true,
   "workspaces": [
     "packages/*"

packages/auth/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@opencrvs/auth",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "description": "OpenCRVS authentication service",
   "license": "MPL-2.0",
   "private": true,

packages/client/graphql.schema.json

@@ -7989,12 +7989,6 @@
             "isDeprecated": false,
             "deprecationReason": null
           },
-          {
-            "name": "OSIA",
-            "description": null,
-            "isDeprecated": false,
-            "deprecationReason": null
-          },
           {
             "name": "OTHER",
             "description": null,

packages/client/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@opencrvs/client",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "description": "OpenCRVS client application",
   "license": "MPL-2.0",
   "private": true,

packages/client/src/App.tsx

@@ -382,8 +382,10 @@ export function App(props: IAppProps) {
                                             <ProtectedRoute
                                               exact
                                               roles={[
+                                                SystemRoleType.RegistrationAgent,
                                                 SystemRoleType.LocalRegistrar,
                                                 SystemRoleType.LocalSystemAdmin,
+                                                SystemRoleType.NationalRegistrar,
                                                 SystemRoleType.NationalSystemAdmin,
                                                 SystemRoleType.PerformanceManagement
                                               ]}
@@ -443,7 +445,8 @@ export function App(props: IAppProps) {
                                               roles={[
                                                 SystemRoleType.LocalSystemAdmin,
                                                 SystemRoleType.NationalSystemAdmin,
-                                                SystemRoleType.PerformanceManagement
+                                                SystemRoleType.PerformanceManagement,
+                                                SystemRoleType.NationalRegistrar
                                               ]}
                                               path={
                                                 routes.PERFORMANCE_STATISTICS
@@ -455,7 +458,8 @@ export function App(props: IAppProps) {
                                               roles={[
                                                 SystemRoleType.LocalSystemAdmin,
                                                 SystemRoleType.NationalSystemAdmin,
-                                                SystemRoleType.PerformanceManagement
+                                                SystemRoleType.PerformanceManagement,
+                                                SystemRoleType.NationalRegistrar
                                               ]}
                                               path={
                                                 routes.PERFORMANCE_LEADER_BOARDS
@@ -467,7 +471,8 @@ export function App(props: IAppProps) {
                                               roles={[
                                                 SystemRoleType.LocalSystemAdmin,
                                                 SystemRoleType.NationalSystemAdmin,
-                                                SystemRoleType.PerformanceManagement
+                                                SystemRoleType.PerformanceManagement,
+                                                SystemRoleType.NationalRegistrar
                                               ]}
                                               path={
                                                 routes.PERFORMANCE_DASHBOARD

packages/client/src/components/form/FormFieldGenerator.tsx

@@ -97,7 +97,6 @@ import { InformativeRadioGroup } from '@client/views/PrintCertificate/Informativ
 import { DocumentUploaderWithOption } from './DocumentUploadfield/DocumentUploaderWithOption'
 import {
   WrappedComponentProps as IntlShapeProps,
-  FormattedMessage,
   MessageDescriptor,
   useIntl
 } from 'react-intl'
@@ -114,11 +113,7 @@ import { IOfflineData, LocationType } from '@client/offline/reducer'
 import { isEqual, flatten } from 'lodash'
 import { SimpleDocumentUploader } from './DocumentUploadfield/SimpleDocumentUploader'
 import { getOfflineData } from '@client/offline/selectors'
-import {
-  dynamicDispatch,
-  IDeclaration,
-  writeDeclaration
-} from '@client/declarations'
+import { dynamicDispatch } from '@client/declarations'
 import { useDispatch, useSelector } from 'react-redux'
 import { LocationSearch } from '@opencrvs/components/lib/LocationSearch'
 import { REGEXP_NUMBER_INPUT_NON_NUMERIC } from '@client/utils/constants'
@@ -131,16 +126,7 @@ import { IBaseAdvancedSearchState } from '@client/search/advancedSearch/utils'
 import { UserDetails } from '@client/utils/userUtils'
 import { VerificationButton } from '@opencrvs/components/lib/VerificationButton'
 import { useOnlineStatus } from '@client/utils'
-import {
-  match,
-  RouteComponentProps,
-  useHistory,
-  useLocation,
-  useRouteMatch,
-  withRouter
-} from 'react-router'
-import { saveDraftAndRedirectToNidIntegration } from '@client/views/OIDPVerificationCallback/utils'
-import { getDraftsState } from '@client/declarations/selectors'
+import { useNidAuthentication } from '@client/views/OIDPVerificationCallback/utils'
 import { BulletList, Divider } from '@opencrvs/components'
 import { Heading2, Heading3 } from '@opencrvs/components/lib/Headings/Headings'
 
@@ -778,7 +764,7 @@ interface IFormSectionProps {
 interface IStateProps {
   offlineCountryConfig: IOfflineData
   userDetails: UserDetails | null
-  declarations: IDeclaration[] | null
+  onNidAuthenticationClick: () => void
 }
 
 interface IDispatchProps {
@@ -789,7 +775,7 @@ type Props = IFormSectionProps &
   IStateProps &
   IDispatchProps &
   FormikProps<IFormSectionData> &
-  IntlShapeProps & { match: match }
+  IntlShapeProps
 
 interface IQueryData {
   [key: string]: any
@@ -1072,29 +1058,7 @@ class FormSectionComponent extends React.Component<Props> {
               : field.type === NID_VERIFICATION_BUTTON
               ? ({
                   ...field,
-                  onClick: () => {
-                    const matchParams = this.props.match.params as {
-                      declarationId: string
-                      groupId: string
-                      pageId: string
-                    }
-                    const declaration = this.props.declarations?.find(
-                      (declaration) =>
-                        declaration.id === matchParams.declarationId
-                    )
-                    if (!declaration) {
-                      return
-                    }
-                    saveDraftAndRedirectToNidIntegration(
-                      declaration,
-                      writeDeclaration,
-                      offlineCountryConfig,
-                      matchParams.declarationId,
-                      matchParams.pageId,
-                      this.props.match.url
-                    )
-                  }
-                  //TODO: HANDLE FETCH FOR NID
+                  onClick: this.props.onNidAuthenticationClick
                 } as INidVerificationButton)
               : field
 
@@ -1270,8 +1234,7 @@ export const FormFieldGenerator: React.FC<IFormSectionProps> = (props) => {
   const userDetails = useSelector(getUserDetails)
   const intl = useIntl()
   const dispatch = useDispatch()
-  const match = useRouteMatch()
-  const { declarations } = useSelector(getDraftsState)
+  const { onClick: onNidAuthenticationClick } = useNidAuthentication()
 
   return (
     <Formik<IFormSectionData>
@@ -1297,8 +1260,7 @@ export const FormFieldGenerator: React.FC<IFormSectionProps> = (props) => {
           offlineCountryConfig={offlineCountryConfig}
           userDetails={userDetails}
           dynamicDispatch={(...args) => dispatch(dynamicDispatch(...args))}
-          match={match}
-          declarations={declarations}
+          onNidAuthenticationClick={onNidAuthenticationClick}
         />
       )}
     </Formik>