No way to add required documents for registration corrections

[tokinrandr]

The upload button and the page for supporting documents have been hidden for registration corrections.
Depending on the changes, there are cases where documents are required based on configuration.

feature of OpenCRVS:
Correcting a record

Expected behaviour
You should be able to add, update, or delete supporting documents during the registration correction process.

Actual behaviour
There is no way to edit the supporting documents during the registration correction process.

To Reproduce
Steps to reproduce the behavior for the Madagascar case:
The "Father has formally recognized child" field requires a "Proof of father's ID" document.

1. Fully register a record with the parent's marital status set to "single" and the "Father has formally recognized child" field set to "false"
2. Correct the record by checking "Father has formally recognized child" to be true.
3. Scroll down to "Supporting Documents"
4. There is no button for Update, Edit or Add Documents

OpenCRVS Core & Configuration Versions:
+1.7.x: also seen in latest version (on farajaland)

Root cause
This commit is likely the cause.

[anninawersun]

@tokinrandr this is as per design:

• No supporting document can be deleted after registration because this is a permanent record of what was provided at the point of declaration.
• Supporting documents can be added through the correction process. In v1.7 this is hardcoded so you can add a court document, an affidavit and "other". You cannot add anything else.
• In v1.9 you can configure the entire correction workflow so can add whatever you want. @ThierryMyshepherd and @marcio-opencrvs will work with you on this configuration for the upgrade.