Skip to content

Commit 27602c2

Browse files
committed
add build note to assembler sources
When distros use the annobin compiler plugin [1], they have complete overview what compiler flags were used for compilation and they are able to perform security checks on the produced binaries. Compiling assembler source can't provide this kind of information by default, so we need the explicit -Wa,--generate-missing-build-notes=yes option during build. When the option is missing, then the annocheck tool reports "GAPS" in the resulting binary. [1] https://fedoraproject.org/wiki/Changes/Annobin Signed-off-by: Dan Horák <[email protected]>
1 parent 1c21758 commit 27602c2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Makefile.am

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ lib_LTLIBRARIES = libica.la
88

99
libica_la_CFLAGS = ${AM_CFLAGS} -I${srcdir}/include -I${srcdir}/../include \
1010
-fvisibility=hidden
11-
libica_la_CCASFLAGS = ${AM_CFLAGS}
11+
libica_la_CCASFLAGS = ${AM_CFLAGS} -Wa,--generate-missing-build-notes=yes
1212
libica_la_LIBADD = @LIBS@ -lrt -lcrypto
1313
libica_la_LDFLAGS = -Wl,--version-script=${srcdir}/../libica.map \
1414
-version-number ${VERSION}

0 commit comments

Comments
 (0)