Skip to content
This repository was archived by the owner on Mar 17, 2023. It is now read-only.

Commit bb240d8

Browse files
committed
Allow database user to be specified
- Allow user to change database username by setting JUPYTERHUB_DATABASE_USER - Still default to 'jupyterhub' as standard username if not set
1 parent d7b91a5 commit bb240d8

5 files changed

Lines changed: 28 additions & 2 deletions

File tree

jupyterhub_config.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,8 @@ def resolve_image_name(name):
183183
c.JupyterHub.cookie_secret_file = '/opt/app-root/data/cookie_secret'
184184

185185
if os.environ.get('JUPYTERHUB_DATABASE_PASSWORD'):
186-
c.JupyterHub.db_url = 'postgresql://jupyterhub:%s@%s:5432/%s' % (
186+
c.JupyterHub.db_url = 'postgresql://%s:%s@%s:5432/%s' % (
187+
os.environ.get('JUPYTERHUB_DATABASE_USER', 'jupyterhub'),
187188
os.environ['JUPYTERHUB_DATABASE_PASSWORD'],
188189
os.environ['JUPYTERHUB_DATABASE_HOST'],
189190
os.environ.get('JUPYTERHUB_DATABASE_NAME', 'jupyterhub'))

scripts/wait-for-database

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,11 @@
22

33
set -x
44

5+
JUPYTERHUB_DATABASE_USER=${JUPYTERHUB_DATABASE_USER:-jupyterhub}
56
JUPYTERHUB_DATABASE_NAME=${JUPYTERHUB_DATABASE_NAME:-jupyterhub}
67

78
while true; do
8-
psql "postgresql://jupyterhub:$JUPYTERHUB_DATABASE_PASSWORD@$JUPYTERHUB_DATABASE_HOST:5432/$JUPYTERHUB_DATABASE_NAME" -q -c 'SELECT 1'
9+
psql "postgresql://$JUPYTERHUB_DATABASE_USER:$JUPYTERHUB_DATABASE_PASSWORD@$JUPYTERHUB_DATABASE_HOST:5432/$JUPYTERHUB_DATABASE_NAME" -q -c 'SELECT 1'
910
if [ $? -eq 0 ]; then
1011
exit 0
1112
fi

templates/jupyterhub-deployer.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,10 @@
178178
}
179179
},
180180
"env": [
181+
{
182+
"name": "JUPYTERHUB_DATABASE_USER",
183+
"value": "jupyterhub"
184+
},
181185
{
182186
"name": "JUPYTERHUB_DATABASE_PASSWORD",
183187
"value": "${DATABASE_PASSWORD}"
@@ -221,6 +225,10 @@
221225
"name": "JUPYTERHUB_NOTEBOOK_MEMORY",
222226
"value": "${NOTEBOOK_MEMORY}"
223227
},
228+
{
229+
"name": "JUPYTERHUB_DATABASE_USER",
230+
"value": "jupyterhub"
231+
},
224232
{
225233
"name": "JUPYTERHUB_DATABASE_PASSWORD",
226234
"value": "${DATABASE_PASSWORD}"

templates/jupyterhub-quickstart.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,10 @@
255255
}
256256
},
257257
"env": [
258+
{
259+
"name": "JUPYTERHUB_DATABASE_USER",
260+
"value": "jupyterhub"
261+
},
258262
{
259263
"name": "JUPYTERHUB_DATABASE_PASSWORD",
260264
"value": "${DATABASE_PASSWORD}"
@@ -302,6 +306,10 @@
302306
"name": "JUPYTERHUB_NOTEBOOK_INTERFACE",
303307
"value": "${NOTEBOOK_INTERFACE}"
304308
},
309+
{
310+
"name": "JUPYTERHUB_DATABASE_USER",
311+
"value": "jupyterhub"
312+
},
305313
{
306314
"name": "JUPYTERHUB_DATABASE_PASSWORD",
307315
"value": "${DATABASE_PASSWORD}"

templates/jupyterhub-workspace.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,10 @@
239239
}
240240
},
241241
"env": [
242+
{
243+
"name": "JUPYTERHUB_DATABASE_USER",
244+
"value": "jupyterhub"
245+
},
242246
{
243247
"name": "JUPYTERHUB_DATABASE_PASSWORD",
244248
"value": "${DATABASE_PASSWORD}"
@@ -302,6 +306,10 @@
302306
"name": "JUPYTERHUB_IDLE_TIMEOUT",
303307
"value": "${IDLE_TIMEOUT}"
304308
},
309+
{
310+
"name": "JUPYTERHUB_DATABASE_USER",
311+
"value": "jupyterhub"
312+
},
305313
{
306314
"name": "JUPYTERHUB_DATABASE_PASSWORD",
307315
"value": "${DATABASE_PASSWORD}"

0 commit comments

Comments
 (0)