Skip to content

Commit 7b5e788

Browse files
feat: allow for more customization around embedding model
make embedding dimension, model_id, and provider_model_id configurable fields. prev hardcoded values are now defaults. update TrustyAI config to use TRUSTYAI_EMBEDDING_MODEL instead of EMBEDDING_MODEL Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
1 parent f93d817 commit 7b5e788

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

distribution/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ You can see an overview of the APIs and Providers the image ships with in the ta
1414
| batches | inline::reference | No || N/A |
1515
| datasetio | inline::localfs | No || N/A |
1616
| datasetio | remote::huggingface | No || N/A |
17-
| eval | inline::trustyai_ragas | Yes (version 0.5.1) || Set the `EMBEDDING_MODEL` environment variable |
17+
| eval | inline::trustyai_ragas | Yes (version 0.5.1) || Set the `TRUSTYAI_EMBEDDING_MODEL` environment variable |
1818
| eval | remote::trustyai_lmeval | Yes (version 0.4.1) || N/A |
1919
| eval | remote::trustyai_ragas | Yes (version 0.5.1) || Set the `KUBEFLOW_LLAMA_STACK_URL` environment variable |
2020
| files | inline::localfs | No || N/A |

distribution/run.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -122,18 +122,18 @@ providers:
122122
provider_type: remote::trustyai_lmeval
123123
module: llama_stack_provider_lmeval==0.2.4
124124
config:
125-
use_k8s: ${env.TRUSTYAI_LMEVAL_USE_K8S:=true}
126-
base_url: ${env.VLLM_URL:=http://localhost:8000/v1}
127-
- provider_id: ${env.EMBEDDING_MODEL:+trustyai_ragas_inline}
125+
use_k8s: ${env.TRUSTYAI_LMEVAL_USE_K8S:=true}
126+
base_url: ${env.VLLM_URL:=http://localhost:8000/v1}
127+
- provider_id: ${env.TRUSTYAI_EMBEDDING_MODEL:+trustyai_ragas_inline}
128128
provider_type: inline::trustyai_ragas
129129
module: llama_stack_provider_ragas.inline
130130
config:
131-
embedding_model: ${env.EMBEDDING_MODEL:=}
131+
embedding_model: ${env.TRUSTYAI_EMBEDDING_MODEL:=}
132132
- provider_id: ${env.KUBEFLOW_LLAMA_STACK_URL:+trustyai_ragas_remote}
133133
provider_type: remote::trustyai_ragas
134134
module: llama_stack_provider_ragas.remote
135135
config:
136-
embedding_model: ${env.EMBEDDING_MODEL:=}
136+
embedding_model: ${env.TRUSTYAI_EMBEDDING_MODEL:=}
137137
kubeflow_config:
138138
results_s3_prefix: ${env.KUBEFLOW_RESULTS_S3_PREFIX:=}
139139
s3_credentials_secret_name: ${env.KUBEFLOW_S3_CREDENTIALS_SECRET_NAME:=}
@@ -270,10 +270,10 @@ registered_resources:
270270
provider_id: vllm-inference
271271
model_type: llm
272272
- metadata:
273-
embedding_dimension: 768
274-
model_id: granite-embedding-125m
273+
embedding_dimension: ${env.EMBEDDING_DIMENSION:=768}
274+
model_id: ${env.EMBEDDING_MODEL:=granite-embedding-125m-english}
275275
provider_id: ${env.EMBEDDING_PROVIDER:=vllm-embedding}
276-
provider_model_id: ibm-granite/granite-embedding-125m-english
276+
provider_model_id: ${env.EMBEDDING_PROVIDER_MODEL_ID:=ibm-granite/granite-embedding-125m-english}
277277
model_type: embedding
278278
shields: []
279279
vector_dbs: []

0 commit comments

Comments
 (0)