Skip to content

Commit 20ac491

Browse files
chore(make): no need to check REPO variable (#99)
It is always defaulted and if explictly set to blank the push will fail regardless. Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com>
1 parent 8364bb9 commit 20ac491

1 file changed

Lines changed: 0 additions & 8 deletions

File tree

maas-api/Makefile

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -95,20 +95,12 @@ test: ## Run Go tests
9595

9696
.PHONY: build-image
9797
build-image: ## Build container image (use REPO= and TAG= to specify image)
98-
@if [ -z "$(REPO)" ]; then \
99-
echo "Error: REPO is required. Usage: make build-image REPO=ghcr.io/myorg/maas-api"; \
100-
exit 1; \
101-
fi
10298
@echo "Building container image $(FULL_IMAGE)..."
10399
$(CONTAINER_ENGINE) build $(CONTAINER_ENGINE_EXTRA_FLAGS) -t $(FULL_IMAGE) .
104100
@echo "Container image $(FULL_IMAGE) built successfully"
105101

106102
.PHONY: push-image
107103
push-image: ## Push container image (use REPO= and TAG= to specify image)
108-
@if [ -z "$(REPO)" ]; then \
109-
echo "Error: REPO is required. Usage: make push-image REPO=ghcr.io/myorg/maas-api"; \
110-
exit 1; \
111-
fi
112104
@echo "Pushing container image $(FULL_IMAGE)..."
113105
@$(CONTAINER_ENGINE) push $(FULL_IMAGE)
114106
@echo "Container image $(FULL_IMAGE) pushed successfully"

0 commit comments

Comments
 (0)