fix: avoid masking kubectl exit code in CatalogSource check

Separate local declaration from command substitution to preserve
kubectl's exit code. While the exit code isn't currently used in
this error path, following this best practice prevents potential
issues and improves code maintainability.

Before:
  local state=$(kubectl get catalogsource ...)

After:
  local state
  state=$(kubectl get catalogsource ...)

This ensures $? reflects kubectl's exit status, not the local builtin.

Author: somya-bhatnagar

scripts/deployment-helpers.sh

@@ -1154,7 +1154,8 @@ EOF
   if ! kubectl wait catalogsource "$name" -n "$namespace" \
       --for=jsonpath='{.status.connectionState.lastObservedState}'=READY \
       --timeout="${CATALOGSOURCE_TIMEOUT}s" 2>/dev/null; then
-    local state=$(kubectl get catalogsource "$name" -n "$namespace" \
+    local state
+    state=$(kubectl get catalogsource "$name" -n "$namespace" \
       -o jsonpath='{.status.connectionState.lastObservedState}' 2>/dev/null)
     echo "  ERROR: CatalogSource not ready after ${CATALOGSOURCE_TIMEOUT}s (state: $state)"
     return 1