Skip to content

Commit 6160077

Browse files
Yuriy TeodorovychYuriy Teodorovych
authored andcommitted
Merge branch 'main' into yt-add-go-coverage-tests
2 parents 1ef7aa1 + 535a818 commit 6160077

73 files changed

Lines changed: 8066 additions & 3043 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/hack/uninstall-leader-worker-set.sh

Lines changed: 0 additions & 60 deletions
This file was deleted.

.gitleaks.toml

Lines changed: 67 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
1+
# Gitleaks configuration for opendatahub-io repos
2+
# Synced from security-config. Do not edit in target repos.
3+
#
4+
# Path allowlists use Go regex syntax.
5+
# Real credentials should NEVER be committed to any repository.
6+
7+
[extend]
8+
useDefault = true
9+
10+
[allowlist]
11+
description = "Exclude test fixtures, mock data, sample configs, and CI resources"
12+
paths = [
13+
# Go test files (commonly contain mock credentials)
14+
'''.*_test\.go$''',
15+
16+
# JS/TS test files (.spec.ts, .test.tsx, etc.)
17+
'''.*\.spec\.(ts|tsx|js|jsx)$''',
18+
'''.*\.test\.(ts|tsx|js|jsx)$''',
19+
20+
# JS/TS test directories
21+
'''__tests__/''',
22+
23+
# Go testdata directories
24+
'''testdata/''',
25+
26+
# Python test data directories
27+
'''test_data/''',
28+
29+
# Test fixtures
30+
'''fixtures/''',
31+
32+
# JavaScript/TypeScript mocks
33+
'''__mocks__/''',
34+
35+
# Go/Java/TS mock directories
36+
'''mocks/''',
37+
'''k8mocks/''',
38+
39+
# Sample and example configs with placeholder credentials
40+
'''docs/samples/''',
41+
'''config/samples/''',
42+
'''config/overlays/test/''',
43+
44+
# CI/GitHub Actions test resources
45+
'''\.github/resources/''',
46+
47+
# E2E test credentials
48+
'''test/e2e/credentials/''',
49+
'''tests/e2e/credentials/''',
50+
51+
# OpenShift CI sample resources
52+
'''openshift-ci/resources/samples/''',
53+
54+
# Cypress test data
55+
'''cypress/fixtures/''',
56+
'''cypress/tests/mocked/''',
57+
58+
# Test certificate and key files
59+
'''tests/data/.*\.(pem|crt|key)$''',
60+
]
61+
62+
# Known test/placeholder credentials used in documentation and tests
63+
regexes = [
64+
'''database-password\s*:\s*"?(The)?BlurstOfTimes"?''',
65+
'''database-user\s*:\s*"?mlmduser"?''',
66+
'''database-user\s*:\s*"?modelregistryuser"?''',
67+
]

.gitleaksignore

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# Gitleaks ignore file
2+
# Add false positive fingerprints below (one per line)
3+
# Format: commit:file:rule-id:line or file:rule-id:line
4+
#
5+
# For path-based exclusions, use .gitleaks.toml allowlist instead.

.tekton/odh-maas-api-pull-request.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,12 @@ spec:
2929
value: maas-api/Dockerfile
3030
- name: path-context
3131
value: maas-api
32+
- name: build-platforms
33+
value:
34+
- linux/x86_64
35+
- linux/arm64
36+
- linux/ppc64le
37+
- linux/s390x
3238
- name: additional-tags
3339
value:
3440
- 'odh-pr-{{revision}}'

.tekton/odh-maas-api-push.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,12 @@ spec:
2828
value: maas-api/Dockerfile
2929
- name: path-context
3030
value: maas-api
31+
- name: build-platforms
32+
value:
33+
- linux/x86_64
34+
- linux/arm64
35+
- linux/ppc64le
36+
- linux/s390x
3137
pipelineRef:
3238
resolver: git
3339
params:

.tekton/odh-maas-controller-pull-request.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,12 @@ spec:
3434
- 'odh-pr-{{revision}}'
3535
- name: pipeline-type
3636
value: pull-request
37+
- name: build-platforms
38+
value:
39+
- linux/x86_64
40+
- linux/arm64
41+
- linux/ppc64le
42+
- linux/s390x
3743
pipelineRef:
3844
resolver: git
3945
params:

.tekton/odh-maas-controller-push.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,12 @@ spec:
2828
value: Dockerfile
2929
- name: path-context
3030
value: maas-controller
31+
- name: build-platforms
32+
value:
33+
- linux/x86_64
34+
- linux/arm64
35+
- linux/ppc64le
36+
- linux/s390x
3137
pipelineRef:
3238
resolver: git
3339
params:

OWNERS

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ approvers:
44
- chaitanya1731
55
- nerdalert
66
- jland-redhat
7+
- nirrozenbaum
78
- dmytro-zaharnytskyi
89
- SB159
910
- noyitz
@@ -21,6 +22,7 @@ reviewers:
2122
- chaitanya1731
2223
- nerdalert
2324
- jland-redhat
25+
- nirrozenbaum
2426
- dmytro-zaharnytskyi
2527
- SB159
2628
- noyitz

README.md

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,9 @@ For detailed instructions, see the [Deployment Guide](docs/content/quickstart.md
5959
|------|--------|---------|-------------|
6060
| `--deployment-mode` | `operator`, `kustomize` | `operator` | Deployment method |
6161
| `--operator-type` | `rhoai`, `odh` | `rhoai` | Which operator to install |
62-
| `--policy-engine` | `rhcl`, `kuadrant` | auto | Gateway policy engine (rhcl for operators, kuadrant for kustomize) |
6362
| `--enable-tls-backend` | flag | enabled | TLS for Authorino ↔ MaaS API |
64-
| `--skip-certmanager` | flag | auto-detect | Skip cert-manager installation |
65-
| `--skip-lws` | flag | auto-detect | Skip LeaderWorkerSet installation |
63+
| `--disable-tls-backend` | flag | `false` | Disable TLS backend |
6664
| `--namespace` | string | auto | Target namespace |
67-
| `--timeout` | seconds | `300` | Operation timeout |
6865
| `--verbose` | flag | false | Enable debug logging |
6966
| `--dry-run` | flag | false | Show plan without executing |
7067
| `--help` | flag | - | Display full help |
@@ -82,14 +79,16 @@ For detailed instructions, see the [Deployment Guide](docs/content/quickstart.md
8279
| Variable | Description | Example |
8380
|----------|-------------|---------|
8481
| `MAAS_API_IMAGE` | Custom MaaS API container image (works in both operator and kustomize modes) | `quay.io/user/maas-api:pr-123` |
82+
| `MAAS_CONTROLLER_IMAGE` | Custom MaaS controller container image | `quay.io/user/maas-controller:pr-123` |
8583
| `OPERATOR_CATALOG` | Custom operator catalog | `quay.io/opendatahub/catalog:pr-456` |
8684
| `OPERATOR_IMAGE` | Custom operator image | `quay.io/opendatahub/operator:pr-456` |
8785
| `OPERATOR_TYPE` | Operator type (rhoai/odh) | `odh` |
88-
| `POLICY_ENGINE` | Policy engine (rhcl/kuadrant) | `kuadrant` |
8986
| `LOG_LEVEL` | Logging verbosity | `DEBUG`, `INFO`, `WARN`, `ERROR` |
9087

9188
**Note:** TLS backend is enabled by default. Use `--disable-tls-backend` to disable.
9289

90+
**Note:** The policy engine is auto-determined based on operator type (`rhcl` for RHOAI, `kuadrant` for ODH/kustomize) and does not need to be set manually.
91+
9392
### Deployment Examples
9493

9594
#### Standard Deployments
@@ -119,9 +118,6 @@ MAAS_API_IMAGE=quay.io/myuser/maas-api:pr-123 \
119118
#### Minimal Deployments
120119

121120
```bash
122-
# Skip optional operators (if already installed)
123-
./scripts/deploy.sh --skip-certmanager --skip-lws
124-
125121
# Deploy without TLS backend (HTTP tier lookup)
126122
./scripts/deploy.sh --disable-tls-backend
127123
```

deployment/base/maas-api/core/deployment.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ spec:
2424
fieldPath: metadata.namespace
2525
- name: SECURE
2626
value: "false"
27+
- name: MAAS_SUBSCRIPTION_NAMESPACE
28+
value: "models-as-a-service"
2729
resources:
2830
requests:
2931
memory: "64Mi"

0 commit comments

Comments
 (0)