Skip to content

Commit 65ca551

Browse files
jrhynessclaude
andauthored
fix: add explicit command to v0.8.2 simulator models to prevent bash … (#765)
…wrapper ## Description KServe's LLMInferenceServiceConfig template injects `command: ["/bin/bash", "-c"]` for containers without an explicit command, causing v0.8.2 simulator models to crash with "invalid option" errors. This adds the explicit command back to all v0.8.2 simulator model YAMLs and updates trlp-test to v0.8.2 with consistent args. ## How Has This Been Tested? Currently running smoke test, but models no longer in CrashLoopBackOff. ``` $ oc get pods -n llm NAME READY STATUS RESTARTS AGE e2e-distinct-2-simulated-kserve-7f849f6b56-kpwp9 1/1 Running 0 21s e2e-distinct-simulated-kserve-7bb4cdb4d7-frnz5 1/1 Running 0 87s e2e-trlp-test-simulated-kserve-84db68679b-t98f7 1/1 Running 0 64s e2e-unconfigured-facebook-opt-125m-simulated-kserve-75cdcctjp2d 1/1 Running 0 66s facebook-opt-125m-simulated-kserve-8f8dc67b7-4x7g9 1/1 Running 0 57s premium-simulated-simulated-premium-kserve-6b97b89985-ln8r2 1/1 Running 0 70s ``` ## Merge criteria: <!--- This PR will be merged by any repository approver when it meets all the points in the checklist --> <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> - [ ] The commits are squashed in a cohesive manner and have meaningful messages. - [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious). - [ ] The developer has manually tested the changes and verified that the changes work <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes * **Documentation** * Updated sample model configurations to explicitly specify container execution commands for improved clarity and consistency across all sample deployments. * **Tests** * Upgraded test simulator fixture to version 0.8.2 with enhanced configuration options. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent 8f38b4c commit 65ca551

5 files changed

Lines changed: 11 additions & 1 deletion

File tree

docs/samples/models/e2e-distinct-2-simulated/model.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ spec:
1919
- name: main
2020
image: "ghcr.io/llm-d/llm-d-inference-sim:v0.8.2"
2121
imagePullPolicy: Always
22+
command: ["/app/llm-d-inference-sim"]
2223
args:
2324
- --port
2425
- "8000"

docs/samples/models/e2e-distinct-simulated/model.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ spec:
1919
- name: main
2020
image: "ghcr.io/llm-d/llm-d-inference-sim:v0.8.2"
2121
imagePullPolicy: Always
22+
command: ["/app/llm-d-inference-sim"]
2223
args:
2324
- --port
2425
- "8000"

docs/samples/models/simulator-premium/model.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ spec:
1919
- name: main
2020
image: "ghcr.io/llm-d/llm-d-inference-sim:v0.8.2"
2121
imagePullPolicy: Always
22+
command: ["/app/llm-d-inference-sim"]
2223
args:
2324
- --port
2425
- "8000"

docs/samples/models/simulator/model.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ spec:
2222
- name: main
2323
image: "ghcr.io/llm-d/llm-d-inference-sim:v0.8.2"
2424
imagePullPolicy: Always
25+
command: ["/app/llm-d-inference-sim"]
2526
args:
2627
- --port
2728
- "8000"

test/e2e/fixtures/trlp-test/llm/llmis.yaml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ spec:
1717
template:
1818
containers:
1919
- name: main
20-
image: "ghcr.io/llm-d/llm-d-inference-sim:v0.7.1"
20+
image: "ghcr.io/llm-d/llm-d-inference-sim:v0.8.2"
2121
imagePullPolicy: Always
2222
command: ["/app/llm-d-inference-sim"]
2323
args:
@@ -27,6 +27,7 @@ spec:
2727
- test/e2e-trlp-test-model
2828
- --mode
2929
- random
30+
- --no-mm-encoder-only
3031
- --ssl-certfile
3132
- /var/run/kserve/tls/tls.crt
3233
- --ssl-keyfile
@@ -42,6 +43,11 @@ spec:
4243
fieldRef:
4344
apiVersion: v1
4445
fieldPath: metadata.namespace
46+
- name: POD_IP
47+
valueFrom:
48+
fieldRef:
49+
apiVersion: v1
50+
fieldPath: status.podIP
4551
ports:
4652
- name: https
4753
containerPort: 8000

0 commit comments

Comments
 (0)